October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Replace log4j with slf4j in branding
by awels＠redhat.com 16 Oct '14

16 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: core: Replace log4j with slf4j in branding ...................................................................... core: Replace log4j with slf4j in branding Replaces log4j with slf4j in branding module. Change-Id: I8367326c229fe9eaee18258c2a477507958c3ad4 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingFilter.java M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingServlet.java M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java M backend/manager/modules/branding/src/main/modules/org/ovirt/engine/core/branding/main/module.xml 4 files changed, 26 insertions(+), 21 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8367326c229fe9eaee18258c2a477507958c3ad4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Replace log4j with slf4j in services
by yzaslavs＠redhat.com 16 Oct '14

16 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Replace log4j with slf4j in services ...................................................................... core: Replace log4j with slf4j in services Replaces log4j with slf4j in services module. Change-Id: I380f76268b4e69868668fcac987c703fbeaed386 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/services/pom.xml M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java D backend/manager/modules/services/src/main/resources/META-INF/MANIFEST.MF M ear/src/main/resources/META-INF/MANIFEST.MF 4 files changed, 6 insertions(+), 20 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I380f76268b4e69868668fcac987c703fbeaed386 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Replace log4j with JUL backend in tests
by yzaslavs＠redhat.com 16 Oct '14

16 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Replace log4j with JUL backend in tests ...................................................................... tools: Replace log4j with JUL backend in tests Replaces log4j with java.util.logging backend in tools tests. Change-Id: Iea7e88ba482dfa31472286067581adaab5830c8c Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/pom.xml D backend/manager/tools/src/test/resources/log4j.xml A backend/manager/tools/src/test/resources/logging.properties 3 files changed, 23 insertions(+), 22 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea7e88ba482dfa31472286067581adaab5830c8c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Replace log4j with JUL backend in dal tests
by yzaslavs＠redhat.com 16 Oct '14

16 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Replace log4j with JUL backend in dal tests ...................................................................... core: Replace log4j with JUL backend in dal tests Replaces log4j with java.util.logging backend in dal tests. Change-Id: I8994411aaada821a0d4e1127c24cbcc6baf39696 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/dal/pom.xml D backend/manager/modules/dal/src/test/resources/log4j.xml A backend/manager/modules/dal/src/test/resources/logging.properties 3 files changed, 35 insertions(+), 63 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8994411aaada821a0d4e1127c24cbcc6baf39696 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Replace log4j with JUL backend in bll tests
by yzaslavs＠redhat.com 16 Oct '14

16 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Replace log4j with JUL backend in bll tests ...................................................................... core: Replace log4j with JUL backend in bll tests Replaces log4j with java.util.logging backend in bll tests. Change-Id: I3ebeacfffd6de6766dc43c1d4fdf22d061781797 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/pom.xml D backend/manager/modules/bll/src/test/resources/commons-logging.properties D backend/manager/modules/bll/src/test/resources/log4j.xml A backend/manager/modules/bll/src/test/resources/logging.properties 4 files changed, 47 insertions(+), 387 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ebeacfffd6de6766dc43c1d4fdf22d061781797 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Replace log4j with slf4j in restapi
by juan.hernandez＠redhat.com 16 Oct '14

16 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: core: Replace log4j with slf4j in restapi ...................................................................... core: Replace log4j with slf4j in restapi Replaces log4j with slf4j in restapi module. Change-Id: I8109622c54eb2093753ab0c087d0d73d177aaa5a Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/jaxrs/src/main/modules/org/ovirt/engine/api/restapi-jaxrs/main/module.xml 3 files changed, 4 insertions(+), 9 deletions(-) Approvals: Martin Peřina: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8109622c54eb2093753ab0c087d0d73d177aaa5a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix javadoc references of network business entities
by masayag＠redhat.com 15 Oct '14

15 Oct '14

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix javadoc references of network business entities ...................................................................... core: Fix javadoc references of network business entities Change-Id: I188cb4f665c12030b86a30496e0c4c39530392b6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/34174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I188cb4f665c12030b86a30496e0c4c39530392b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: refactoring in UpdateVmVersionCommand
by ahadas＠redhat.com 15 Oct '14

15 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: core: refactoring in UpdateVmVersionCommand ...................................................................... core: refactoring in UpdateVmVersionCommand - extract parameters initialization to separate method - rename removeVmFromPoolParas to removeVmFromPoolParams - prevent possible NPE on getExclusiveLocks Change-Id: Id9626104a21060dcef1a60beb1b83873037f779b Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java 1 file changed, 44 insertions(+), 30 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9626104a21060dcef1a60beb1b83873037f779b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: validate storage pool on add vm
by tnisan＠redhat.com 15 Oct '14

15 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: validate storage pool on add vm ...................................................................... core: validate storage pool on add vm Change-Id: I9ee714ebbfc3addb57a7a6a00ac1f0be3087629a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1144833 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 2 files changed, 33 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ee714ebbfc3addb57a7a6a00ac1f0be3087629a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Introduce HostNetworkInterfacesPersister
by masayag＠redhat.com 15 Oct '14

15 Oct '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Introduce HostNetworkInterfacesPersister ...................................................................... engine: Introduce HostNetworkInterfacesPersister The class will be used to persist the network interfaces as reported by VDSM to the engine db: * New nics will be created * Existing nics will be updated * Unreported nics will be deleted This class will later be used for persisting the network attachments entities of each network interface. Change-Id: Iec0701a302781a9fa147c65818764bddf8429828 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CollectHostNetworkDataVdsCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkInterfacesPersister.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkInterfacesPersisterImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersister.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 7 files changed, 173 insertions(+), 64 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/34070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec0701a302781a9fa147c65818764bddf8429828 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0