October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add dependency to original sfl4j library
by yzaslavs＠redhat.com 13 Oct '14

13 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Add dependency to original sfl4j library ...................................................................... core: Add dependency to original sfl4j library 1) Adds org.slf4j module into tools category which will provide original slf4j-api.jar and slf4j-jdk14.jar so we can use slf4j in standalone tools with java.util.logging backend 2) Adds dependency to slf4j package Change-Id: I12a3fc298ec3d641e86ea5e766e7e7aa86690b14 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/tools/pom.xml A backend/manager/dependencies/tools/src/main/modules/org/slf4j/main/module.xml M ovirt-engine.spec.in M pom.xml 5 files changed, 78 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12a3fc298ec3d641e86ea5e766e7e7aa86690b14 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Move existing dependecies modules to common
by yzaslavs＠redhat.com 13 Oct '14

13 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Move existing dependecies modules to common ...................................................................... core: Move existing dependecies modules to common Moves existing dependencies modules from backend/manager/dependencies to backend/manager/dependencies/common. This is the preparation to introduce dependencies which uses different implementations for JBoss instance and for standalone tools. Change-Id: I24f42866edb74f30186a96c8baecced7f389b5db Related-To: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A backend/manager/dependencies/common/pom.xml R backend/manager/dependencies/common/src/main/modules/com/mchange/c3p0/main/module.xml R backend/manager/dependencies/common/src/main/modules/com/sun/xml/bind/main/module.xml R backend/manager/dependencies/common/src/main/modules/com/woorea/openstack/sdk/main/module.xml A backend/manager/dependencies/common/src/main/modules/org/antlr/antlr4-runtime/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/aopalliance/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/avalon/framework/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/commons/compress/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/commons/configuration/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/commons/httpclient/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/commons/io/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/commons/jxpath/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/sshd/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/ws/commons/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/xmlgraphics/batik/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/xmlgraphics/commons/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/xmlgraphics/fop/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/apache/xmlrpc/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/ovirt/engine/api/ovirt-engine-extensions-api/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/ovirt/otopi/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/ovirt/ovirt-host-deploy/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/ovirt/vdsm-jsonrpc-java/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/postgresql/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/quartz/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/snmp4j/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/springframework/ldap/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/springframework/main/module.xml R backend/manager/dependencies/common/src/main/modules/org/tukaani/xz/main/module.xml M backend/manager/dependencies/pom.xml 29 files changed, 717 insertions(+), 680 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24f42866edb74f30186a96c8baecced7f389b5db Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Adapt to splitted modules directories
by yzaslavs＠redhat.com 13 Oct '14

13 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: packaging: Adapt to splitted modules directories ...................................................................... packaging: Adapt to splitted modules directories Adapt packaging stuff to use splitted modules directories. Change-Id: I1b5c6efcf013350380a88db4b5b5f5973ba41eeb Related-To: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M Makefile M ovirt-engine.spec.in M packaging/bin/engine-prolog.sh.in M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in M packaging/services/ovirt-engine/ovirt-engine.conf.in 5 files changed, 74 insertions(+), 71 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b5c6efcf013350380a88db4b5b5f5973ba41eeb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: build: Add category to module definition
by yzaslavs＠redhat.com 13 Oct '14

13 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: build: Add category to module definition ...................................................................... build: Add category to module definition Adds a category as a parameter for jboss-modules-maven-plugin to identify usage of a module. Category can be one of: common - module is used inside JBoss instance and in standalone tools - default value tools - module is used only in standalone tools Change-Id: Ief6e14398bec4378c2153514bb69667835c3d331 Related-To: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/ModulesMojo.java M pom.xml 3 files changed, 24 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief6e14398bec4378c2153514bb69667835c3d331 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: remote_engine: support older paramiko
by sbonazzo＠redhat.com 12 Oct '14

12 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: remote_engine: support older paramiko ...................................................................... packaging: setup: remote_engine: support older paramiko Support el6's version of paramiko in which SFTPFile is not a context manager. Change-Id: I730d15670bd9aa5dc68d6d1f93157c5895429491 Bug-Url: https://bugzilla.redhat.com/1150498 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py 1 file changed, 15 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/34040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I730d15670bd9aa5dc68d6d1f93157c5895429491 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core, engine, userportal, webadmin: Fix balloon device prese...
by tnisan＠redhat.com 12 Oct '14

12 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core, engine, userportal, webadmin: Fix balloon device presence in VM pools ...................................................................... core, engine, userportal, webadmin: Fix balloon device presence in VM pools During the creation of VM pools the balloon device was enabled regardless if the user disabled it in the VM Pool Dialog. This patch fixes this bug. Change-Id: I379532f2a62ff16d8d11f34d62896125569197a1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1150777 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 5 files changed, 15 insertions(+), 0 deletions(-) Approvals: Vitor de Lima: Verified Gilad Chaplik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I379532f2a62ff16d8d11f34d62896125569197a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, engine, userportal, webadmin: Fix balloon device prese...
by ofrenkel＠redhat.com 12 Oct '14

12 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core, engine, userportal, webadmin: Fix balloon device presence in VM pools ...................................................................... core, engine, userportal, webadmin: Fix balloon device presence in VM pools During the creation of VM pools the balloon device was enabled regardless if the user disabled it in the VM Pool Dialog. This patch fixes this bug. Change-Id: I379532f2a62ff16d8d11f34d62896125569197a1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1150777 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 5 files changed, 15 insertions(+), 0 deletions(-) Approvals: Vitor de Lima: Verified Jiří Moskovčák: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I379532f2a62ff16d8d11f34d62896125569197a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: RunVmValidator storage allocation
by tnisan＠redhat.com 12 Oct '14

12 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: RunVmValidator storage allocation ...................................................................... core: RunVmValidator storage allocation This patch is a part of a series of patches, adding storage allocation validations to the system when they're missing, and replacing old verification usage with unified, new, correct and tested verification. This patch did this for RunVmValidator. In doing so, space allocation validation for stateless VM became redundant and was therefore removed. Change-Id: Ib3f7c7f31d738f84d356d4e89b05a21d4ca7a118 Bug-Url: https://bugzilla.redhat.com/1149809 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 3 files changed, 19 insertions(+), 54 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/33876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3f7c7f31d738f84d356d4e89b05a21d4ca7a118 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Reduce DB queries for interfaces in GetStats
by lvernia＠redhat.com 12 Oct '14

12 Oct '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Reduce DB queries for interfaces in GetStats ...................................................................... engine: Reduce DB queries for interfaces in GetStats The same data was fetched twice as part of the GetStats flow - now it is fetched only once and cached for reference during the flow. Change-Id: I0581f29b368fdf5771aeace2c5c200f726bdb912 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStatsVDSCommand.java 2 files changed, 23 insertions(+), 11 deletions(-) Approvals: Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0581f29b368fdf5771aeace2c5c200f726bdb912 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix button availability for qos subtab
by tnisan＠redhat.com 12 Oct '14

12 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix button availability for qos subtab ...................................................................... webadmin: fix button availability for qos subtab Change-Id: Ia91804df19b82c579254b8e87e5894133e74e7a3 Bug-Url: https://bugzilla.redhat.com/1142815 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> (cherry picked from commit 11d032c5587351730102a96ec04245bd5f0aa736) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/DataCenterQosListModel.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Tomer Saban: Verified -- To view, visit http://gerrit.ovirt.org/33899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia91804df19b82c579254b8e87e5894133e74e7a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0