October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Update commons-collections to 3.2.1
by piotr.kliczewski＠gmail.com 24 Oct '14

24 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Update commons-collections to 3.2.1 ...................................................................... core: Update commons-collections to 3.2.1 Currently we are using version 3.1 of commons-collections in our root POM, but we are actually using 3.2.1 as that is what is provided by the application server. This means that we can't use some of the methods introduced in version 3.2, like "isEmpty", but only because the build will fail. This patch updates the version number in the root POM to 3.2.1 so that we can use those methods. Change-Id: I68ed14360d61aa3d106fff2b690f7dda0507303f Related-To: https://bugzilla.redhat.com/1150953 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit df304ba2c98141bf5b859cb6f49f6850bed9396c) --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68ed14360d61aa3d106fff2b690f7dda0507303f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Fix NPE in request for CDROMs of wrong VM
by piotr.kliczewski＠gmail.com 24 Oct '14

24 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Fix NPE in request for CDROMs of wrong VM ...................................................................... restapi: Fix NPE in request for CDROMs of wrong VM Currently when we receive a request for the collection of CDROMs of a VM we don't take into account that the query performed to find the VM can return null if there isn't such a VM (the identifier is wrong, or the VM has been removed). To avoid that NPE this patch checks the result of the query and will respond with HTTP code 404 (not found) in those cases. Change-Id: I55d4742649d8d260ae4d7c924c1a9b91efbcea6b Bug-Url: https://bugzilla.redhat.com/1150953 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 8d5aa3646e2402a48f88a0532a70d9bb50347e57) --- M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendReadOnlyDevicesResource.java M backend/manager/modules/restapi/jaxrs/src/main/modules/org/ovirt/engine/api/restapi-jaxrs/main/module.xml 3 files changed, 17 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55d4742649d8d260ae4d7c924c1a9b91efbcea6b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Add snapshot id to snapshot preview RSDL
by piotr.kliczewski＠gmail.com 24 Oct '14

24 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Add snapshot id to snapshot preview RSDL ...................................................................... restapi: Add snapshot id to snapshot preview RSDL The snapshot preview action requires a snapshot id for each disk, but this isn't currently documented in the RSDL metadata. This patch adds the documentation. Change-Id: I11b0b4731d127496b1c9622c54fd3fe48309d9f3 Bug-Url: https://bugzilla.redhat.com/1150071 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit fabd4cad08ac69c726a1242854ae6f76af4ac7c8) --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11b0b4731d127496b1c9622c54fd3fe48309d9f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core, restapi, engine: Avoid enabling balloon device on VM edit
by piotr.kliczewski＠gmail.com 24 Oct '14

24 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core, restapi,engine: Avoid enabling balloon device on VM edit ...................................................................... core, restapi,engine: Avoid enabling balloon device on VM edit Avoids the creation of a balloon device on every REST API call that changes any of attibute of a VM. Change-Id: I81ba4e286eab5195b763843cd1adaaeb273070de Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152991 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Vitor de Lima: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81ba4e286eab5195b763843cd1adaaeb273070de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix NPE in request for CDROMs of wrong VM
by juan.hernandez＠redhat.com 23 Oct '14

23 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix NPE in request for CDROMs of wrong VM ...................................................................... restapi: Fix NPE in request for CDROMs of wrong VM Currently when we receive a request for the collection of CDROMs of a VM we don't take into account that the query performed to find the VM can return null if there isn't such a VM (the identifier is wrong, or the VM has been removed). To avoid that NPE this patch checks the result of the query and will respond with HTTP code 404 (not found) in those cases. Change-Id: I55d4742649d8d260ae4d7c924c1a9b91efbcea6b Bug-Url: https://bugzilla.redhat.com/1150953 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendReadOnlyDevicesResource.java M backend/manager/modules/restapi/jaxrs/src/main/modules/org/ovirt/engine/api/restapi-jaxrs/main/module.xml 3 files changed, 17 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55d4742649d8d260ae4d7c924c1a9b91efbcea6b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added puppet check scripts
by dcaroest＠redhat.com 23 Oct '14

23 Oct '14

David Caro has submitted this change and it was merged. Change subject: Added puppet check scripts ...................................................................... Added puppet check scripts Change-Id: I1b780ae35a9f8f9bb779bc16f7c2340394d3b8e7 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/infra_check_puppet/check_puppet_lint.sh A jobs/infra_check_puppet/check_rspec.sh 2 files changed, 93 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved Objections: Ewoud Kohl van Wijngaarden: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/22276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b780ae35a9f8f9bb779bc16f7c2340394d3b8e7 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <kiril.nesenko(a)gmail.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Update commons-collections to 3.2.1
by juan.hernandez＠redhat.com 23 Oct '14

23 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: core: Update commons-collections to 3.2.1 ...................................................................... core: Update commons-collections to 3.2.1 Currently we are using version 3.1 of commons-collections in our root POM, but we are actually using 3.2.1 as that is what is provided by the application server. This means that we can't use some of the methods introduced in version 3.2, like "isEmpty", but only because the build will fail. This patch updates the version number in the root POM to 3.2.1 so that we can use those methods. Change-Id: I68ed14360d61aa3d106fff2b690f7dda0507303f Related-To: https://bugzilla.redhat.com/1150953 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68ed14360d61aa3d106fff2b690f7dda0507303f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add snapshot id to snapshot preview RSDL
by juan.hernandez＠redhat.com 23 Oct '14

23 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add snapshot id to snapshot preview RSDL ...................................................................... restapi: Add snapshot id to snapshot preview RSDL The snapshot preview action requires a snapshot id for each disk, but this isn't currently documented in the RSDL metadata. This patch adds the documentation. Change-Id: I11b0b4731d127496b1c9622c54fd3fe48309d9f3 Bug-Url: https://bugzilla.redhat.com/1150071 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11b0b4731d127496b1c9622c54fd3fe48309d9f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, frontend: Query to get raw provider certificates
by juan.hernandez＠redhat.com 23 Oct '14

23 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: core, frontend: Query to get raw provider certificates ...................................................................... core, frontend: Query to get raw provider certificates Currently we have a query that retrieves the certificates of an external provider converted to a string, and this string is displayed to the user. The RESTAPI can't easily consume this text, it should rather get the raw certificates and render them so that callers can decide what information to extract. To make this possible this patch renames the existing query, to make it clear that it returns just the text, and adds a new one that returns the raw certificates, intended for use by the RESTAPI. Change-Id: Ie5270bff9b671943fdea1c31369b7ad1d0dd4f67 Related-To: https://bugzilla.redhat.com/1132259 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateChainQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateChainTextQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 4 files changed, 73 insertions(+), 17 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Martin Betak: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5270bff9b671943fdea1c31369b7ad1d0dd4f67 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add version 3.6
by juan.hernandez＠redhat.com 23 Oct '14

23 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add version 3.6 ...................................................................... restapi: Add version 3.6 This patch adds version 3.6 to the capabilities resource. Change-Id: I73266b8e38241dece9e3937297bdc397740469b5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73266b8e38241dece9e3937297bdc397740469b5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0