October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: cleanup - removed unused code
by amureini＠redhat.com 01 Oct '14

01 Oct '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: cleanup - removed unused code ...................................................................... core: cleanup - removed unused code As part of storage allocation checks refactoring, some deprecated methods are no longer used. Some lingered in the code, and are now removed. Change-Id: I2b9f46e6763d84adce2fbc98c9375a4146b22873 Related-To:https://bugzilla.redhat.com/960934 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java 2 files changed, 0 insertions(+), 47 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b9f46e6763d84adce2fbc98c9375a4146b22873 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: notifier: add support for snmpv6 in SNMP_MANAGERS.
by oourfali＠redhat.com 01 Oct '14

01 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: notifier: add support for snmpv6 in SNMP_MANAGERS. ...................................................................... notifier: add support for snmpv6 in SNMP_MANAGERS. Change-Id: I9a21038928b7e553feefb9ab7669eac588c1c93c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073498 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> (cherry picked from commit 89ecae235bd8f73b8e44044b1fe6ae32562035da) --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java A backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/transport/snmp/ProfileTest.java M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 3 files changed, 60 insertions(+), 4 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a21038928b7e553feefb9ab7669eac588c1c93c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core : Display custom error page if reports is not installed
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core : Display custom error page if reports is not installed ...................................................................... core : Display custom error page if reports is not installed When reports is not installed the link from /ovirt-engine/ page takes you to 404 page when user clicks on reports link. A custom error page is displayed that shows the message that reports is not installed Change-Id: Idaed902328695e2d448ac49c414ddfbde8d3fd25 Bug-Url: https://bugzilla.redhat.com/1143998 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java M backend/manager/modules/welcome/src/main/resources/messages.properties M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml M packaging/services/ovirt-engine/ovirt-engine.conf.in 5 files changed, 40 insertions(+), 9 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaed902328695e2d448ac49c414ddfbde8d3fd25 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: connection timeout overriden by client timeout
by oourfali＠redhat.com 01 Oct '14

01 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: connection timeout overriden by client timeout ...................................................................... core: connection timeout overriden by client timeout Connection timeout setting was overriden by client timeout. Bug-Url: https://bugzilla.redhat.com/1147487 Change-Id: I6b8b3154071b98f802f001481abf80be5865fe74 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M ovirt-engine.spec.in M pom.xml 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b8b3154071b98f802f001481abf80be5865fe74 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core:fixing step numbering for steps and sub-steps
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core:fixing step numbering for steps and sub-steps ...................................................................... core:fixing step numbering for steps and sub-steps When a step is added to a job, it should get its step_number value according to the existing steps already added to the job. The same is for adding sub-step to an exiting step. This patch fix a problem in adding step/sub-step when all added steps/sub-steps get a 0 for the step_number value. This resulted in incorrect order of steps and sub-steps in the UI while steps where ordered by the step_number but this had no affect since the step_number was always 0. Change-Id: Ic72e9ab64160116f4fbac3f3b2cdea63db7b9c75 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148466 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java 3 files changed, 20 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic72e9ab64160116f4fbac3f3b2cdea63db7b9c75 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: Dialog box header drag
by awels＠redhat.com 01 Oct '14

01 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: Dialog box header drag ...................................................................... userportal, webadmin: Dialog box header drag - The drag box on dialogs was only 20 px high, while the header was 36 px high. This caused it to not be clear where you could and could drag the window. This patch makes the entire header dragable. - Replaced tabs with spaces in DialogBox.css. Change-Id: I712203d343102c1a61f5256eb0eefbe7162a1d78 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139634 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/DialogBox.css 1 file changed, 18 insertions(+), 18 deletions(-) Approvals: Alexander Wels: Verified Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I712203d343102c1a61f5256eb0eefbe7162a1d78 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Use GetEntity instead of storageDomain
by mlipchuk＠redhat.com 01 Oct '14

01 Oct '14

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Use GetEntity instead of storageDomain ...................................................................... webadmin: Use GetEntity instead of storageDomain The storageDomain selected in the GUI when detaching a local Storage Domain intialized with storage pool id and therefore will fail the operation of detach local Storage Domain. Instead using storageDomain we should use getEntity Change-Id: I594cee0e9130869b0c3ff55b6ecd004f8a42f61e Bug-Url: https://bugzilla.redhat.com/1148417 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I594cee0e9130869b0c3ff55b6ecd004f8a42f61e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: gluster: Check gluster uuid when updating brick status
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: gluster: Check gluster uuid when updating brick status ...................................................................... gluster: Check gluster uuid when updating brick status If vdsm output for glusterVolumeStatus returns the gluster host uuid - use this to get the corresponding brick in the database. This will solve the issue with brick qualified name using a different hostname than the one engine is aware of. Change-Id: Iffea910092f693b83e51f92ea13f1014b8a40faf Bug-Url: https://bugzilla.redhat.com/1103973 Signed-off-by: Sahina Bose <sabose(a)redhat.com> (cherry picked from commit 373a729df42d97f326478fa445170a369b6c0920) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java 1 file changed, 32 insertions(+), 3 deletions(-) Approvals: Sahina Bose: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffea910092f693b83e51f92ea13f1014b8a40faf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add a lock when detaching Storage from Data Center
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add a lock when detaching Storage from Data Center ...................................................................... core: Add a lock when detaching Storage from Data Center Add a lock in the Storage Domain when detaching a Storage Domain from Data Center. Bug-Url: https://bugzilla.redhat.com/1144845 Change-Id: I42c6be592ad6d71579ce0aa20926856cbca23d44 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 3 files changed, 22 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42c6be592ad6d71579ce0aa20926856cbca23d44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add lock on attach Storage Domain process
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add lock on attach Storage Domain process ...................................................................... core: Add lock on attach Storage Domain process Add a lock in the Storage Domain when attaching a Storage Domain to Data Center. Change-Id: Icc484b92d5e49cbe8c01f371f057639220e21428 Bug-Url: https://bugzilla.redhat.com/1144845 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc484b92d5e49cbe8c01f371f057639220e21428 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0