Change in ovirt-engine[ovirt-engine-3.5]: aaa: Change DbUser getters of group fields
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: Change DbUser getters of group fields
......................................................................
aaa: Change DbUser getters of group fields
The getters will return a copy of the collection
and not an umodifyable collection, as unmofiyable collection
as no default ctor, thus cannot be deserialized by jackson
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/1155084
Change-Id: I03873642ac547b11c66bad42b68c33d7687c8d5a
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03873642ac547b11c66bad42b68c33d7687c8d5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: Change the check of internal command execution
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: Change the check of internal command execution
......................................................................
aaa: Change the check of internal command execution
Both canDoAction and executeAction set the isSucceeded flag
to false if they fail.
We should check if AddUser or AddGroup failed not just by their
canDoAction phase, but also by their execution phase.
Hence, using the isSuceeded flag is more appropriate solution.
Bug-Url: https://bugzilla.redhat.com/1121954
Change-Id: Ie7093e3e20387c2cb9d56c818ac4b74d49b07ad1
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7093e3e20387c2cb9d56c818ac4b74d49b07ad1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Correct text in storage domain maintenance popup
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Correct text in storage domain maintenance popup
......................................................................
webadmin: Correct text in storage domain maintenance popup
Change-Id: Ibbf8cefe6bfebf034789a696750c19e749b00d10
Bug-Url: https://bugzilla.redhat.com/1149476
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34342
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbf8cefe6bfebf034789a696750c19e749b00d10
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: userportal: optimize GetAllFromVms query
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: userportal: optimize GetAllFromVms query
......................................................................
userportal: optimize GetAllFromVms query
Rewrote the stored function to optimize the query inside GetAllFromVms
Splitting out the boolean for simplicity
Joining instead of using exists on a complicated view
Removing distinct, as it's already inside the joined view
Change-Id: I541c9172c3ba9bcf989f9660baf06ec2e1fd02d7
Bug-Url: https://bugzilla.redhat.com/1151477
Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com>
---
M packaging/dbscripts/vms_sp.sql
1 file changed, 11 insertions(+), 6 deletions(-)
Approvals:
Pablo Iranzo Gómez: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Tim Speetjens: Verified
Liran Zelkha: Looks good to me, but someone else must approve
Tomáš Došek: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/34006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I541c9172c3ba9bcf989f9660baf06ec2e1fd02d7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tim Speetjens <tim.speetjens(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Pablo Iranzo Gómez <Pablo.Iranzo(a)redhat.com>
Gerrit-Reviewer: Tim Speetjens <tim.speetjens(a)gmail.com>
Gerrit-Reviewer: Tomáš Došek <tdosek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: protocol fall back for older vdsms
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: protocol fall back for older vdsms
......................................................................
core: protocol fall back for older vdsms
When we try to install new host which only supports xmlrpc and we have
cluster with compatibility level set to 3.5+ the code will fail.
Solution for this issue is attempting to connect by using jsonrpc and if
it fails falling back to xmlrpc.
Bug-Url: https://bugzilla.redhat.com/1149655
Change-Id: Ie6f48bec60b520c089f326f8c5e79aec288ff3d6
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FutureVDSCommandType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/TimeBoundPollVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TimeBoundPollVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
11 files changed, 236 insertions(+), 3 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34098
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6f48bec60b520c089f326f8c5e79aec288ff3d6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: protocol fall back for older vdsms
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: protocol fall back for older vdsms
......................................................................
core: protocol fall back for older vdsms
When we try to install new host which only supports xmlrpc and we have
cluster with compatibility level set to 3.5+ the code will fail.
Solution for this issue is attempting to connect by using jsonrpc and if
it fails falling back to xmlrpc.
Bug-Url: https://bugzilla.redhat.com/1149655
Change-Id: Ie9af3129a4adf839f2d4c2e110425a6c69e45256
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
4 files changed, 56 insertions(+), 11 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34255
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9af3129a4adf839f2d4c2e110425a6c69e45256
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: aaa: Change DbUser getters of group fields
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Change DbUser getters of group fields
......................................................................
aaa: Change DbUser getters of group fields
The getters will return a copy of the collection
and not an umodifyable collection, as unmofiyable collection
as no default ctor, thus cannot be deserialized by jackson
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/1155084
Change-Id: I03873642ac547b11c66bad42b68c33d7687c8d5a
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
Liron Aravot: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34360
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03873642ac547b11c66bad42b68c33d7687c8d5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Improve performance of getVmDeviceByVmId
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Improve performance of getVmDeviceByVmId
......................................................................
core: Improve performance of getVmDeviceByVmId
getVmDeviceByVmId is calling a query on vm_device_view
using vm_id as a parameter. Since vm_id does not have an
index, this query takes a long time.
This patch added an index, which improved performance in the
perf environemnt from 56ms to 0.2ms.
Change-Id: Icc45e9dd3e4b0cd23d0d28b017b19da13f315d5b
Bug-Url: https://bugzilla.redhat.com/1154421
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_05_1100_create_index_on_vm_device.sql
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/34377
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc45e9dd3e4b0cd23d0d28b017b19da13f315d5b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Improve performance of updateAllDiskImageDynamicWithDi...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Improve performance of updateAllDiskImageDynamicWithDiskIdByVmId
......................................................................
core: Improve performance of updateAllDiskImageDynamicWithDiskIdByVmId
updateAllDiskImageDynamicWithDiskIdByVmId is running an update on the
disk_image_dynamic table, using a subquery on the images table.
Since images table does not have an index on image_group_id, and images
can be a rather big table, this patch adds such an index.
Change-Id: I1610d633dde009f55485e3081f4094d60cd25e09
Bug-Url: https://bugzilla.redhat.com/1155153
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_05_1090_create_index_on_images.sql
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/34376
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1610d633dde009f55485e3081f4094d60cd25e09
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: osinfo - adding VirtIO to disk hotplug for ppc
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: osinfo - adding VirtIO to disk hotplug for ppc
......................................................................
core: osinfo - adding VirtIO to disk hotplug for ppc
osinfo properties:
adding 'VirtIO' to ppc64.devices.disk.hotpluggableInterfaces
Change-Id: If87f5ec844bf4ae41e94c7702e52b059af0d59a2
Bug-Url: https://bugzilla.redhat.com/1155223
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M packaging/conf/osinfo-defaults.properties
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Vitor de Lima: Looks good to me, but someone else must approve
Daniel Erez: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If87f5ec844bf4ae41e94c7702e52b059af0d59a2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months