Change in ovirt-engine[ovirt-engine-3.5]: core: removing CR char after encoding
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: removing CR char after encoding
......................................................................
core: removing CR char after encoding
Change-Id: I2c11ec26e25cf39084a889ec475f400a8318e5eb
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1145636
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
3 files changed, 14 insertions(+), 5 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c11ec26e25cf39084a889ec475f400a8318e5eb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: Improve performance of getVmDeviceByVmId
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Improve performance of getVmDeviceByVmId
......................................................................
core: Improve performance of getVmDeviceByVmId
getVmDeviceByVmId is calling a query on vm_device_view
using vm_id as a parameter. Since vm_id does not have an
index, this query takes a long time.
This patch added an index, which improved performance in the
perf environemnt from 56ms to 0.2ms.
Change-Id: Icc45e9dd3e4b0cd23d0d28b017b19da13f315d5b
Bug-Url: https://bugzilla.redhat.com/1154421
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_06_0450_create_index_on_vm_device.sql
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liran Zelkha: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/34349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc45e9dd3e4b0cd23d0d28b017b19da13f315d5b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: Improve performance of updateAllDiskImageDynamicWithDi...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Improve performance of updateAllDiskImageDynamicWithDiskIdByVmId
......................................................................
core: Improve performance of updateAllDiskImageDynamicWithDiskIdByVmId
updateAllDiskImageDynamicWithDiskIdByVmId is running an update on the
disk_image_dynamic table, using a subquery on the images table.
Since images table does not have an index on image_group_id, and images
can be a rather big table, this patch adds such an index.
Change-Id: I1610d633dde009f55485e3081f4094d60cd25e09
Bug-Url: https://bugzilla.redhat.com/1155153
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_06_0440_create_index_on_images.sql
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liran Zelkha: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/34343
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1610d633dde009f55485e3081f4094d60cd25e09
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: copy vm-init data on new template version
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: copy vm-init data on new template version
......................................................................
core: copy vm-init data on new template version
when creating new template version, the vm-init data is not copied,
because the vmInit is not marked for copy.
since the vm-init is saved in a different table, it need to be
manually loaded.
also, the is_initialized flag need to be reset so vms will do sysprep
again with new data.
Change-Id: Icaf1b6cad241008c8e6f392cb918e900b340d9b2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148379
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
2 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaf1b6cad241008c8e6f392cb918e900b340d9b2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: dont use getVmPayload query for updateVmVersionCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: dont use getVmPayload query for updateVmVersionCommand
......................................................................
core: dont use getVmPayload query for updateVmVersionCommand
when calling getVmPayloadQuery from updateVmVersionCommand there is NPE
because the current-user is null, since this command is executed
internaly.
replaced the call to the query with a simple db query
Change-Id: I37472aff69087e23cf4206819c84c0e0f115fcc2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148379
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
1 file changed, 14 insertions(+), 8 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37472aff69087e23cf4206819c84c0e0f115fcc2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: use previous disk operator on template version update
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: use previous disk operator on template version update
......................................................................
core: use previous disk operator on template version update
Updating the template version for a VM when the template contained disks
didn't work because no user was selected to serve as the disks operator.
This patch fixes it by setting the user that used to be disk operator
for one of the disks of the VM while it was based on the previous
template version, as the disk operator of the disks from the new
template version.
Change-Id: Idd9604c7a219e49d140576a66c9b15e9abb34d79
Bug-Url: https://bugzilla.redhat.com/1149135
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmVersionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
5 files changed, 45 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/34304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd9604c7a219e49d140576a66c9b15e9abb34d79
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: use the right template on template version update
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: use the right template on template version update
......................................................................
core: use the right template on template version update
Move the setting of the template & template id that the VM is going to
switch-to in UpdateVmVersionCommand to the constructor.
Change-Id: I7dd3475b30267c918497e4971ebd1da1cfb6e58e
Bug-Url: https://bugzilla.redhat.com/1149135
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
1 file changed, 10 insertions(+), 13 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/34303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7dd3475b30267c918497e4971ebd1da1cfb6e58e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: ensureColumnPresentFix
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal,webadmin: ensureColumnPresentFix
......................................................................
userportal,webadmin: ensureColumnPresentFix
- ensureColumnPresentFix would check if the column existed and
then would remove it and add it back again. This would cause
the index of the column to fluctuate and cause the width loading
to fail. This patch fixes the issue.
Change-Id: I82f725fd98a1690c16fd01a40fa1c05a27d3237e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124546
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Alexander Wels: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34283
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82f725fd98a1690c16fd01a40fa1c05a27d3237e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Improve performance of getdisksvmguid
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Improve performance of getdisksvmguid
......................................................................
core: Improve performance of getdisksvmguid
getdisksvmguid is using view all_disks_including_snapshots which used
UNION instead of UNION ALL. This caused a needless performance hit.
On the performance environment it reduced execution from 2.2s to 700ms.
Change-Id: If037bf4a20f7cae9dd6ab6e7f95bcf0681b3bda1
Bug-Url: https://bugzilla.redhat.com/1141543
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liran Zelkha: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/34346
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If037bf4a20f7cae9dd6ab6e7f95bcf0681b3bda1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-reports[master]: packaging: setup: require java detection
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: setup: require java detection
......................................................................
packaging: setup: require java detection
Will be required after http://gerrit.ovirt.org/33410 is merged.
Change-Id: I0c4f1868f6d3fd71bae52fce4f05395f808c18d4
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jboss.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/33677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c4f1868f6d3fd71bae52fce4f05395f808c18d4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months