October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Replace oVirt logger with slf4j in bll/network
by yzaslavs＠redhat.com 22 Oct '14

22 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Replace oVirt logger with slf4j in bll/network ...................................................................... core: Replace oVirt logger with slf4j in bll/network Replaces oVirt logger with slf4j in bll/network package. Stacktraces are logged only to debug for exceptions with clear custom error message. Change-Id: I9af76a3f79de2677060eb1dc36420f6be6433670 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolManagerRanges.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDc.java 6 files changed, 37 insertions(+), 36 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9af76a3f79de2677060eb1dc36420f6be6433670 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Replace oVirt logger with slf4j in bll/gluster
by yzaslavs＠redhat.com 22 Oct '14

22 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Replace oVirt logger with slf4j in bll/gluster ...................................................................... core: Replace oVirt logger with slf4j in bll/gluster Replaces oVirt logger with slf4j in bll/gluster package. Stacktraces are logged only to debug for exceptions with clear custom error message. Change-Id: I6f5419168ce6b26c110839dcd85cac995e5aa5db Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJobsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTasksService.java 7 files changed, 106 insertions(+), 88 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Sahina Bose: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f5419168ce6b26c110839dcd85cac995e5aa5db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Replace oVirt logger with slf4j in bll/XXX
by yzaslavs＠redhat.com 22 Oct '14

22 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Replace oVirt logger with slf4j in bll/XXX ...................................................................... core: Replace oVirt logger with slf4j in bll/XXX Replaces oVirt logger with slf4j in following bll subpackages: dwh, eventqueue, job, lock, lsm, memory, pm, provider, quota and snapshots. Stacktraces are logged only to debug for exceptions with clear custom error message. Change-Id: I564678b8226542a4900450f8a0e5aa0c7249df70 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ExternalTrustStoreInitializer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 10 files changed, 90 insertions(+), 80 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I564678b8226542a4900450f8a0e5aa0c7249df70 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Replace oVirt logger with slf4j in bll/job
by yzaslavs＠redhat.com 22 Oct '14

22 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Replace oVirt logger with slf4j in bll/job ...................................................................... core: Replace oVirt logger with slf4j in bll/job Replaces oVirt logger with slf4j in bll/job package. Stacktraces are logged only to debug for exceptions with clear custom error message. Change-Id: I1546a4b1183442aa0a8784e722442e9ddd09d716 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryCleanupManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java 3 files changed, 60 insertions(+), 35 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1546a4b1183442aa0a8784e722442e9ddd09d716 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Improve performance of getdisksvmguid
by oourfali＠redhat.com 22 Oct '14

22 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Improve performance of getdisksvmguid ...................................................................... core: Improve performance of getdisksvmguid getdisksvmguid is using view all_disks_including_snapshots which used UNION instead of UNION ALL. This caused a needless performance hit. On the performance environment it reduced execution from 2.2s to 700ms. Change-Id: If037bf4a20f7cae9dd6ab6e7f95bcf0681b3bda1 Bug-Url: https://bugzilla.redhat.com/1141543 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Allon Mureinik: Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/34341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If037bf4a20f7cae9dd6ab6e7f95bcf0681b3bda1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: notifier: modify the oid schema for SNMP notification.
by oourfali＠redhat.com 22 Oct '14

22 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: notifier: modify the oid schema for SNMP notification. ...................................................................... notifier: modify the oid schema for SNMP notification. MIB syntax tested using: $ smilint -p packaging/doc/mibs/REDHAT-MIB.txt -l 6 \ packaging/doc/mibs/OVIRT-MIB.txt Change-Id: Ic8a06063f8ebbbe4d05783cb25036e870a6be3b7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136818 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M Makefile M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java M ovirt-engine.spec.in A packaging/doc/mibs/OVIRT-MIB.txt A packaging/doc/mibs/REDHAT-MIB.txt M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 6 files changed, 429 insertions(+), 62 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8a06063f8ebbbe4d05783cb25036e870a6be3b7 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Change duplicate action type values to unique ones
by oourfali＠redhat.com 22 Oct '14

22 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Change duplicate action type values to unique ones ...................................................................... core: Change duplicate action type values to unique ones Since the action type value is supposed to be unique, a test will be added to enforce uniqueness of the action type values prior to that, since we have duplicate values in the VdcActionType class we have to change first the duplicate values to different values to ensure uniqueness Change-Id: I6de787be50f8ef0149805bd0292ece2ab81aa465 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145977 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6de787be50f8ef0149805bd0292ece2ab81aa465 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add uniqueness test to AuditLogValue
by oourfali＠redhat.com 22 Oct '14

22 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add uniqueness test to AuditLogValue ...................................................................... core: Add uniqueness test to AuditLogValue Since the audit log value is supposed to be unique, this test will enforce the uniqueness of the audit log values Change-Id: I8e3f58d7ccf8a6477fafbac94d6e1057ecefe23a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145977 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/AuditLogTypeTest.java 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e3f58d7ccf8a6477fafbac94d6e1057ecefe23a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Change duplicate audit log values to unique ones
by oourfali＠redhat.com 22 Oct '14

22 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Change duplicate audit log values to unique ones ...................................................................... core: Change duplicate audit log values to unique ones Since the audit log value is supposed to be unique, a test will be added to enforce uniqueness of the audit log values prior to that, since we have duplicate values in the AuditLogType class we have to change first the duplicate values to different values to ensure uniqueness Change-Id: Ife969c6a094ba8acf4b7b1544be017d8a034485f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145977 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 34 insertions(+), 34 deletions(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife969c6a094ba8acf4b7b1544be017d8a034485f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removing CR char after encoding
by ofrenkel＠redhat.com 22 Oct '14

22 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: removing CR char after encoding ...................................................................... core: removing CR char after encoding Change-Id: I2c11ec26e25cf39084a889ec475f400a8318e5eb Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 3 files changed, 14 insertions(+), 5 deletions(-) Approvals: Piotr Kliczewski: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c11ec26e25cf39084a889ec475f400a8318e5eb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0