Change in ovirt-engine[ovirt-engine-3.5]: engine: Removed unwanted exception logging
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Removed unwanted exception logging
......................................................................
engine: Removed unwanted exception logging
Gluster task monitoring checks periodically for
gluster tasks list from the cluster, and if there
are no operational hosts in the cluster, an
exception is logged.
Removing the noise from this logging as it
confuses the user.
Change-Id: I9b24fe99a1cb66155a9ff24f149a20db32e76307
Bug-Url: https://bugzilla.redhat.com/1138128
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
(cherry picked from commit be0f7e8f506cec907f91cd2a393abdf5663594b6)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTasksService.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sahina Bose: Verified
Ramesh N: Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33040
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b24fe99a1cb66155a9ff24f149a20db32e76307
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: change the audit log for migration retry
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: change the audit log for migration retry
......................................................................
core: change the audit log for migration retry
The audit log severity was changed from ERROR to WARNING and it was
rephrased to be more similar to the audit log which is used for retry to
run VM.
Change-Id: I3b43136ba87763e47ccf3ce9e41e41ae67df179d
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/34267
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b43136ba87763e47ccf3ce9e41e41ae67df179d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: new audit log for failed migration to server
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: new audit log for failed migration to server
......................................................................
core: new audit log for failed migration to server
The unused audit log VM_MIGRATION_FAILED_FROM_TO was renamed to
VM_MIGRATION_TO_SERVER_FAILED, and it is now used when migrate to server
fails.
Soon VM_MIGRATION_FAILED won't include the destination host, thus this
new audit log that does have the destination host is used for failed
migration to server instead.
Change-Id: I074836f713cc708c9b680bb2d6b3e99af17f66c3
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
A packaging/dbscripts/upgrade/03_06_0430_add_migrate_to_server_failed_event.sql
6 files changed, 13 insertions(+), 3 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/28928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I074836f713cc708c9b680bb2d6b3e99af17f66c3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: copy vm-init data on new template version
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: copy vm-init data on new template version
......................................................................
core: copy vm-init data on new template version
when creating new template version, the vm-init data is not copied,
because the vmInit is not marked for copy.
since the vm-init is saved in a different table, it need to be
manually loaded.
also, the is_initialized flag need to be reset so vms will do sysprep
again with new data.
Change-Id: Icaf1b6cad241008c8e6f392cb918e900b340d9b2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148379
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
2 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34282
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaf1b6cad241008c8e6f392cb918e900b340d9b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: dont use getVmPayload query for updateVmVersionCommand
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: dont use getVmPayload query for updateVmVersionCommand
......................................................................
core: dont use getVmPayload query for updateVmVersionCommand
when calling getVmPayloadQuery from updateVmVersionCommand there is NPE
because the current-user is null, since this command is executed
internaly.
replaced the call to the query with a simple db query
Change-Id: I37472aff69087e23cf4206819c84c0e0f115fcc2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148379
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
1 file changed, 14 insertions(+), 8 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37472aff69087e23cf4206819c84c0e0f115fcc2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: vdsbroker: Remove dubious method use
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: vdsbroker: Remove dubious method use
......................................................................
vdsbroker: Remove dubious method use
Coverity complains about using a new object to getClass so we reuse
STATUS_DONE object now.
Change-Id: If1147d2a14e2cc118624a7edb1cf9355b0521fce
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34248
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1147d2a14e2cc118624a7edb1cf9355b0521fce
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: webadmin: Change text in storage tab and subtabs to fit stan...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Change text in storage tab and subtabs to fit standards
......................................................................
webadmin: Change text in storage tab and subtabs to fit standards
Change-Id: If38af6989b524ef53ebe1e3ab7b9c299020a4fa7
Bug-Url: https://bugzilla.redhat.com/1149471
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34261
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If38af6989b524ef53ebe1e3ab7b9c299020a4fa7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: webadmin: Change type field name in data center dialog to st...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Change type field name in data center dialog to storage type
......................................................................
webadmin: Change type field name in data center dialog to storage type
Change-Id: Ia28a61d6e8daa72efdeaa15021bb5152df766aed
Bug-Url: https://bugzilla.redhat.com/1143958
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia28a61d6e8daa72efdeaa15021bb5152df766aed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: preview partial snapshot confirmation dialog
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: preview partial snapshot confirmation dialog
......................................................................
webadmin: preview partial snapshot confirmation dialog
When selecting to preview a snapshot that contains only
a subset of the VM disks, a 'Preview Partial Snapshot'
dialog should be displayed. The dialog suggests a couple
of options to the user for proceeding (see screenshot).
Screenshot: http://i.imgur.com/m7wsgB8.png
Change-Id: Iabd59025d7c7b96ae92898efe34e20985d2e9750
Bug-Url: https://bugzilla.redhat.com/1095808
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmSnapshotPreviewPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmSnapshotPreviewPopupView.java
11 files changed, 305 insertions(+), 60 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/34247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabd59025d7c7b96ae92898efe34e20985d2e9750
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in jenkins[master]: drop 3.4 jobs
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: drop 3.4 jobs
......................................................................
drop 3.4 jobs
3.4.z is not developed anymore, dropping 3.4 jobs.
Change-Id: I9f7d701a6535a04520e6e8a99bd55edecdfd9f81
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/yaml/jobs/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml
M jobs/confs/yaml/jobs/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup_create-rpms.yaml
M jobs/confs/yaml/jobs/ovirt-image-uploader/ovirt-image-uploader_create-rpms.yaml
M jobs/confs/yaml/jobs/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml
M jobs/confs/yaml/jobs/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml
M jobs/confs/yaml/jobs/ovirt-reports/ovirt-reports_create-rpms.yaml
M jobs/confs/yaml/jobs/vdsm/vdsm_create-rpms.yaml
7 files changed, 0 insertions(+), 90 deletions(-)
Approvals:
Simone Tiraboschi: Looks good to me, but someone else must approve
Eyal Edri: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f7d701a6535a04520e6e8a99bd55edecdfd9f81
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
