October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: vds georepstatus detail fix coverity issue
by kmayilsa＠redhat.com 20 Oct '14

20 Oct '14

Kanagaraj M has submitted this change and it was merged. Change subject: engine: vds georepstatus detail fix coverity issue ...................................................................... engine: vds georepstatus detail fix coverity issue Fix issue with possible NPE uncovered by coverity Change-Id: Ie479af39252f4e961f04e8f38d11c0e0998f2d98 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java 1 file changed, 17 insertions(+), 15 deletions(-) Approvals: Kanagaraj M: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/34246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie479af39252f4e961f04e8f38d11c0e0998f2d98 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: adding missing IDs for bookmark and search buttons
by awels＠redhat.com 20 Oct '14

20 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: adding missing IDs for bookmark and search buttons ...................................................................... webadmin: adding missing IDs for bookmark and search buttons Change-Id: I72a9cfb2d513805c39ec66f9764c4d28f68d003c Bug-Url: https://bugzilla.redhat.com/1148530 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/SearchPanelView.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72a9cfb2d513805c39ec66f9764c4d28f68d003c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: use new element-id-capable SortedColumn for vm sta...
by awels＠redhat.com 20 Oct '14

20 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: use new element-id-capable SortedColumn for vm statustext ...................................................................... webadmin: use new element-id-capable SortedColumn for vm statustext In the VM main tab, the 'status text' column lost its static element id, probably when it was made into a SortedColumn or a composite column. Added infrastructure for a SortedColumnWithElementId and switched the column to that. Change-Id: I97bb0a04d46e94efede5f46af35ebcee01a9dd70 Bug-Url: https://bugzilla.redhat.com/1148530 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCellWithElementId.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CellWithElementId.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CompositeCellWithElementId.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SortableColumnWithElementId.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 6 files changed, 156 insertions(+), 12 deletions(-) Approvals: Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97bb0a04d46e94efede5f46af35ebcee01a9dd70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: remove utils.log usage
by yzaslavs＠redhat.com 20 Oct '14

20 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: remove utils.log usage ...................................................................... host-deploy: remove utils.log usage Bug-Url: https://bugzilla.redhat.com/1109871 Change-Id: Ice1daf34637e66afea8ce0c7ea3b70d7659a4542 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java 3 files changed, 43 insertions(+), 41 deletions(-) Approvals: Alon Bar-Lev: Verified Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice1daf34637e66afea8ce0c7ea3b70d7659a4542 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: master: add support for Fedora 21
by sbonazzo＠redhat.com 20 Oct '14

20 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: master: add support for Fedora 21 ...................................................................... master: add support for Fedora 21 - Add Fedora 21 repository Change-Id: Ibb672c5464e6a87f16de7c8164baf37e1b9de626 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-master/Makefile.am M ovirt-release-master/configure.ac A ovirt-release-master/ovirt-f21-deps.repo.in M ovirt-release-master/ovirt-release-master.spec.in 4 files changed, 16 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Eyal Edri: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb672c5464e6a87f16de7c8164baf37e1b9de626 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: removed code duplicates regarding PermissionListModel
by lvernia＠redhat.com 20 Oct '14

20 Oct '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: removed code duplicates regarding PermissionListModel ...................................................................... webadmin: removed code duplicates regarding PermissionListModel Change-Id: Ib42a6f7059c7a21b5681258e8c48d85168654bad Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/PoolModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/StorageModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VnicProfileModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java 11 files changed, 67 insertions(+), 254 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib42a6f7059c7a21b5681258e8c48d85168654bad Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: packaging: spec: modify junit maven plugin to match fc21
by Alon Bar-Lev 20 Oct '14

20 Oct '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: modify junit maven plugin to match fc21 ...................................................................... packaging: spec: modify junit maven plugin to match fc21 Change-Id: Id3fc583074d3d7bb98be3ad23ace68e04b37e0ce Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M otopi.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3fc583074d3d7bb98be3ad23ace68e04b37e0ce Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: gui for adding macPool permissions.
by lvernia＠redhat.com 20 Oct '14

20 Oct '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: gui for adding macPool permissions. ...................................................................... webadmin: gui for adding macPool permissions. Change-Id: Idb6b442e7eebce367b9008f4b9c1df9ade84745f Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/UiCommonModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/SharedMacPoolView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/MacPoolPermissionModelProvider.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/PermissionModelProvider.java 6 files changed, 157 insertions(+), 6 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb6b442e7eebce367b9008f4b9c1df9ade84745f Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Removed "-" from "Data-Centers" in Err Msg
by tnisan＠redhat.com 20 Oct '14

20 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Removed "-" from "Data-Centers" in Err Msg ...................................................................... frontend: Removed "-" from "Data-Centers" in Err Msg To be consistent with the UI's terminology, the error message "There are no active Data-Centers in the system." was changed to "There are no active Data Centers in the system.". Change-Id: Ie1cdf14e67366b7007a64dc24e127623cfeee2c9 Bug-Url: https://bugzilla.redhat.com/1141794 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1cdf14e67366b7007a64dc24e127623cfeee2c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: show host-id for a vm in an unknown state
by tnisan＠redhat.com 20 Oct '14

20 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: show host-id for a vm in an unknown state ...................................................................... restapi: show host-id for a vm in an unknown state When a VM was running in an unknown state, REST would not return the current host-id for that VM. Changed mapper to return host-id (and other dynamic info) as long as the VM is not down for sure. Change-Id: I8010522e42d1a7cfc963b2408b22c3bc468e30eb Bug-Url: https://bugzilla.redhat.com/1144938 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eldan Shachar: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8010522e42d1a7cfc963b2408b22c3bc468e30eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0