October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: Fixing build for fedora 21
by sbonazzo＠redhat.com 20 Oct '14

20 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: aaa: Fixing build for fedora 21 ...................................................................... aaa: Fixing build for fedora 21 Fixes InitializingBeand and DisposableBean not begin not recognized Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)rehdat.com> Change-Id: Id3e9d6366a34ff6315833180940a7275804a1519 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/pom.xml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/34226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3e9d6366a34ff6315833180940a7275804a1519 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Refactor QoS view side
by lvernia＠redhat.com 20 Oct '14

20 Oct '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Refactor QoS view side ...................................................................... webadmin: Refactor QoS view side The business entity and model aspects of QoS were recently refactored into a reasonable class hierarchy, this does the same for the view aspect of things to ease implementation of additional QoS dialogs (e.g. host network QoS). Change-Id: Ia6c3be8a4ed4378ef10512fbef3e5a7e17f521a4 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/CpuQosPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/StorageQosPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/CpuQosPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/CpuQosWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/CpuQosWidget.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/QosPopupView.java R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/QosPopupView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/QosWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/StorageQosPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/StorageQosWidget.java 10 files changed, 244 insertions(+), 192 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/34126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6c3be8a4ed4378ef10512fbef3e5a7e17f521a4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: preview partial snapshot confirmation dialog
by derez＠redhat.com 20 Oct '14

20 Oct '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: preview partial snapshot confirmation dialog ...................................................................... webadmin: preview partial snapshot confirmation dialog When selecting to preview a snapshot that contains only a subset of the VM disks, a 'Preview Partial Snapshot' dialog should be displayed. The dialog suggests a couple of options to the user for proceeding (see screenshot). Screenshot: http://i.imgur.com/m7wsgB8.png Change-Id: Iabd59025d7c7b96ae92898efe34e20985d2e9750 Bug-Url: https://bugzilla.redhat.com/1095808 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmSnapshotPreviewPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmSnapshotPreviewPopupView.java 11 files changed, 305 insertions(+), 60 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabd59025d7c7b96ae92898efe34e20985d2e9750 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Replace oVirt logger with slf4j in aaa
by yzaslavs＠redhat.com 19 Oct '14

19 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Replace oVirt logger with slf4j in aaa ...................................................................... core: Replace oVirt logger with slf4j in aaa Replaces oVirt logger with slf4j in aaa module. Change-Id: Ic51dce32ddfd2453dbb0d143b8ca83ae76663b8b Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DbUserCacheManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/ValidateSessionQuery.java 4 files changed, 38 insertions(+), 55 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic51dce32ddfd2453dbb0d143b8ca83ae76663b8b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use MDC to hold correlation id
by yzaslavs＠redhat.com 19 Oct '14

19 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: use MDC to hold correlation id ...................................................................... core: use MDC to hold correlation id apparently the slf4j within jboss and MDC support of the log handler are integrated, so we can levarage that in order to delegate correlation id to log without actually have our own logger. all methods of getting correlation id out of this context seems to be presentation only usage which is correct. Bug-Url: https://bugzilla.redhat.com/1109871 Change-Id: Iff53d3bf420e6fe1b1a0a04a0a21a49a3c01a4d2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/interceptors/CorrelationIdTrackerInterceptor.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/interceptors/ThreadLocalSessionCleanerInterceptor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCommandBaseTest.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/CorrelationIdTracker.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ThreadLocalParamsContainer.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Log.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/LogFactory.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java M packaging/services/ovirt-engine/ovirt-engine.xml.in 15 files changed, 91 insertions(+), 107 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff53d3bf420e6fe1b1a0a04a0a21a49a3c01a4d2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: prevent transaction roll back on restore stateless vm
by ahadas＠redhat.com 19 Oct '14

19 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: core: prevent transaction roll back on restore stateless vm ...................................................................... core: prevent transaction roll back on restore stateless vm If template version update was made successfully when restoring stateless VM, we didn't call setSucceeded(true) so the transaction was rolled-back. So this patch adds the missing call. Change-Id: I9714a4675225ef87ca4e1bdcf934aa87f02428fc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9714a4675225ef87ca4e1bdcf934aa87f02428fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: refactoring in AddVmAndAttachToPool
by ahadas＠redhat.com 19 Oct '14

19 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: core: refactoring in AddVmAndAttachToPool ...................................................................... core: refactoring in AddVmAndAttachToPool Extract the parameters initialization from the execute method to separate method. Change-Id: Iace5caf71c6692ab6700240aeacb0ef696873e2c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java 1 file changed, 28 insertions(+), 30 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iace5caf71c6692ab6700240aeacb0ef696873e2c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: db:add tab/col name validation to common functions
by tnisan＠redhat.com 19 Oct '14

19 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: db:add tab/col name validation to common functions ...................................................................... db:add tab/col name validation to common functions No error thrown in common_sp functions in case column or table does not exists. This patch adds validations to drop/change type/rename column common functions in order to prevent the setup continue in case that there was an error in the table/column name. This patch also fix some upgrade scripts that used invalid/non-existing column names. Change-Id: Iba5f087f3d47b4f36bb99151a21c2e1016d77b64 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1141829 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql M packaging/dbscripts/upgrade/03_03_0060_drop_desktop_device.sql M packaging/dbscripts/upgrade/03_03_0380_remove_auto_suspend.sql M packaging/dbscripts/upgrade/03_03_0710_add_profile_to_network_interface.sql 4 files changed, 14 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba5f087f3d47b4f36bb99151a21c2e1016d77b64 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.5]: build: oVirt Live 3.5.0
by sbonazzo＠redhat.com 17 Oct '14

17 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 3.5.0 ...................................................................... build: oVirt Live 3.5.0 Change-Id: I687a09bd653b9eab477b75c3fa504c1cc69e66b4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I687a09bd653b9eab477b75c3fa504c1cc69e66b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: VDS command to stop and delete geo-rep session
by kmayilsa＠redhat.com 17 Oct '14

17 Oct '14

Kanagaraj M has submitted this change and it was merged. Change subject: engine: VDS command to stop and delete geo-rep session ...................................................................... engine: VDS command to stop and delete geo-rep session VDS command to stop and delete geo-replication session Change-Id: Ib9f4a32783f2b119a56873b4c1290b10f8b208c8 Bug-Url: https://bugzilla.redhat.com/1125845 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepSessionVDSParameters.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteGlusterVolumeGeoRepSessionVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterVolumeGeoRepSessionVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 12 files changed, 136 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/33006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9f4a32783f2b119a56873b4c1290b10f8b208c8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0