October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5.0]: core: dont copy old num of sockets on hotplug
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: dont copy old num of sockets on hotplug ...................................................................... core: dont copy old num of sockets on hotplug when editing running vm, all fields that are not editable, are copied from the old vm to new vm, as they are saved in the running snapshot, and db reflect the actual running config. when user select to do hot-set to cpu, the number of sockets should not be copied with the old value, as it is used in the hot-set command. this is fixed by sending to the copy method, if this is a hot-set flow, and it will check it when doing copy of the old value, for hot-set allowed fields. Change-Id: I57bcd2287350c3146f06fe2a5c9a583c88dded04 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151827 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 3 files changed, 19 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57bcd2287350c3146f06fe2a5c9a583c88dded04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.0 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5.0]: core, engine: Fix VM CD change in JSON RPC
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core, engine: Fix VM CD change in JSON RPC ...................................................................... core, engine: Fix VM CD change in JSON RPC This change fixes a NPE while changing the CD of a running VM. Change-Id: I976354fca483d1cdb45ba7abc006924eb7041af7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145728 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vitor de Lima: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I976354fca483d1cdb45ba7abc006924eb7041af7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.0 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix alignment issues in Cluster Detail popup
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix alignment issues in Cluster Detail popup ...................................................................... webadmin: Fix alignment issues in Cluster Detail popup Fixes alignment issues in Cluster Detail popup caused by the length of text in French translation. Change-Id: I34048f9485bffe2066e527e710bf9f3eff687e07 Bug-Url: https://bugzilla.redhat.com/1150599 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34048f9485bffe2066e527e710bf9f3eff687e07 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: RemoveDiskSnapshots - sort images from parent to leaf
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: RemoveDiskSnapshots - sort images from parent to leaf ...................................................................... core: RemoveDiskSnapshots - sort images from parent to leaf When removing multiple disk snapshots that belongs to the same disk, the images should be sorted from parent to leaf (active). Sorting is needed since removing a child image and a parent image afterwards, might be invalid - as the parent will point to another child and when deletion is done in consecutive order there's a race condition between DB update and removing next parent. Change-Id: I759537f7c32fc9b19a968f32767bba633f3f3366 Bug-Url: https://bugzilla.redhat.com/1151841 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759537f7c32fc9b19a968f32767bba633f3f3366 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix numa x icon close button
by dfediuck＠redhat.com 14 Oct '14

14 Oct '14

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: fix numa x icon close button ...................................................................... webadmin: fix numa x icon close button Change-Id: Ia9bb1245a58d328cb7815e092c553a6a19f8a362 Bug-Url: https://bugzilla.redhat.com/1147883 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/numa/NumaSupportPopupPresenterWidget.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/34115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9bb1245a58d328cb7815e092c553a6a19f8a362 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Expose stop/start retry/delay configuration.
by oourfali＠redhat.com 14 Oct '14

14 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Expose stop/start retry/delay configuration. ...................................................................... core: Expose stop/start retry/delay configuration. Expose stop/start retry/delay configuration to engine-config This patch exposes the following values to engine-config: FenceStopStatusDelayBetweenRetriesInSec (10) FenceStopStatusRetries (18) FenceStartStatusDelayBetweenRetriesInSec (10) FenceStartStatusRetries (18) The values in brackets are the default values so currently we are waiting for the desired status for 3 min while pooling it each 10 sec for 18 times. There may be cases that those values should be customized and therefor those values should be exposed to engine-config Change-Id: I71c4af7b6d8fcdacaaff4abfec40b4fdf9cf5abf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1147218 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71c4af7b6d8fcdacaaff4abfec40b4fdf9cf5abf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RemoveDiskSnapshots - sort images from parent to leaf
by derez＠redhat.com 14 Oct '14

14 Oct '14

Daniel Erez has submitted this change and it was merged. Change subject: core: RemoveDiskSnapshots - sort images from parent to leaf ...................................................................... core: RemoveDiskSnapshots - sort images from parent to leaf When removing multiple disk snapshots that belongs to the same disk, the images should be sorted from parent to leaf (active). Sorting is needed since removing a child image and a parent image afterwards, might be invalid - as the parent will point to another child and when deletion is done in consecutive order there's a race condition between DB update and removing next parent. Change-Id: I759537f7c32fc9b19a968f32767bba633f3f3366 Bug-Url: https://bugzilla.redhat.com/1151841 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759537f7c32fc9b19a968f32767bba633f3f3366 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Set Migrate On Error in Data Center Guide Me
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Set Migrate On Error in Data Center Guide Me ...................................................................... webadmin: Set Migrate On Error in Data Center Guide Me The Add Cluster dialog in the Data Center "Guide Me" was not setting the chosen Migrate On Error action in the VDSGroup instance that is sent to the AddVdsGroup command. Change-Id: I7498ae26f1ff2fcd90e547aae48fb66e25bb4a43 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142658 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Vitor de Lima: Verified -- To view, visit http://gerrit.ovirt.org/34013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7498ae26f1ff2fcd90e547aae48fb66e25bb4a43 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Suppress compiler warnings for unchecked cast
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Suppress compiler warnings for unchecked cast ...................................................................... aaa: Suppress compiler warnings for unchecked cast Suppress two compiler warnings for unchecked casts There is no more targeted approach for suppressing it properly in NegotiationFilter, hence the "unchecked" warnings are suppressed for the complete doFilter method. Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Host SSH Fingerprint success message shouldn't be ...
by oourfali＠redhat.com 14 Oct '14

14 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Host SSH Fingerprint success message shouldn't be in red text ...................................................................... webadmin: Host SSH Fingerprint success message shouldn't be in red text When host SSH fingerprint is fetched successfully the sucess message is displayed in red. Change-Id: I28c5a3c82202733a9a628b80a50634c7ccb19d85 Bug-Url: https://bugzilla.redhat.com/1148567 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 15 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28c5a3c82202733a9a628b80a50634c7ccb19d85 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0