October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: use previous disk operator on template version update
by ahadas＠redhat.com 15 Oct '14

15 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: core: use previous disk operator on template version update ...................................................................... core: use previous disk operator on template version update Updating the template version for a VM when the template contained disks didn't work because no user was selected to serve as the disks operator. This patch fixes it by setting the user that used to be disk operator for one of the disks of the VM while it was based on the previous template version, as the disk operator of the disks from the new template version. Change-Id: Idd9604c7a219e49d140576a66c9b15e9abb34d79 Bug-Url: https://bugzilla.redhat.com/1149135 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmVersionParameters.java 5 files changed, 47 insertions(+), 3 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd9604c7a219e49d140576a66c9b15e9abb34d79 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: validate storage pool on add vm
by ofrenkel＠redhat.com 15 Oct '14

15 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: validate storage pool on add vm ...................................................................... core: validate storage pool on add vm Change-Id: I9ee714ebbfc3addb57a7a6a00ac1f0be3087629a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1144833 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 2 files changed, 33 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ee714ebbfc3addb57a7a6a00ac1f0be3087629a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use the right template on template version update
by ahadas＠redhat.com 15 Oct '14

15 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: core: use the right template on template version update ...................................................................... core: use the right template on template version update Move the setting of the template & template id that the VM is going to switch-to in UpdateVmVersionCommand to the constructor. Change-Id: I7dd3475b30267c918497e4971ebd1da1cfb6e58e Bug-Url: https://bugzilla.redhat.com/1149135 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java 1 file changed, 10 insertions(+), 13 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dd3475b30267c918497e4971ebd1da1cfb6e58e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Host SSH Fingerprint success message shouldn't be ...
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Host SSH Fingerprint success message shouldn't be in red text ...................................................................... webadmin: Host SSH Fingerprint success message shouldn't be in red text When host SSH fingerprint is fetched successfully the sucess message is displayed in red. Change-Id: I28c5a3c82202733a9a628b80a50634c7ccb19d85 Bug-Url: https://bugzilla.redhat.com/1148567 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 15 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28c5a3c82202733a9a628b80a50634c7ccb19d85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: validate storage pool on add vm"
by ofrenkel＠redhat.com 14 Oct '14

14 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: Revert "core: validate storage pool on add vm" ...................................................................... Revert "core: validate storage pool on add vm" This reverts commit a3dc3f4aab526b0dc43ee092ad4c6e8aae88e7b4. since it breaks the tests Change-Id: Ib6b51784998251722e9c78b667d908a06a1c2f9b Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6b51784998251722e9c78b667d908a06a1c2f9b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: validate storage pool on add vm
by ahadas＠redhat.com 14 Oct '14

14 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: core: validate storage pool on add vm ...................................................................... core: validate storage pool on add vm Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1144833 Change-Id: Iab8633bf0abdbed10b40a18605febab033c1b336 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab8633bf0abdbed10b40a18605febab033c1b336 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Refactor QoS model side
by lvernia＠redhat.com 14 Oct '14

14 Oct '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Refactor QoS model side ...................................................................... webadmin: Refactor QoS model side The hierarchy was overly-complex; the new and edit branches of the hierarchy tree were hardly any different and did not merit separation. The logic of the separation was also inconsistent, as executeSave() was shared but performed operations the edit branch didn't require, while the init() was mutually exclusive. Also added validation for QosParametersModel as part of the generic QosModel flow. Change-Id: I2374a54fbe1dc744b71071869b4a23ebc100acea Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/CpuQosParametersModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/DataCenterCpuQosListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/DataCenterQosListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/DataCenterStorageQosListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/EditCpuQosModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/EditQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/EditStorageQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/NewCpuQosModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/NewQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/NewStorageQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/QosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/QosParametersModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/StorageQosParametersModel.java 13 files changed, 62 insertions(+), 115 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/34125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2374a54fbe1dc744b71071869b4a23ebc100acea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix vertical positioning of checkbox and label
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix vertical positioning of checkbox and label ...................................................................... webadmin: Fix vertical positioning of checkbox and label Fixes vertical positioning of checkbox and its label if checkbox is placed on the right of its label. Change-Id: I38f8cf40fccfb0ec34672915f7aad15b2b08da75 Bug-Url: https://bugzilla.redhat.com/1148868 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38f8cf40fccfb0ec34672915f7aad15b2b08da75 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix pm policy checkbox label width
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix pm policy checkbox label width ...................................................................... webadmin: Fix pm policy checkbox label width Fixes PM policy checkbox label witdth in Power Management tab in Host Detail popup. This problem appears only in Firefox 31 on RHEL 6. Change-Id: I9731f94ca73f4f1eb06b2c6ddb409953255565dc Bug-Url: https://bugzilla.redhat.com/1148868 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9731f94ca73f4f1eb06b2c6ddb409953255565dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Correction of UI Constant
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Correction of UI Constant ...................................................................... webadmin: Correction of UI Constant Detach Storage dialog text related issues solved: "Data Center(s)" was changed to "Data Center", "Detach storage" was changed to "Detach Storage" Change-Id: I8a0848956c472fae929e36841de65d893e728d96 Bug-Url: https://bugzilla.redhat.com/1149457 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a0848956c472fae929e36841de65d893e728d96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0