October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: post ovirt-engine-dwh-3.5.0
by ydary＠redhat.com 06 Oct '14

06 Oct '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.5.0 ...................................................................... build: post ovirt-engine-dwh-3.5.0 Change-Id: I0bf84852ea0419b739b8f72e9446ced561e0fbc2 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bf84852ea0419b739b8f72e9446ced561e0fbc2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: ovirt-engine-dwh-3.5.0-1
by ydary＠redhat.com 06 Oct '14

06 Oct '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.5.0-1 ...................................................................... build: ovirt-engine-dwh-3.5.0-1 Change-Id: Ic616654c335b63c70fa5a7a894eebf3e60417ee9 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic616654c335b63c70fa5a7a894eebf3e60417ee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix use of "unregistered" parameter
by juan.hernandez＠redhat.com 06 Oct '14

06 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix use of "unregistered" parameter ...................................................................... restapi: Fix use of "unregistered" parameter The "unregister" matrix parameter is used to include unregistered objects (disks, templates and VMs) when listing or adding them. But the paremeter is currently documented incorrectly, as it is missing from some operations where it is used and included in other operations where it isn't used. As a result the RSDL is incorrect and the Python and Java SDKs don't implement it correctly. This patch fixes the documentation of the parameter. Change-Id: Ifccc9082d71cc6bb14ae9dfc7efd3c024a82639f Bug-Url: https://bugzilla.redhat.com/1148715 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifccc9082d71cc6bb14ae9dfc7efd3c024a82639f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: post ovirt-engine-reports-3.5.0
by ydary＠redhat.com 06 Oct '14

06 Oct '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.5.0 ...................................................................... build: post ovirt-engine-reports-3.5.0 Change-Id: I831543b57c369a342dba03b2afa8908cc03cae08 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I831543b57c369a342dba03b2afa8908cc03cae08 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: ovirt-engine-reports-3.5.0-1
by ydary＠redhat.com 06 Oct '14

06 Oct '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.5.0-1 ...................................................................... build: ovirt-engine-reports-3.5.0-1 Change-Id: I35d0d5428c14cd9ff707afdd5307ab7d401373a7 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35d0d5428c14cd9ff707afdd5307ab7d401373a7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5.0]: build: ovirt-engine-3.5.0
by sbonazzo＠redhat.com 06 Oct '14

06 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-engine-3.5.0 ...................................................................... build: ovirt-engine-3.5.0 Change-Id: Ib6ce1d7d5d1afb59e64bc81bd3128c8b2ccb555d Bug-Url: https://bugzilla.redhat.com/1073943 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dependencies/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 52 files changed, 58 insertions(+), 55 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6ce1d7d5d1afb59e64bc81bd3128c8b2ccb555d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Log error correctly when connecting domain for removal
by tnisan＠redhat.com 05 Oct '14

05 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Log error correctly when connecting domain for removal ...................................................................... core: Log error correctly when connecting domain for removal When connecting to a storage domain as a part of its removal (or format in case of ISO domains) if the connection fails, the error is not logged correctly and instead we get a generic error, this was fixed and instead the generic error we will get the real cause Change-Id: Idd7435336acbec41edbdd70568f1dfdce664f875 Bug-Url: https://bugzilla.redhat.com/1003266 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 7 files changed, 56 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd7435336acbec41edbdd70568f1dfdce664f875 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core : Add custom error page for reports
by oourfali＠redhat.com 05 Oct '14

05 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : Add custom error page for reports ...................................................................... core : Add custom error page for reports Custom error page for reports not installed error message Change-Id: Ic4489ef8a5a7d07734094e3c974fdaa215f44bef Bug-Url: https://bugzilla.redhat.com/1143998 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/welcome/src/main/webapp/WEB-INF/ReportsNotInstalled.jsp 1 file changed, 43 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4489ef8a5a7d07734094e3c974fdaa215f44bef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: VmSnapshotList - filter LunDisks on getVmDiskList
by tnisan＠redhat.com 05 Oct '14

05 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: VmSnapshotList - filter LunDisks on getVmDiskList ...................................................................... webadmin: VmSnapshotList - filter LunDisks on getVmDiskList VmSnapshotList -> updatePreviewedDiskSnapshots: filer LunDisks from 'getVmDiskList' result. Change-Id: Iaf983d1a8095b8739cd0e4ff4a872100f3e2c921 Bug-Url: https://bugzilla.redhat.com/1148424 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/33723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf983d1a8095b8739cd0e4ff4a872100f3e2c921 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Log error correctly when connecting domain for removal
by tnisan＠redhat.com 05 Oct '14

05 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Log error correctly when connecting domain for removal ...................................................................... core: Log error correctly when connecting domain for removal When connecting to a storage domain as a part of its removal (or format in case of ISO domains) if the connection fails, the error is not logged correctly and instead we get a generic error, this was fixed and instead the generic error we will get the real cause Change-Id: Idd7435336acbec41edbdd70568f1dfdce664f875 Bug-Url: https://bugzilla.redhat.com/1003266 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 7 files changed, 56 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd7435336acbec41edbdd70568f1dfdce664f875 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0