October 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: adding QoS network name to vm network interface table

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: adding QoS network name to vm network interface table ...................................................................... webadmin: adding QoS network name to vm network interface table Change-Id: I1f9359d6874b6a655f7ddab4e82f9efd9d3480e1 Bug-Url: https://bugzilla.redhat.com/1103493 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f9359d6874b6a655f7ddab4e82f9efd9d3480e1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Hot plug CPU - allow over-commit in QEMU limits

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: core: Hot plug CPU - allow over-commit in QEMU limits ...................................................................... core: Hot plug CPU - allow over-commit in QEMU limits Allow to hot plug CPUs up to QEMU limits[1] even if they over-commit the host resources. [1] http://doc.opensuse.org/products/draft/SLES/SLES-kvm_sd_draft/cha.kvm.lim... Change-Id: Ic27aefa52543b201d018d07296de1e4983bfb863 Bug-Url: https://bugzilla.redhat.com/1097195 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetNumberOfCpusCommand.java 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic27aefa52543b201d018d07296de1e4983bfb863 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: tools: CidrValidation Utils

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: tools: CidrValidation Utils ...................................................................... tools: CidrValidation Utils Cidr validator - check for format correctness and valid network address including UTest Change-Id: Ib1277dbc815953926fe1648350cd55cb75e1084a Bug-Url: https://bugzilla.redhat.com/1080074 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/CidrValidator.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/CidrValidatorTest.java 3 files changed, 177 insertions(+), 1 deletion(-) Approvals: Eliraz Levi: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1277dbc815953926fe1648350cd55cb75e1084a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core, webadmin: show list of changed fields when updating run...

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core,webadmin: show list of changed fields when updating running vm ...................................................................... core,webadmin: show list of changed fields when updating running vm When updating running vm, a msg is shown if some of the fields can be updated only after restart. This is changed to list those fields for the user. Change-Id: Idf13a19d1b193037226cb49bc6c1e8cefc0553b8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1119791 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmUpdatesOnNextRunExistsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQueryTest.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmChangedFieldsForNextRunParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmNextRunConfigurationPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmNextRunConfigurationPopupView.java 17 files changed, 161 insertions(+), 74 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf13a19d1b193037226cb49bc6c1e8cefc0553b8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core : Fix NPE in CommandBase buildCommandEntity

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core : Fix NPE in CommandBase buildCommandEntity ...................................................................... core : Fix NPE in CommandBase buildCommandEntity When execution context is null CommandBase buildCommandEntity throws a NPE. Change-Id: I6f6a2b7e0727a22a9649d0b305000f59eb4236a1 Bug-Url: https://bugzilla.redhat.com/1147971 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f6a2b7e0727a22a9649d0b305000f59eb4236a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: LiveSnapshotTaskHandler - remove setExecutionContext(n...

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: LiveSnapshotTaskHandler - remove setExecutionContext(null) ...................................................................... core: LiveSnapshotTaskHandler - remove setExecutionContext(null) LiveSnapshotTaskHandler -> endSuccessfully / endWithFailure: remove 'enclosingCommand.setExecutionContext(null)' to avoid an NPE on CommandBase -> buildCommandEntity. Change-Id: I45ee451b62ff1f41f8ad03f707c105c1db70a768 Bug-Url: https://bugzilla.redhat.com/1147971 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45ee451b62ff1f41f8ad03f707c105c1db70a768 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: RemoveDiskSnapshots - verify image existence

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: RemoveDiskSnapshots - verify image existence ...................................................................... core: RemoveDiskSnapshots - verify image existence RemoveDiskSnapshotsCommand -> getImages(): Ensure image existence in DB before adding into images list (to avoid adding null to the list). Change-Id: I06fd2062b8c359d2abd7e64e559d1d82197e0d76 Bug-Url: https://bugzilla.redhat.com/1134866 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06fd2062b8c359d2abd7e64e559d1d82197e0d76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: allow to maintenance host if install failed

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core: allow to maintenance host if install failed ...................................................................... core: allow to maintenance host if install failed Allow to put host in maintenance if install failed This patch allows to put a host in maintenance in case that host installation failed. In networking problems it may occur that after trying to put the host in maintenance it will go to preparing for maintenance=>Non Responding and we will have to put it in maintenance again. Change-Id: Ic3611e4fb7ac039ee4014f6cb158b0da5067331e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1147988 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3611e4fb7ac039ee4014f6cb158b0da5067331e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: adding QoS network name to vmNetworkInterface entity

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: adding QoS network name to vmNetworkInterface entity ...................................................................... engine: adding QoS network name to vmNetworkInterface entity Change-Id: Id8480381c42626bba80284345bee8b437b77b7fc Bug-Url: https://bugzilla.redhat.com/1103493 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoDbFacadeImpl.java M packaging/dbscripts/create_views.sql 3 files changed, 20 insertions(+), 4 deletions(-) Approvals: Eliraz Levi: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8480381c42626bba80284345bee8b437b77b7fc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core : Fix NPE in CommandBase buildCommandEntity

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core : Fix NPE in CommandBase buildCommandEntity ...................................................................... core : Fix NPE in CommandBase buildCommandEntity When execution context is null CommandBase buildCommandEntity throws a NPE. Change-Id: I6f6a2b7e0727a22a9649d0b305000f59eb4236a1 Bug-Url: https://bugzilla.redhat.com/1147971 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Allon Mureinik: Looks good to me, approved Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f6a2b7e0727a22a9649d0b305000f59eb4236a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2014