Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: keeping PostgreSQL port open if the DBMS i...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: keeping PostgreSQL port open if the DBMS is local
......................................................................
packaging: setup: keeping PostgreSQL port open if the DBMS is local
on system with iptables engine-setup is going to completely
rewrite iptables rules. Kepping DB port open if the DBMS is local
also if we are not upgrading.
Change-Id: I92350ec322162e8c199174cf6fa7a1d517af8998
Bug-Url: https://bugzilla.redhat.com/1141286
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit 4c306381352b8c1e7c2fd4b61fabad29abf9ffbe)
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/32875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92350ec322162e8c199174cf6fa7a1d517af8998
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: keeping NFS ports open in case of preexist...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: keeping NFS ports open in case of preexisting exports
......................................................................
packaging: setup: keeping NFS ports open in case of preexisting exports
Looking for preexisting NFS exports in order to correctly evaluate
how to configure NFS related rules on the firewall.
Change-Id: Id99ac88af780c6239655676b5290230076d0284b
Bug-Url: https://bugzilla.redhat.com/1109326
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit ad949fcf34a99885186db30b435675d595f546c9)
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
1 file changed, 21 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/32874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id99ac88af780c6239655676b5290230076d0284b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine[master]: core: Set job message properties correct in ForceSelectSPMCo...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Set job message properties correct in ForceSelectSPMCommand
......................................................................
core: Set job message properties correct in ForceSelectSPMCommand
Change-Id: Ib5c3bafdfaea54c354729a3c2c477d0bb61ecb74
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1144841
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ForceSelectSPMCommand.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33661
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5c3bafdfaea54c354729a3c2c477d0bb61ecb74
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine[master]: core: Check validity of new storage connection mount options...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Check validity of new storage connection mount options ignoring case
......................................................................
core: Check validity of new storage connection mount options ignoring case
When adding a new NFS/Posix storage server connection, the custom mount
options should be validated case insensitively
Change-Id: Ie5334bdef5955a9b48e266d8dae7ecb339ccc376
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1141500
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommandTest.java
2 files changed, 11 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33635
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5334bdef5955a9b48e266d8dae7ecb339ccc376
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: fix attaching a cluster to a new DC
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix attaching a cluster to a new DC
......................................................................
core: fix attaching a cluster to a new DC
This patch fixes attaching a cluster to a new DC after its original DC
was removed.
In that case if the cluster has a host it will loss its dc id settings
and will try to insert to the vds_spm_map table empty GUID as the DC id.
Code was changed to check if the host DC id is empty and if so to take
this value from the cluster.
Change-Id: I195b333d8d8fafd0b21831961862d6dc2ca42ee9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148301
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
(cherry picked from commit 8ad706349de1991d96cbfb1ac0157f30c2d16c5d)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33662
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I195b333d8d8fafd0b21831961862d6dc2ca42ee9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
10 years, 2 months
Change in ovirt-engine[master]: core: fix attaching a cluster to a new DC
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix attaching a cluster to a new DC
......................................................................
core: fix attaching a cluster to a new DC
This patch fixes attaching a cluster to a new DC after its original DC
was removed.
In that case if the cluster has a host it will loss its dc id settings
and will try to insert to the vds_spm_map table empty GUID as the DC id.
Code was changed to check if the host DC id is empty and if so to take
this value from the cluster.
Change-Id: I195b333d8d8fafd0b21831961862d6dc2ca42ee9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148301
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Allon Mureinik: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/33637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I195b333d8d8fafd0b21831961862d6dc2ca42ee9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: build: post ovirt-engine-3.5.0 branching
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: build: post ovirt-engine-3.5.0 branching
......................................................................
build: post ovirt-engine-3.5.0 branching
Change-Id: I28ccf594b21c2db1e7d85b8f260ca253ca68bfba
Bug-Url: https://bugzilla.redhat.com/1073943
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M backend/manager/dependencies/pom.xml
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/extensions-api-root/extensions-api/pom.xml
M backend/manager/modules/extensions-api-root/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/jboss-modules-maven-plugin/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M mavenmake/pom.xml
M ovirt-engine.spec.in
M pom.xml
M version.mak
52 files changed, 56 insertions(+), 53 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28ccf594b21c2db1e7d85b8f260ca253ca68bfba
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5.0]: notifier: add support for snmpv6 in SNMP_MANAGERS.
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: notifier: add support for snmpv6 in SNMP_MANAGERS.
......................................................................
notifier: add support for snmpv6 in SNMP_MANAGERS.
Change-Id: I9a21038928b7e553feefb9ab7669eac588c1c93c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073498
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
(cherry picked from commit 89ecae235bd8f73b8e44044b1fe6ae32562035da)
(cherry picked from commit b62f489ca1a827344b73286b0ba69720bc06c10f)
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
A backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/transport/snmp/ProfileTest.java
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
3 files changed, 60 insertions(+), 4 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33660
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a21038928b7e553feefb9ab7669eac588c1c93c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.0
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
10 years, 2 months
Change in ovirt-engine[master]: core: AddVmTemplateCommand storage allocation
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: AddVmTemplateCommand storage allocation
......................................................................
core: AddVmTemplateCommand storage allocation
This patch is a part of a series of patches, adding storage allocation
validations to the system when they're missing, and replacing old
verification usage with unified, new, correct and tested verification.
This patch did this for AddVmTemplateCommand, using only existing
validations. Removing old verification in this command resulted in
unused old validation and validation aids, which were also removed in
this patch.
Change-Id: I7980510a7bb72e43e0a9dfc18460207386eb62fe
Bug-Url: https://bugzilla.redhat.com/1053744
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java
3 files changed, 117 insertions(+), 52 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/15378
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7980510a7bb72e43e0a9dfc18460207386eb62fe
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: vdsbroker: no spm failover on attach iso domain failure
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: vdsbroker: no spm failover on attach iso domain failure
......................................................................
vdsbroker: no spm failover on attach iso domain failure
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1140430
Change-Id: I93500e5493b7e963c3b218520e5f6e7b96e3fe5f
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Federico Simoncelli: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93500e5493b7e963c3b218520e5f6e7b96e3fe5f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months