October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Add checkbox for format when remove Storage domain
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add checkbox for format when remove Storage domain ...................................................................... webadmin: Add checkbox for format when remove Storage domain Add format checkbox when remove a data Storage Doman. The checkbox should be checked for Data Storage Domain since most of the use cases should be formatting it. Change-Id: Ia844883ebca19be9c4f6a26f7c34b3423bf0f2d3 Bug-Url: https://bugzilla.redhat.com/1138132 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RemoveStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 2 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia844883ebca19be9c4f6a26f7c34b3423bf0f2d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Support format option for data domain
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Support format option for data domain ...................................................................... core: Support format option for data domain Adding the option to remove Data Storage Domain from the engine without formatting it so we can use it to move entities from one setup to another. Change-Id: I4392de431f6523e3824bbddd9d79aa4b1eb0819c Bug-Url: https://bugzilla.redhat.com/1138132 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 2 insertions(+), 29 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33606 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4392de431f6523e3824bbddd9d79aa4b1eb0819c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Order VMs/Templates in alphabetical order on expor...
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Order VMs/Templates in alphabetical order on export domain ...................................................................... webadmin: Order VMs/Templates in alphabetical order on export domain Order the entities in the Export Storage Domain in an alphabetical order Change-Id: I81ba2555cc59823a22886c7fcc6a6fffdc3c8de0 Bug-Url: https://bugzilla.redhat.com/1088294 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81ba2555cc59823a22886c7fcc6a6fffdc3c8de0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: allow to maintenance host if install failed
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: allow to maintenance host if install failed ...................................................................... core: allow to maintenance host if install failed Allow to put host in maintenance if install failed This patch allows to put a host in maintenance in case that host installation failed. In networking problems it may occur that after trying to put the host in maintenance it will go to preparing for maintenance=>Non Responding and we will have to put it in maintenance again. Change-Id: Ic3611e4fb7ac039ee4014f6cb158b0da5067331e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1147988 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3611e4fb7ac039ee4014f6cb158b0da5067331e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: RemoveDiskSnapshots - verify image existence
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: RemoveDiskSnapshots - verify image existence ...................................................................... core: RemoveDiskSnapshots - verify image existence RemoveDiskSnapshotsCommand -> getImages(): Ensure image existence in DB before adding into images list (to avoid adding null to the list). Change-Id: I06fd2062b8c359d2abd7e64e559d1d82197e0d76 Bug-Url: https://bugzilla.redhat.com/1134866 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06fd2062b8c359d2abd7e64e559d1d82197e0d76 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: LiveSnapshotTaskHandler - remove setExecutionContext(n...
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: LiveSnapshotTaskHandler - remove setExecutionContext(null) ...................................................................... core: LiveSnapshotTaskHandler - remove setExecutionContext(null) LiveSnapshotTaskHandler -> endSuccessfully / endWithFailure: remove 'enclosingCommand.setExecutionContext(null)' to avoid an NPE on CommandBase -> buildCommandEntity. Change-Id: I45ee451b62ff1f41f8ad03f707c105c1db70a768 Bug-Url: https://bugzilla.redhat.com/1147971 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45ee451b62ff1f41f8ad03f707c105c1db70a768 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: vds_info: fixed gateway config handling
by sbonazzo＠redhat.com 01 Oct '14

01 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: vds_info: fixed gateway config handling ...................................................................... vds_info: fixed gateway config handling Previously the gateway configuration was dropped due to a mistake in parsing the vds capabilities. This patch fixes that parsing. Change-Id: I57cabd5e317bd53cc597cf17fb8e2f9c4139712c Bug-Url: https://bugzilla.redhat.com/1147254 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 79c2103d82f9d79c2f85bc2cd2835c4ef8b018c9) --- M src/ovirt_hosted_engine_setup/vds_info.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57cabd5e317bd53cc597cf17fb8e2f9c4139712c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: vds_info: fixed gateway config handling
by sbonazzo＠redhat.com 01 Oct '14

01 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: vds_info: fixed gateway config handling ...................................................................... vds_info: fixed gateway config handling Previously the gateway configuration was dropped due to a mistake in parsing the vds capabilities. This patch fixes that parsing. Change-Id: I57cabd5e317bd53cc597cf17fb8e2f9c4139712c Bug-Url: https://bugzilla.redhat.com/1147254 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vds_info.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57cabd5e317bd53cc597cf17fb8e2f9c4139712c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Check gluster uuid when updating brick status
by kmayilsa＠redhat.com 01 Oct '14

01 Oct '14

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Check gluster uuid when updating brick status ...................................................................... gluster: Check gluster uuid when updating brick status If vdsm output for glusterVolumeStatus returns the gluster host uuid - use this to get the corresponding brick in the database. This will solve the issue with brick qualified name using a different hostname than the one engine is aware of. Change-Id: Iffea910092f693b83e51f92ea13f1014b8a40faf Bug-Url: https://bugzilla.redhat.com/1103973 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java 1 file changed, 32 insertions(+), 3 deletions(-) Approvals: Sahina Bose: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffea910092f693b83e51f92ea13f1014b8a40faf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: validate osinfo properties files - fail backend on error
by rgolan＠redhat.com 01 Oct '14

01 Oct '14

Roy Golan has submitted this change and it was merged. Change subject: core: validate osinfo properties files - fail backend on error ...................................................................... core: validate osinfo properties files - fail backend on error validate the osinfo properties files by the order of loading. on-error, a RuntimeException is thrown, which should fail the backend from loading. The parsing itself is implemented using ANTLR parser and lexer generator and the Osinfo.g4 grammar file. Osinfo.g4 grammar file that expresses the syntax of the properties file and except for unique validation needs should be the only place to be changed when needed. OsinfoPreferencesParser.java the tool to parse a property file with and match is against the syntax OsinfoPreferencesParser.parse("path/to/file") Change-Id: Ie33bf9446857e15d13221271120a3ff2b400350c Bug-Url: https://bugzilla.redhat.com/1056965 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/org/antlr/antlr4-runtime/main/module.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/pom.xml A backend/manager/modules/utils/src/main/antlr4/org/ovirt/engine/core/utils/osinfo/Osinfo.g4 M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoader.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsinfoPropertiesParser.java M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml M backend/manager/modules/utils/src/test/resources/osinfo.conf.d/00-osinfo-test.properties M pom.xml 11 files changed, 322 insertions(+), 5 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie33bf9446857e15d13221271120a3ff2b400350c Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0