Change in ovirt-engine[master]: engine : snapshot creation task is not polled by engine
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : snapshot creation task is not polled by engine
......................................................................
engine : snapshot creation task is not polled by engine
When the connectivity to storage domain is shutdown during
live storage migration flow, the async tasks take a long
time to clear after the connectivity wth storage domain
has been restorted. This results in the VM disks being
locked for a long time.
Change-Id: I78cb581b9c6ef350070e5ad53396daa069b0b4ea
Bug-Url: https://bugzilla.redhat.com/1078095
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Verified
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34602
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78cb581b9c6ef350070e5ad53396daa069b0b4ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: services: ovirt-engine: allow all levels within engine.log a...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: services: ovirt-engine: allow all levels within engine.log appenders
......................................................................
services: ovirt-engine: allow all levels within engine.log appenders
this reduces the changes required by user when enabling debug for
specific loggers, reduce confusion and chance for error.
we should have been able to use dynamic log in 3.5 but did not provide
that, so until then make the log enable sequence simpler.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1158757
Change-Id: I4788133905582c80c7ee6275245a07b913759f07
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.xml.in
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Roy Golan: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4788133905582c80c7ee6275245a07b913759f07
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: osinfo: Fix NIC hotplugging in older cluster versions
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: osinfo: Fix NIC hotplugging in older cluster versions
......................................................................
osinfo: Fix NIC hotplugging in older cluster versions
This patch enables NIC hotplugging in the 3.3 and 3.4 cluster versions.
Change-Id: I50e13e88a00aaf64a766f6b3d01084d66d7cba40
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1154630
Signed-off-by: Vitor de Lima <vdelima(a)redhat.com>
---
M packaging/conf/osinfo-defaults.properties
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Vitor de Lima: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34576
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50e13e88a00aaf64a766f6b3d01084d66d7cba40
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine[master]: core: engine-config didn't show HotUnplugCpuSupported value
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: engine-config didn't show HotUnplugCpuSupported value
......................................................................
core: engine-config didn't show HotUnplugCpuSupported value
add HotUnplugCpuSupported to vdc_options so engine-config utility could
see the default value as well
Change-Id: Ief7fe91d9947e778588ae2b73684ead68df8dc6b
Bug-Url: https://bugzilla.redhat.com/1100430
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief7fe91d9947e778588ae2b73684ead68df8dc6b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix mapping of US Eastern Standard Time Zone
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix mapping of US Eastern Standard Time Zone
......................................................................
core: Fix mapping of US Eastern Standard Time Zone
The WindowsJavaTimezoneMapping mapped US East. ST to java time zone
GMT+5 which was not adjusted to Daylight Savings Time.
Now we map it to America/New_York which takes DST into account.
Also fixed another occurence of mapping to raw GMT timezone:
SA Eastern Standard Time to America/Buenos_Aires (was GMT+3) but this
change was not as consequential since Argentina does not have DST.
Although this should be more resilient if they decided to use it in the
future.
Similar story for Georia -> Asia/Tbilisi.
Change-Id: I0d17376caac96d1aae87cc894452d42e161637e4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148623
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/WindowsJavaTimezoneMapping.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34604
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d17376caac96d1aae87cc894452d42e161637e4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: osinfo: Fix NIC hotplugging in older cluster versions
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: osinfo: Fix NIC hotplugging in older cluster versions
......................................................................
osinfo: Fix NIC hotplugging in older cluster versions
This patch enables NIC hotplugging in the 3.3 and 3.4 cluster versions.
Change-Id: I50e13e88a00aaf64a766f6b3d01084d66d7cba40
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1154630
Signed-off-by: Vitor de Lima <vdelima(a)redhat.com>
---
M packaging/conf/osinfo-defaults.properties
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Vitor de Lima: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50e13e88a00aaf64a766f6b3d01084d66d7cba40
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core, engine, restapi: Proper default migration policies for...
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core, engine, restapi: Proper default migration policies for ppc64
......................................................................
core, engine, restapi: Proper default migration policies for ppc64
This patch changes the default option when creating clusters and VMs
using the REST API. When omitted, the Migrate On Error parameter for
new clusters is disabled when the architecture of the cluster does not
support migration. Also, if the user does not specify a migration
policy for a new VM, the REST API will disable it in architectures that
do not support it.
Change-Id: Ib34c4a01fe0c667bafc47bf70b33bb2990ffb7d3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057178
Signed-off-by: Vitor de Lima <vdelima(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
7 files changed, 50 insertions(+), 1 deletion(-)
Approvals:
Vitor de Lima: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21643
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib34c4a01fe0c667bafc47bf70b33bb2990ffb7d3
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in samples-uiplugins[master]: gluster-nagios-monitoring: Added date validation error messa...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: gluster-nagios-monitoring: Added date validation error message on trends tab
......................................................................
gluster-nagios-monitoring: Added date validation error message on trends tab
Displays a error popup when the user selects To date
greater than From Date to show trends.
Change-Id: Id84d02203cd94a780303c5e802dba82e3db500ce
Bug-Url: https://bugzilla.redhat.com/1112183
Signed-off-by: Karnan TC <kchidamb(a)redhat.com>
---
M gluster-nagios-monitoring/src/js/trends.js
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Karnan t c: Verified
anmolbabu: Looks good to me, but someone else must approve
Vojtech Szocs: Verified; Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31004
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id84d02203cd94a780303c5e802dba82e3db500ce
Gerrit-PatchSet: 3
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Template's empty string as a disk alias UI fix.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Template's empty string as a disk alias UI fix.
......................................................................
webadmin: Template's empty string as a disk alias UI fix.
While making a new template based on a VM, providing the template's
allocated disks's alias as an empty string is now disabled ALSO BY UI.
the user should not be able to create a template with disks that have
an empty aliases- this bug has already been fixed at the BACKEND, this
current patch prevents the user from giving an empty alias at UI level.
Change-Id: I246063773e423f1e34ace3acd3f3884b282597e7
Bug-Url: https://bugzilla.redhat.com/1110304
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit http://gerrit.ovirt.org/34606
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I246063773e423f1e34ace3acd3f3884b282597e7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Template's empty string as a disk alias fix.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Template's empty string as a disk alias fix.
......................................................................
core: Template's empty string as a disk alias fix.
While making a new template based on a VM, providing the template's
allocated disks' alias as an empty string is now disabled. The user
should not be able to create a template with disks that have an
empty alias.
Change-Id: If20fcbe3ae6507ba1f39c6e336928fb647efeb1e
Bug-Url: https://bugzilla.redhat.com/1110304
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 21 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit http://gerrit.ovirt.org/34597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If20fcbe3ae6507ba1f39c6e336928fb647efeb1e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months