October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove usage of ExceptionUtils.getMessage
by yzaslavs＠redhat.com 31 Oct '14

31 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Remove usage of ExceptionUtils.getMessage ...................................................................... core: Remove usage of ExceptionUtils.getMessage Removes usage of ExceptionUtils.getMessage, because using Exception.getMessage along with logging stacktrace is enough. Change-Id: I113d01c167397456c0cc7b12a112971e482cf56d Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/LoggedUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 7 files changed, 11 insertions(+), 19 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I113d01c167397456c0cc7b12a112971e482cf56d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: Get path for answer file from environment
by sbonazzo＠redhat.com 31 Oct '14

31 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Get path for answer file from environment ...................................................................... Get path for answer file from environment Change-Id: I647a52e4af0079b7047625ba01a35079c356474a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1159028 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> (cherry picked from commit f505ea46cfb13db98ad165cd86d00d38dd4d25b5) --- M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I647a52e4af0079b7047625ba01a35079c356474a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: Get path for answer file from environment
by sbonazzo＠redhat.com 31 Oct '14

31 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Get path for answer file from environment ...................................................................... Get path for answer file from environment Change-Id: I647a52e4af0079b7047625ba01a35079c356474a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1159028 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Artyom Lukianov: Verified -- To view, visit http://gerrit.ovirt.org/34679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I647a52e4af0079b7047625ba01a35079c356474a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: UI plugin event handler
by awels＠redhat.com 30 Oct '14

30 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: UI plugin event handler ...................................................................... webadmin: UI plugin event handler - Changed the way UI plugin events are handled so they don't instantiate all the presenters at once. Change-Id: I83ad213a1dca8d31cf63c6b2c5f761f3242b43bc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1155992 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148095 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUtilsModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractTabPresenter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/PluginActionButtonHandler.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/MainContentPresenter.java 5 files changed, 131 insertions(+), 35 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83ad213a1dca8d31cf63c6b2c5f761f3242b43bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed search bar alignment with buttons
by awels＠redhat.com 30 Oct '14

30 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed search bar alignment with buttons ...................................................................... webadmin: fixed search bar alignment with buttons The search bar was off alignment from the buttons next to it by 1px. Fixed. Change-Id: I216d37da08ad69f28c5692b97a5f8ef6faff0e0c Bug-Url: https://bugzilla.redhat.com/1158503 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/SearchPanelView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 3 insertions(+), 33 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/34594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I216d37da08ad69f28c5692b97a5f8ef6faff0e0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: messages locale unit test
by awels＠redhat.com 30 Oct '14

30 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: messages locale unit test ...................................................................... userportal,webadmin: messages locale unit test - Added unit tests for all the locale messages which check the following: - The number of parameters on the interface match the parameters on each locales translation. This takes @Optional into account, so if there are 3 parameters and one optional, then 2 or 3 parameters are acceptable. - There are no out of bounds indexes in the translation, for instance if there are 2 parameters, there is no {2} or higher in the translated messages (the index starts at 0). - Checks if there is a default translation for missing translations - If any of these conditions occur the unit test will fail and report all errors to the user. Change-Id: Icda389f2ca08e9d3b7515bb4a0dc1213bc91aeef Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/pom.xml A frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/CommonApplicationMessagesTest.java A frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/GwtMessagesValidator.java M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml A frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/ApplicationMessagesTest.java M frontend/webadmin/modules/webadmin/pom.xml A frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/ApplicationMessagesTest.java M pom.xml 9 files changed, 294 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icda389f2ca08e9d3b7515bb4a0dc1213bc91aeef Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in samples-uiplugins[master]: gluster-nagios-monitoring : Added a link to nagios home page
by vszocs＠redhat.com 30 Oct '14

30 Oct '14

Vojtech Szocs has submitted this change and it was merged. Change subject: gluster-nagios-monitoring : Added a link to nagios home page ...................................................................... gluster-nagios-monitoring : Added a link to nagios home page Added a link to nagios home page. Change-Id: I4842868b77c6f328deab92fdf6641877e1061256 Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1138143 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M gluster-nagios-monitoring/src/css/dashboard.css M gluster-nagios-monitoring/src/js/trends.js M gluster-nagios-monitoring/src/trendsTab.html 3 files changed, 28 insertions(+), 3 deletions(-) Approvals: anmolbabu: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4842868b77c6f328deab92fdf6641877e1061256 Gerrit-PatchSet: 8 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Code needs to run once, remove from loop
by lvernia＠redhat.com 30 Oct '14

30 Oct '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Code needs to run once, remove from loop ...................................................................... engine: Code needs to run once, remove from loop There was some code inside SetupNetworksVDSCommand that didn't require being inside the iteration of networks, extracted it out of the loop. Change-Id: I8778a6e08dc696353af95bd2be67fdb31f7f2882 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 4 files changed, 41 insertions(+), 19 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8778a6e08dc696353af95bd2be67fdb31f7f2882 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.5]: packaging: moving to 3.5.1-snapshot
by sbonazzo＠redhat.com 30 Oct '14

30 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: moving to 3.5.1-snapshot ...................................................................... packaging: moving to 3.5.1-snapshot Change-Id: Ifb8de0e8023f929f693aa8a77f61915b2551a848 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb8de0e8023f929f693aa8a77f61915b2551a848 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: setup: updated answer file
by sbonazzo＠redhat.com 30 Oct '14

30 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: updated answer file ...................................................................... setup: updated answer file updated answer file for avoiding prompt: [ INFO ] Stage: Setup validation Generated iptables rules are different from current ones. Do you want to review them? (Yes, No) [No]: Change-Id: Ie458dfeb79ab1f00d4435191de4e41931dde7e82 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie458dfeb79ab1f00d4435191de4e41931dde7e82 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0