Change in ovirt-engine[master]: core: do not decrease pending resources twice on run vm
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: do not decrease pending resources twice on run vm
......................................................................
core: do not decrease pending resources twice on run vm
We used to decrease the pending resources twice when running VM - when
the VM is switched to powering-up (onPoweringUp) and when it is switched
to up (runningSucceeded). The problem is that we don't update the cached
field, lastDecreasedVds, so on runningSucceeded we don't know that the
pending resources were already been decreased.
This patch changes the pending decrement in onPoweringUp method such
that the VDS we are decrementing the pending resources from will be
cached.
Change-Id: Ie73f98504ae61ec20a722501fdd49930892dd80a
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
4 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/35669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie73f98504ae61ec20a722501fdd49930892dd80a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: decrement pending vm on 'run in paused mode'
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: decrement pending vm on 'run in paused mode'
......................................................................
core: decrement pending vm on 'run in paused mode'
In a flow where VM is started in paused state neither of
runningSucceeded nor runningFailed methods in RunVmCommand are called.
The command is kept in the collection of async commands until the VM
will be resumed.
On resume, the reportCompleted method of the original RunVmCommand will
be called and it will be removed from the async command collection.
Thus, the pending resources are not cleared in this flow.
The solution is to decrease the pending resources in the reportCompleted
method if they were not decreased before.
Change-Id: Icc931118a848c1c7507c407d955537761dd1a742
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/35636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc931118a848c1c7507c407d955537761dd1a742
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: Restore storage_pool_id to storage_domain_for_search
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Restore storage_pool_id to storage_domain_for_search
......................................................................
core: Restore storage_pool_id to storage_domain_for_search
In commit a7caea90, data center uuid for storage search was removed.
This fix returns it when the SD is attach to a single DC.
Change-Id: I24cbfe91073f888d58d44b853aca94d0024ef917
Bug-Url: https://bugzilla.redhat.com/1166182
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24cbfe91073f888d58d44b853aca94d0024ef917
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[master]: core: Restore storage_pool_id to storage_domain_for_search
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Restore storage_pool_id to storage_domain_for_search
......................................................................
core: Restore storage_pool_id to storage_domain_for_search
In commit a7caea90, data center uuid for storage search was removed.
This fix returns it when the SD is attach to a single DC.
Change-Id: I24cbfe91073f888d58d44b853aca94d0024ef917
Bug-Url: https://bugzilla.redhat.com/1166182
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, but someone else must approve
Gilad Chaplik: Verified; Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/35627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24cbfe91073f888d58d44b853aca94d0024ef917
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: webadmin: fix storage QoS UI validation
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: fix storage QoS UI validation
......................................................................
webadmin: fix storage QoS UI validation
The storage values weren't validated.
Also added a check to allow setting total or read/write.
Change-Id: Ia4f69ce1b7751e066c6a1e15f482805bbc7df16a
Bug-Url: https://bugzilla.redhat.com/1168558
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/StorageQosMetricParametersModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 19 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35676
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4f69ce1b7751e066c6a1e15f482805bbc7df16a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: prevent maintenance a host with hard affinity
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: prevent maintenance a host with hard affinity
......................................................................
core: prevent maintenance a host with hard affinity
Maintenance a host can break the affinity rule of its running vm
The user should be aware of it, and manually handle it:
soften the affinity rule or migrate the VMs.
Change-Id: Idd93ddca562bf739b2cd423e907be1b6da861735
Bug-Url: https://bugzilla.redhat.com/1084794
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/AffinityGroupDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/AffinityGroupDaoImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AffinityGroupDaoTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/affinity_groups_sp.sql
10 files changed, 101 insertions(+), 11 deletions(-)
Approvals:
Gilad Chaplik: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34501
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd93ddca562bf739b2cd423e907be1b6da861735
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: add missing disk profile translation
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: add missing disk profile translation
......................................................................
core: add missing disk profile translation
Change-Id: I6cc18994af7b37a1e736f0190b31ff63dfcf4d26
Bug-Url: https://bugzilla.redhat.com/1161939
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
3 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified
Roy Golan: Looks good to me, but someone else must approve
Liron Aravot: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cc18994af7b37a1e736f0190b31ff63dfcf4d26
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[master]: core: set Disk Profile for cloned VM from snapshot
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: set Disk Profile for cloned VM from snapshot
......................................................................
core: set Disk Profile for cloned VM from snapshot
Disk Profile was missing in disk image mapping to
storage_doamin_image_map.
Change-Id: Iab5f79e853a1482ccabf6c287d663da87ab332fe
Bug-Url: https://bugzilla.redhat.com/1161939
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Verified
Roy Golan: Looks good to me, approved
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/35205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab5f79e853a1482ccabf6c287d663da87ab332fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: check if the HE guest can be migrated before maintenace
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: check if the HE guest can be migrated before maintenace
......................................................................
core: check if the HE guest can be migrated before maintenace
When putting VDS to maintenance mode the HE guest is migrated by the
ha-agent so it's not checked by the engine at all. In case there is no
VDS to migrate the HE guest to the migration will never happen and
the host stays in "preparing for maintenance" until the admin activates
it manually. This patch adds the logic to check if there is a VDS
which can be used for HE guest. It's a bit racy, but it will prevent
at least the case described in the referenced bugzilla.
Change-Id: I0b9cbcd03f01ca34c6c31308b7321214e15cafc7
Bug-Url: https://bugzilla.redhat.com/1157378
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
1 file changed, 21 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jiří Moskovčák: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b9cbcd03f01ca34c6c31308b7321214e15cafc7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: configurable ssl protocol
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: configurable ssl protocol
......................................................................
core: configurable ssl protocol
We need to make ssl protocol configurable.
I tested 3.5 engine and vdsm with all combinations (sslv3, tlsv1) and
there were no issues.
I tested 3.0 engine with 3.5 vdsm and noticed that when tlsv1 was set on
vdsm side the communication failed with wrong protocol version.
I tested 3.0 vdsm with latest engine (tlsv1) and it worked after hacking
host-deploy.
Change-Id: I33a33c15e8a995eb8de7d5131b3dbadc6191f873
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1154184
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationService.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EngineManagerProvider.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIntegrationTest.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
11 files changed, 52 insertions(+), 21 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34917
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33a33c15e8a995eb8de7d5131b3dbadc6191f873
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years