Change in ovirt-engine[ovirt-engine-3.5]: db: add logical_name to vm_device
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: db: add logical_name to vm_device
......................................................................
db: add logical_name to vm_device
This patch adds the logical_name column to the vm_device table,
the intention is to store in it the device logical name as retrieved
from the guest.
Change-Id: If9b5a8e771a05c1fe44834adfe998cf921f6ae52
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063597
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_05_1120_add_logical_name_to_vm_device.sql
M packaging/dbscripts/vm_device_sp.sql
18 files changed, 75 insertions(+), 22 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/34480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9b5a8e771a05c1fe44834adfe998cf921f6ae52
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: core: handle host architecture in fence flow
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: handle host architecture in fence flow
......................................................................
core: handle host architecture in fence flow
This patch adds a getArchitecture method to VDS.
It is used in order to get the host architecture using its cpu flags, in
case that this is null, the architecture of the containing cluster is
used.
Please note that a separate call to get VdsDynamic information for the
host since the VDS object passed to the fencing code is slim and does
not contain any dymanic information.
Change-Id: I081361c9f956ea71a715acf0368c79c7130674c7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149235
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsArchitectureHelper.java
3 files changed, 36 insertions(+), 5 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Omer Frenkel: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I081361c9f956ea71a715acf0368c79c7130674c7
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: UI plugin event handler
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: UI plugin event handler
......................................................................
webadmin: UI plugin event handler
- Changed the way UI plugin events are handled so they don't
instantiate all the presenters at once.
Change-Id: I83ad213a1dca8d31cf63c6b2c5f761f3242b43bc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1155992
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148095
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUtilsModule.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractTabPresenter.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/PluginActionButtonHandler.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/MainContentPresenter.java
5 files changed, 131 insertions(+), 35 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34682
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83ad213a1dca8d31cf63c6b2c5f761f3242b43bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: free pending resources properly on migration failure
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: free pending resources properly on migration failure
......................................................................
core: free pending resources properly on migration failure
There is a race when VM switch from MIGRATING_FROM to UP due to
migration failure between:
1. Rerun operation which is executed from the monitoring (VURTI) on a
separate thread
2. Powering up handling which is executed from the monitoring thread
When #2 happens before #1, the powering up handling decrease the pending
resources from the destination host properly.
But when #1 happens before, then we've got a problem because it sets the
destination host to null so neither #1 or #2 decreases the pending
resources on the destination host.
This patch solves the pending resources decrement in the rerun flow.
Change-Id: Ib866d7da8a3e1fa7fe2023adc49f3b4f559c8982
Bug-Url: https://bugzilla.redhat.com/1157211
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
2 files changed, 21 insertions(+), 12 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/34674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib866d7da8a3e1fa7fe2023adc49f3b4f559c8982
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: engine : snapshot creation task is not polled by engine
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine : snapshot creation task is not polled by engine
......................................................................
engine : snapshot creation task is not polled by engine
When the connectivity to storage domain is shutdown during
live storage migration flow, the async tasks take a long
time to clear after the connectivity wth storage domain
has been restorted. This results in the VM disks being
locked for a long time.
Change-Id: I78cb581b9c6ef350070e5ad53396daa069b0b4ea
Bug-Url: https://bugzilla.redhat.com/1078095
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34661
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78cb581b9c6ef350070e5ad53396daa069b0b4ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-host-deploy[ovirt-host-deploy-1.2]: packaging: post ovirt-host-deploy-1.2.4
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post ovirt-host-deploy-1.2.4
......................................................................
packaging: post ovirt-host-deploy-1.2.4
Change-Id: I24775f7c124c5918eed3ebb5ea709a75c7530af5
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M configure.ac
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24775f7c124c5918eed3ebb5ea709a75c7530af5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.2
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-host-deploy[ovirt-host-deploy-1.2]: packaging: ovirt-host-deploy-1.2.4
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: ovirt-host-deploy-1.2.4
......................................................................
packaging: ovirt-host-deploy-1.2.4
Change-Id: Ifd941ef06098e2c7b58d4b84133d20bd9968c92f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M configure.ac
M ovirt-host-deploy-offline.spec.in
M ovirt-host-deploy.spec.in
4 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34723
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd941ef06098e2c7b58d4b84133d20bd9968c92f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.2
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-host-deploy[ovirt-host-deploy-1.2]: gluster: Plugin under gluster for glusterpmd configuration.
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: gluster: Plugin under gluster for glusterpmd configuration.
......................................................................
gluster: Plugin under gluster for glusterpmd configuration.
Addition of new plugin glusterpmd(gluster process monitoring
daemon) under gluster. This plugin starts the glusterpmd during
host deploy if monitoring is enabled.
Change-Id: I9d8f3026740be567684e13f08324a7c36be40b26
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138198
Signed-off-by: ndarshan <dnarayan(a)redhat.com>
---
M ChangeLog
M src/plugins/ovirt-host-deploy/gluster/Makefile.am
M src/plugins/ovirt-host-deploy/gluster/__init__.py
A src/plugins/ovirt-host-deploy/gluster/glusterpmd.py
4 files changed, 64 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d8f3026740be567684e13f08324a7c36be40b26
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.2
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month