November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: UI: migration down time shouldn't be enabled by default.
by shavivi＠redhat.com 13 Nov '14

13 Nov '14

Shahar Havivi has submitted this change and it was merged. Change subject: UI: migration down time shouldn't be enabled by default. ...................................................................... UI: migration down time shouldn't be enabled by default. Change-Id: I45f62e8b390335b95d10be0ca9ef899afda8b696 Bug-Url: https://bugzilla.redhat.com/1124318 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/35071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45f62e8b390335b95d10be0ca9ef899afda8b696 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix ISO file support to be case insensitive
by ahadas＠redhat.com 13 Nov '14

13 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: Fix ISO file support to be case insensitive ...................................................................... core: Fix ISO file support to be case insensitive This patch fixes a bug where an ISO file with an upper-case file extension was not accepted as a valid ISO. Change-Id: Iec8df04bacb81db6c872c7920610abdbe1471da4 Bug-Url: https://bugzilla.redhat.com/1154391 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Eldan Shachar: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec8df04bacb81db6c872c7920610abdbe1471da4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove redundant Vds call at Add existingFileStorageDo...
by mlipchuk＠redhat.com 13 Nov '14

13 Nov '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove redundant Vds call at Add existingFileStorageDomain ...................................................................... core: Remove redundant Vds call at Add existingFileStorageDomain Remove redundant getStorageDomainsList VDS call. The call was used to know if the Storage Exists in the VDSM, but we can also know that from the next VDS command of getStorageDomainInfo. Changing the test accordingly Change-Id: I2294f83eb204cab44b6a52e7c7a763bf107aaa37 Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java 2 files changed, 18 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/34540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2294f83eb204cab44b6a52e7c7a763bf107aaa37 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Determine file storage type by user.
by mlipchuk＠redhat.com 13 Nov '14

13 Nov '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Determine file storage type by user. ...................................................................... core: Determine file storage type by user. Importing a Storage Domain should be determined by the user instead it will be determined from the meta data. Alao removing unrequired related CDA message, and a test which is not relevant anymore. Change-Id: I1251c51b06bcd5f17633a4ad3de2496d5cb77683 Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 0 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/34493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1251c51b06bcd5f17633a4ad3de2496d5cb77683 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Determine block storage type by user.
by mlipchuk＠redhat.com 13 Nov '14

13 Nov '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Determine block storage type by user. ...................................................................... core: Determine block storage type by user. Importing a Storage Domain should be determined by the user instead it will be determined from the meta data. Change-Id: I6d5076d78eea0960da41a058b4de17bbb01b05f1 Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/34492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d5076d78eea0960da41a058b4de17bbb01b05f1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Set storage type as set in the paramteres.
by mlipchuk＠redhat.com 13 Nov '14

13 Nov '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Set storage type as set in the paramteres. ...................................................................... core: Set storage type as set in the paramteres. 1) Set the storage type of the storage after it was fetched from VDSM in GetExistingStorageDomainListQuery 2) use getStorageDomainsList to be fetched without Storage Domains type. Change-Id: I9a6f2f22b09de9daffde5e003528324237d6835f Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetExistingStorageDomainListQuery.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a6f2f22b09de9daffde5e003528324237d6835f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use GetExistingStorageDomainList to fetch all type of ...
by mlipchuk＠redhat.com 13 Nov '14

13 Nov '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use GetExistingStorageDomainList to fetch all type of Storages ...................................................................... core: Use GetExistingStorageDomainList to fetch all type of Storages Use GetExistingStorageDomainList to fetch different tpye of storage type, so user can manipulate the Storage Domain type while importing it. Change-Id: If3a082e0bddaad745788b9b166f2b17eff0fbd17 Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainsListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 5 files changed, 10 insertions(+), 7 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3a082e0bddaad745788b9b166f2b17eff0fbd17 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix icons on role popup
by awels＠redhat.com 12 Nov '14

12 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fix icons on role popup ...................................................................... webadmin: fix icons on role popup At some point, the role icons in RoleView were stretched to 30px tall. They looked ridiculous. Fixed. Change-Id: Id804691ba5799ca86733e4cba063b7ceb8774aae Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 6 insertions(+), 11 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/35059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id804691ba5799ca86733e4cba063b7ceb8774aae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: validate vmNotDuringSnapshot on LiveMigrateVmDisks
by tnisan＠redhat.com 12 Nov '14

12 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: validate vmNotDuringSnapshot on LiveMigrateVmDisks ...................................................................... core: validate vmNotDuringSnapshot on LiveMigrateVmDisks LiveMigrateVmDisksCommand: valifate VM is not during snapshot on canDoAction. Change-Id: Ide91ad3042bbf0889ba948763ce88444045fc104 Bug-Url: https://bugzilla.redhat.com/1162120 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 2 files changed, 19 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/35097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide91ad3042bbf0889ba948763ce88444045fc104 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: filter shareable disks on preview snapshot
by tnisan＠redhat.com 12 Nov '14

12 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: filter shareable disks on preview snapshot ...................................................................... core: filter shareable disks on preview snapshot TryBackToAllSnapshotsOfVm -> getImagesToPreview: filter out shareable/nonsnapable disks. Change-Id: I232d3387e203933bdbb12a5e3401c096278a41d3 Bug-Url: https://bugzilla.redhat.com/1161916 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/35098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I232d3387e203933bdbb12a5e3401c096278a41d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0