November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: unset DisconnectDwh on failure
by tnisan＠redhat.com 26 Nov '14

26 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: unset DisconnectDwh on failure ...................................................................... packaging: setup: unset DisconnectDwh on failure Change-Id: I09083bc79ead4711a7a998fab112c58ef80b0b4d Bug-Url: https://bugzilla.redhat.com/1168160 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 7348799e9dcd38b5bc974debaa96be85d116c559) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09083bc79ead4711a7a998fab112c58ef80b0b4d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: tpgt should not be sent when empty
by tnisan＠redhat.com 26 Nov '14

26 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: tpgt should not be sent when empty ...................................................................... core: tpgt should not be sent when empty Ensure 'tpgt' isn't sent as an empty string as VDSM expects an integer. I.e. 'tpgt' is optional, but if specified, it must be an integer. Vdsm API: " {'type': 'IscsiConnectionParameters', 'data': {'portal': 'IscsiPortal', 'iqn': 'str', '*tpgt': 'int', '*iface': 'str', '*credentials': 'IscsiCredentials'}} @tpgt: #optional The Target Portal Group Tag to use " Change-Id: I79b6b80fafff7b87700e4e340eacff6cd0c43f30 Bug-Url: https://bugzilla.redhat.com/1160785 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/35582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79b6b80fafff7b87700e4e340eacff6cd0c43f30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: fix fn_db_add_config_value_for_versions_up_to
by emesika＠redhat.com 26 Nov '14

26 Nov '14

Eli Mesika has submitted this change and it was merged. Change subject: db: fix fn_db_add_config_value_for_versions_up_to ...................................................................... db: fix fn_db_add_config_value_for_versions_up_to The FOREACH keyword used in the function is not compatible with PG 8.x and was replaced with a FOR loop that is supported for both 8.x and 9.x Change-Id: Ice6f9425fae64ebdd4bfcc68d848ec4fdd9acc8a Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice6f9425fae64ebdd4bfcc68d848ec4fdd9acc8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: unset DisconnectDwh on failure
by sbonazzo＠redhat.com 26 Nov '14

26 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: unset DisconnectDwh on failure ...................................................................... packaging: setup: unset DisconnectDwh on failure Change-Id: I09083bc79ead4711a7a998fab112c58ef80b0b4d Bug-Url: https://bugzilla.redhat.com/1168160 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09083bc79ead4711a7a998fab112c58ef80b0b4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: Fix calculation of score for gateway and bridge problems.
by msivak＠redhat.com 26 Nov '14

26 Nov '14

Martin Sivák has submitted this change and it was merged. Change subject: Fix calculation of score for gateway and bridge problems. ...................................................................... Fix calculation of score for gateway and bridge problems. Because wrong casting lm['gateway'] and lm['bridge'] always received True value. Change-Id: Id750ef496ae1983be20b9bd61d5757fc37ba39b3 Bug-Url: https://bugzilla.redhat.com/1164557 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/agent/states.py 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id750ef496ae1983be20b9bd61d5757fc37ba39b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Fix calculation of score for gateway and bridge problems.
by msivak＠redhat.com 26 Nov '14

26 Nov '14

Martin Sivák has submitted this change and it was merged. Change subject: Fix calculation of score for gateway and bridge problems. ...................................................................... Fix calculation of score for gateway and bridge problems. Because wrong casting lm['gateway'] and lm['bridge'] always received True value. Change-Id: Id750ef496ae1983be20b9bd61d5757fc37ba39b3 Bug-Url: https://bugzilla.redhat.com/1164557 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/agent/states.py 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id750ef496ae1983be20b9bd61d5757fc37ba39b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: tpgt should not be sent when empty
by derez＠redhat.com 26 Nov '14

26 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: core: tpgt should not be sent when empty ...................................................................... core: tpgt should not be sent when empty Ensure 'tpgt' isn't sent as an empty string as VDSM expects an integer. I.e. 'tpgt' is optional, but if specified, it must be an integer. Vdsm API: " {'type': 'IscsiConnectionParameters', 'data': {'portal': 'IscsiPortal', 'iqn': 'str', '*tpgt': 'int', '*iface': 'str', '*credentials': 'IscsiCredentials'}} @tpgt: #optional The Target Portal Group Tag to use " Change-Id: I79b6b80fafff7b87700e4e340eacff6cd0c43f30 Bug-Url: https://bugzilla.redhat.com/1160785 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79b6b80fafff7b87700e4e340eacff6cd0c43f30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: update vm version for pool-vm
by tnisan＠redhat.com 26 Nov '14

26 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: update vm version for pool-vm ...................................................................... core: update vm version for pool-vm When pool-vm is started by admin, it is not attached to any user, nor doest it have a stateless snapshot. so in this case, the logic that check if new version exists is skipped. this patch calls restoreStatelessSnapshot (that contains the new version logic) also to pool vms that are not attached to any user. Change-Id: Ibce7bc6d744a0bc4ef42e7f039e880c595e44f89 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167102 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibce7bc6d744a0bc4ef42e7f039e880c595e44f89 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix Live Merge recovery with JSON-RPC hosts
by tnisan＠redhat.com 26 Nov '14

26 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix Live Merge recovery with JSON-RPC hosts ...................................................................... core: Fix Live Merge recovery with JSON-RPC hosts JSON-RPC calls to the reconcileVolumeChain verb were not done correctly, causing recovery to fail if live merge was interrupted by e.g. host shutdown during the merge operation. Change-Id: If1b23580ae6023754d2e02000dc5913262b3ef8b Bug-Url: https://bugzilla.redhat.com/1161127 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1b23580ae6023754d2e02000dc5913262b3ef8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: [fr_FR][ja_JP][Admin Portal] Misalignment in 'New ...
by oourfali＠redhat.com 26 Nov '14

26 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: [fr_FR][ja_JP][Admin Portal] Misalignment in 'New Host' dialog ...................................................................... webadmin: [fr_FR][ja_JP][Admin Portal] Misalignment in 'New Host' dialog Misalignment in New Host Dialog in jp_JP and fr_FR locales Change-Id: Id69a2a6146a1827168721071e79583d42ba9b58e Bug-Url: https://bugzilla.redhat.com/1123324 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 23 insertions(+), 4 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id69a2a6146a1827168721071e79583d42ba9b58e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0