Change in ovirt-log-collector[master]: archive: reorganizing the final tarball archive
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: archive: reorganizing the final tarball archive
......................................................................
archive: reorganizing the final tarball archive
Adding a top level directory to the tarball archive to avoid
any other element in the tarball root
Change-Id: If14717e8a9bc790e12c84c1fbaa968d786bed96f
Bug-Url: https://bugzilla.redhat.com/1168660
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/__main__.py
1 file changed, 34 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/35751
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If14717e8a9bc790e12c84c1fbaa968d786bed96f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Petr Benas <pbenas(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdosek(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[master]: rest: Validation of the protocol values
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: rest: Validation of the protocol values
......................................................................
rest: Validation of the protocol values
We did not check protocol values provided so update of the host with
wrong protocol string failed on backend whereas it should fail during
initial validation.
Change-Id: I666b5469bcaf2bd00f793ad4320c3f37505d49b0
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1170125
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HostProtocol.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/HostValidator.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
6 files changed, 81 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35865
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I666b5469bcaf2bd00f793ad4320c3f37505d49b0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: Limitaion addition to disk extending.
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Limitaion addition to disk extending.
......................................................................
engine: Limitaion addition to disk extending.
A limitation for extending a disk while it is connected to a paused vm
added to VdcActionUtils which effects both backend and frontend. a disk
cannot be resized while one of the VMs it is connected to is paused.
Change-Id: I2f2c50f2f047bb0c50a7869f4903ad7d0be5290d
Bug-Url: https://bugzilla.redhat.com/1161966
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Amit Aviram: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35868
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f2c50f2f047bb0c50a7869f4903ad7d0be5290d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[master]: core: CreateOvfStoresForStorageDomain - set StorageDomainId
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: CreateOvfStoresForStorageDomain - set StorageDomainId
......................................................................
core: CreateOvfStoresForStorageDomain - set StorageDomainId
setStorageDomainId() in case of storage domain related audit log is done
(so that the replacements to the message could be done).
Change-Id: I9b6fcfbdc1aa12421b133c5df76cd81e9c3d13f4
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfStoresForStorageDomainCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b6fcfbdc1aa12421b133c5df76cd81e9c3d13f4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: always perform ovf update after disk creation
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: always perform ovf update after disk creation
......................................................................
core: always perform ovf update after disk creation
Currently the OVF Update is performed after the disk creation only if
atleast one OVF store creation succeeds.
The reason for that is that prior to change I54cc9 the OVF update flow
first updated the existing OVF stores, then created new stores if needed
and if atleast of creation was succesful - update the OVF data.
As in change I54cc9 the order of operations was change (first the OVF
disks are created and then the OVF data is updated) performing the
update only if one disk succeeded is wrong and it should be done always.
Change-Id: Ic029f819f2d0c0a51c098667daa319b921f8750c
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfStoresForStorageDomainCommand.java
1 file changed, 5 insertions(+), 9 deletions(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic029f819f2d0c0a51c098667daa319b921f8750c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: DeactivateStorageDomainWithOvfUpdate - locks
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: DeactivateStorageDomainWithOvfUpdate - locks
......................................................................
core: DeactivateStorageDomainWithOvfUpdate - locks
The lock taken by the command should be released at the end of the
endAction() method, therfore we should avoid passing it to the child
command (so it won't be released by it). Also, avoid releasing the in
memory lock while there are still tasks.
Change-Id: Id8199e372d72f673aeb7b16d12cc8f5ffa043117
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35873
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8199e372d72f673aeb7b16d12cc8f5ffa043117
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[master]: core: Improved message when MAC Pool cannot be deleted
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: Improved message when MAC Pool cannot be deleted
......................................................................
core: Improved message when MAC Pool cannot be deleted
-standardized message, added listing of which datacenters are using it.
-removed not used db function
-added new one, listing all DCs for given MAC Pool
Change-Id: I647420d7cc43853eddd2b17091cd627b9088a34d
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MacPoolValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MacPoolDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MacPoolDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/MacPoolDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/mac_pools_sp.sql
M packaging/dbscripts/storages_sp.sql
14 files changed, 109 insertions(+), 67 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30663
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I647420d7cc43853eddd2b17091cd627b9088a34d
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: remove ConnectionWrapper
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: remove ConnectionWrapper
......................................................................
core: remove ConnectionWrapper
Change-Id: I41e385f266837c7b45b0d5d1c02402e8ee9eb155
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java
2 files changed, 58 insertions(+), 91 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41e385f266837c7b45b0d5d1c02402e8ee9eb155
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Add ImportCertificateCommand
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Add ImportCertificateCommand
......................................................................
core: Add ImportCertificateCommand
Change-Id: If4308ecb184234fee3931cf4c7cfbd1796efa9d2
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
13 files changed, 101 insertions(+), 15 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4308ecb184234fee3931cf4c7cfbd1796efa9d2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[master]: core: fix missing QoS name from audig log
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: fix missing QoS name from audig log
......................................................................
core: fix missing QoS name from audig log
Change-Id: Id37d5210e4dc963217587ff93ff88d428cb38919
Bug-Url: https://bugzilla.redhat.com/1168250
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Roy Golan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35866
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id37d5210e4dc963217587ff93ff88d428cb38919
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months