Change in ovirt-engine[master]: core: Add support for copied disk template
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add support for copied disk template
......................................................................
core: Add support for copied disk template
Add support for copied disk Template so an unregistered Template can be
registered with its copied disks
Change-Id: Id7514146d26792a361e47d1de820f5233ff9bf40
Bug-Url: https://bugzilla.redhat.com/1138136
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java
1 file changed, 79 insertions(+), 0 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35933
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7514146d26792a361e47d1de820f5233ff9bf40
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[master]: core: Increment DB Generation when image is copied
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Increment DB Generation when image is copied
......................................................................
core: Increment DB Generation when image is copied
Increment the DB genereation when a template image is being copied, so
the desctination Storage Domain will be updated with the Template OVF.
Change-Id: Icdd5e02387fe729195bd4b3c502636671a914e5d
Bug-Url: https://bugzilla.redhat.com/1138136
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35932
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdd5e02387fe729195bd4b3c502636671a914e5d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[master]: core: Fetch unregisterd entity from all the Storage Domains.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fetch unregisterd entity from all the Storage Domains.
......................................................................
core: Fetch unregisterd entity from all the Storage Domains.
Add the ability to fetch an entity from all the
Storage Domains with a stored procedure, by passing null as storage domain id.
This stored procedure should be used for fetching Tempalte with disk copied on several
Storage Domains.
Change-Id: Ia279818045ee3adfcda6383b010ac9f7e283886f
Bug-Url: https://bugzilla.redhat.com/1138136
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmTemplatesQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/unregistered_OVF_data_sp.sql
11 files changed, 76 insertions(+), 33 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35886
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia279818045ee3adfcda6383b010ac9f7e283886f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[master]: aaa: fix session timeout
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: fix session timeout
......................................................................
aaa: fix session timeout
The fix is done by the following ways:
a. Public Queries which do not require user should not perform session refresh (they should be agnostic to it)
b. The API resource should not perform refresh as well
Change-Id: I6640beef3ca28f95def87ac5e29d41f75b0fddd8
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1168842
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetSystemStatisticsQueryParameters.java
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6640beef3ca28f95def87ac5e29d41f75b0fddd8
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: load also pyc files when loading submonitors
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: load also pyc files when loading submonitors
......................................................................
load also pyc files when loading submonitors
Change-Id: I0dae460264f5cb0b5d83637344331ea56f8bfadd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151344
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
(cherry picked from commit f73bdea950e070cb8ff8e7acd773d399cd5bf3c0)
---
M ovirt_hosted_engine_ha/broker/monitor.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/35969
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0dae460264f5cb0b5d83637344331ea56f8bfadd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.2
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-hosted-engine-ha[master]: load also pyc files when loading submonitors
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: load also pyc files when loading submonitors
......................................................................
load also pyc files when loading submonitors
Change-Id: I0dae460264f5cb0b5d83637344331ea56f8bfadd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151344
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/broker/monitor.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/35900
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0dae460264f5cb0b5d83637344331ea56f8bfadd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: webadmin: Remove Storage connection on import domain failure
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: webadmin: Remove Storage connection on import domain failure
......................................................................
webadmin: Remove Storage connection on import domain failure
Remove storage server connection if we failed to import an existing Storage Domain.
Change-Id: I553a311fe8856b9cd5825405fef39e91e4c6e771
Bug-Url: https://bugzilla.redhat.com/1136930
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/35941
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I553a311fe8856b9cd5825405fef39e91e4c6e771
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: Add a warnning when OVF_STORE disks does not exists.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add a warnning when OVF_STORE disks does not exists.
......................................................................
core: Add a warnning when OVF_STORE disks does not exists.
Add a warnning on attach operation to notify the user that there are no
backup componenets if the Storage Domain was handled before in a Data
Center version lower then 3.5
Change-Id: I79de5110898852a5bf3d46227aa7eef36a74a74a
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35942
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79de5110898852a5bf3d46227aa7eef36a74a74a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: CreateOvfStoresForStorageDomain - set StorageDomainId
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: CreateOvfStoresForStorageDomain - set StorageDomainId
......................................................................
core: CreateOvfStoresForStorageDomain - set StorageDomainId
setStorageDomainId() in case of storage domain related audit log is done
(so that the replacements to the message could be done).
Change-Id: I9b6fcfbdc1aa12421b133c5df76cd81e9c3d13f4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138124
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfStoresForStorageDomainCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/35951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b6fcfbdc1aa12421b133c5df76cd81e9c3d13f4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: always perform ovf update after disk creation
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: always perform ovf update after disk creation
......................................................................
core: always perform ovf update after disk creation
Currently the OVF Update is performed after the disk creation only if
atleast one OVF store creation succeeds.
The reason for that is that prior to change I54cc9 the OVF update flow
first updated the existing OVF stores, then created new stores if needed
and if atleast of creation was succesful - update the OVF data.
As in change I54cc9 the order of operations was change (first the OVF
disks are created and then the OVF data is updated) performing the
update only if one disk succeeded is wrong and it should be done always.
Change-Id: Ic029f819f2d0c0a51c098667daa319b921f8750c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138124
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfStoresForStorageDomainCommand.java
1 file changed, 5 insertions(+), 9 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/35950
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic029f819f2d0c0a51c098667daa319b921f8750c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years