December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Extracting OvfDataUpdater logic to commands
by laravot＠redhat.com 03 Dec '14

03 Dec '14

Liron Aravot has submitted this change and it was merged. Change subject: core: Extracting OvfDataUpdater logic to commands ...................................................................... core: Extracting OvfDataUpdater logic to commands This patch moves the ovf update logic resides within the OvfDataUpdater to BLL commands, so that it can be executed easily by other flows as well. The logic was mainly moved to ProcessOvfUpdateForStoragePoolCommand, tests were added accordingly. Change-Id: I6780aedf2d215d08c4bed0ff4f7520c45f753f66 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138124 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfUpdateProcessHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStoragePoolCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 10 files changed, 1,391 insertions(+), 1,403 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6780aedf2d215d08c4bed0ff4f7520c45f753f66 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: programatically inject backend into Commands
by rgolan＠redhat.com 03 Dec '14

03 Dec '14

Roy Golan has submitted this change and it was merged. Change subject: core: programatically inject backend into Commands ...................................................................... core: programatically inject backend into Commands Commands, specially storage commands must have backend instance in the constructor. - example CloneVmCommand constructor is running internalQuery This contradicts with DI as dependincies can be injected only after you have and instance in hand. So we're still can't use proper Injection of dependencies into commands. the real fix is to move parts that need dependencies into @PostConstruct methods. Change-Id: I38d2aa7f14f13cb71a00f9080e3ec97d8884eea3 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRemoveGlusterVolumeBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommandTest.java 10 files changed, 14 insertions(+), 15 deletions(-) Approvals: Sahina Bose: Looks good to me, but someone else must approve Roy Golan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38d2aa7f14f13cb71a00f9080e3ec97d8884eea3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: Drop password and hostname from answerfile
by sbonazzo＠redhat.com 03 Dec '14

03 Dec '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Drop password and hostname from answerfile ...................................................................... packaging: setup: Drop password and hostname from answerfile Change Iffb05e4a520aa8f8f8a2d7f36e60aee556360302 added the admin password and the host name as displayed in the web application to the answer file, to allow more automation. This answer file is also used for additional hosts setup, where this information is undesired. This change reverts this part. Change-Id: Ica713fb19009875574f1c3f5f19a96b7027c952d Bug-Url: https://bugzilla.redhat.com/1101285 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 144bc38bb1f1f6a185a5622ea26d90c2e39f1efe) --- M src/ovirt_hosted_engine_setup/constants.py 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica713fb19009875574f1c3f5f19a96b7027c952d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Drop password and hostname from answerfile
by sbonazzo＠redhat.com 03 Dec '14

03 Dec '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Drop password and hostname from answerfile ...................................................................... packaging: setup: Drop password and hostname from answerfile Change Iffb05e4a520aa8f8f8a2d7f36e60aee556360302 added the admin password and the host name as displayed in the web application to the answer file, to allow more automation. This answer file is also used for additional hosts setup, where this information is undesired. This change reverts this part. Change-Id: Ica713fb19009875574f1c3f5f19a96b7027c952d Bug-Url: https://bugzilla.redhat.com/1101285 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica713fb19009875574f1c3f5f19a96b7027c952d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use CommandMocks for common mocking bits
by rgolan＠redhat.com 03 Dec '14

03 Dec '14

Roy Golan has submitted this change and it was merged. Change subject: core: use CommandMocks for common mocking bits ...................................................................... core: use CommandMocks for common mocking bits Change-Id: I9493d1103f4b9366eca9a45d5c8cc10d45cf1494 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/CommandMocks.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 7 files changed, 22 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Roy Golan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9493d1103f4b9366eca9a45d5c8cc10d45cf1494 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Deleting all snapshot disks during a vdsm restart le...
by oourfali＠redhat.com 03 Dec '14

03 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Deleting all snapshot disks during a vdsm restart leaves disks locked ...................................................................... engine: Deleting all snapshot disks during a vdsm restart leaves disks locked Restarting vdsm when deleting snapshot volumes leaves some volumes in locked status. Change-Id: I58b354541821845f506f9848782763f3c2526f9c Bug-Url: https://bugzilla.redhat.com/1157222 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58b354541821845f506f9848782763f3c2526f9c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: template import
by awels＠redhat.com 02 Dec '14

02 Dec '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: template import ...................................................................... webadmin: template import - When trying to import a template the popup would generate a class cast exception. This patch solves that exception and another subsequent one. Change-Id: Iec132ab7be596207c3bcee97753bbf08d14e737d Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java 4 files changed, 25 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec132ab7be596207c3bcee97753bbf08d14e737d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: Put model bindings into UiCommonModule
by vszocs＠redhat.com 02 Dec '14

02 Dec '14

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: Put model bindings into UiCommonModule ...................................................................... userportal: Put model bindings into UiCommonModule This patch puts UiCommon model bindings right next to corresponding model provider bindings. If we'd like to split these bindings, the split should be done per-function similar to WebAdmin, i.e. "template" module, "resource" module etc. Change-Id: Ib6ae77c8083f44ee4fba19d7f3cb3c0af043d452 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UiCommonModule.java D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UserPortalModule.java 2 files changed, 46 insertions(+), 71 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6ae77c8083f44ee4fba19d7f3cb3c0af043d452 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing build break
by laravot＠redhat.com 02 Dec '14

02 Dec '14

Liron Aravot has submitted this change and it was merged. Change subject: core: fixing build break ...................................................................... core: fixing build break VdcActionType.ImportProviderCertificate was added in change Ic9adb2 but the command wasn't added causing the VdcActionType test to fail - commenting the use and removing the enum value at the moment. Change-Id: I1e8d48344f30085fac8a6d5d4c4c2c15da987246 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendExternalProviderResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 3 files changed, 15 insertions(+), 16 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e8d48344f30085fac8a6d5d4c4c2c15da987246 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: HostMonitoring - update cache when updating dynamic data
by rgolan＠redhat.com 02 Dec '14

02 Dec '14

Roy Golan has submitted this change and it was merged. Change subject: core: HostMonitoring - update cache when updating dynamic data ...................................................................... core: HostMonitoring - update cache when updating dynamic data not updating the cache causes races in storing stale data to db such as old status, vm count (in case doing Manual fence and so on... Change-Id: Id007638586733b7263ae574e97a98c78faa5e666 https://bugzilla.redhat.com/show_bug.cgi?id=1099068 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id007638586733b7263ae574e97a98c78faa5e666 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0