Change in ovirt-engine[master]: core: monitoring - make Vm a managed resource
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: monitoring - make Vm a managed resource
......................................................................
core: monitoring - make Vm a managed resource
- Introduce VmManger state object
- responsible for getting dynamic,statistics and saving to db
- holds the last changed status
- holds a lock to co-ordinate execution of commands or monitoring
Change-Id: Ia711cc2d69082ecc03325362291faa4a38aa6c0a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/common/qualifiers/VmDeleted.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ManagingVmCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
A backend/manager/modules/vdsbroker/src/main/resources/META-INF/beans.xml
7 files changed, 145 insertions(+), 4 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32586
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia711cc2d69082ecc03325362291faa4a38aa6c0a
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[master]: core: monitoring - separate Host Monitoring and Vm Moniting
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: monitoring - separate Host Monitoring and Vm Moniting
......................................................................
core: monitoring - separate Host Monitoring and Vm Moniting
- introduce another quartz job to fire each 3 seconds
(VDS_REFRESH_RATE)
- try lock each VM before monitoring - if fail don't monitor it
- Create, Destory Hibernate etc, that change VM state (status, dynamic, statistics)
must aquires this lock before executing and release finally
- Vm Monitoring locking is minimized to per-VM scope.
- Count memCommited and vmsCoresCount at VM Monitoring cycle
- Update VdsManager with the new values
- Host monitoring is responsible in getting those metrics and save to db
if changed
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068
Change-Id: I54c6091a3996c23a4b70c7ef89412d34f1b58e34
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HibernateVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResumeVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java
11 files changed, 232 insertions(+), 225 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28173
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54c6091a3996c23a4b70c7ef89412d34f1b58e34
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: monitoring - make host monitoring fetch mem commited f...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: monitoring - make host monitoring fetch mem commited from vms monitoring
......................................................................
core: monitoring - make host monitoring fetch mem commited from vms
monitoring
Change-Id: I5a9f1aa04f979a1278614f7c96b33458da399997
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
2 files changed, 25 insertions(+), 10 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27921
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a9f1aa04f979a1278614f7c96b33458da399997
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[master]: core: monitoring - rename VURTI to HostMonitoring
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: monitoring - rename VURTI to HostMonitoring
......................................................................
core: monitoring - rename VURTI to HostMonitoring
Change-Id: I100d1821428260e9a7e623b06deabf71edcf5cbc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java
4 files changed, 18 insertions(+), 18 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I100d1821428260e9a7e623b06deabf71edcf5cbc
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[master]: core: monitoring - split VDS and VMs monitoring apart
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: monitoring - split VDS and VMs monitoring apart
......................................................................
core: monitoring - split VDS and VMs monitoring apart
Change-Id: Ic2f4acb9ad6acd07552d4aabe97cd2a63a328b75
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java
4 files changed, 2,046 insertions(+), 1,844 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27920
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2f4acb9ad6acd07552d4aabe97cd2a63a328b75
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[master]: core: monitoring - adhere to fields naming convention
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: monitoring - adhere to fields naming convention
......................................................................
core: monitoring - adhere to fields naming convention
Change-Id: I18d520d3b7a61c2e02bb43ca73334b8c0ecc1c23
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
2 files changed, 167 insertions(+), 168 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
Omer Frenkel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/27941
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18d520d3b7a61c2e02bb43ca73334b8c0ecc1c23
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[master]: core: VM monitoring - no need to handle exception
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: VM monitoring - no need to handle exception
......................................................................
core: VM monitoring - no need to handle exception
Execption handling isn't the responsibility of this class rather its
Host Monitoring task.
- fetchVMs is now void method
- VDSProtocolException was never used in the code
next:
separate the VM fetching strategy responsibility
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068
Change-Id: I6f037813b52d63c45c97c44e3e6074c009dd5b9a
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VDSProtocolException.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java
3 files changed, 38 insertions(+), 84 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28661
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f037813b52d63c45c97c44e3e6074c009dd5b9a
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Monitoring - refactor Host newtork error handling
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Monitoring - refactor Host newtork error handling
......................................................................
core: Monitoring - refactor Host newtork error handling
Host VDS network error should trigger a state change
and a treatment for auto-fencing as outlined in [1]
[1] http://www.ovirt.org/Automatic_Fencing
This handling is done at a single place [2] and is only called
from a single place, the VdsEventListener [3].
[2] VdsManager.handleNetworkException
[3] void onError(@Observes VdsNetworkException networkException)
*All* vds broker commands in action that throw VDS network exception is also
firing and event with the Exception as payload.
The event it caught by VdsEventListener and it invokes the handling on
using the assigned VdsManager in a separate thread.
Mo more VDSNetwork Exception throwing and re-throwing for flow control.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068
Change-Id: I59d26baa4d372905c8249edb0aabe28ea4c4a74a
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VDSError.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmStatisticsFetcherTest.java
9 files changed, 157 insertions(+), 114 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35521
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59d26baa4d372905c8249edb0aabe28ea4c4a74a
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[master]: core: VM Monitoring abstract fetching/analyzing/monitoring
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: VM Monitoring abstract fetching/analyzing/monitoring
......................................................................
core: VM Monitoring abstract fetching/analyzing/monitoring
this patch introduces the core changes the monitoring stack.
the work breaks down responsibilities and changes internal locking
characteristics:
* Data(VM/s) fetching:
classes: VmListFetcher.java, VmStatisticsFetcher.java
in-charge of fetching vms list/stats together with the db counter-part
and store for analysis on VdsManager
* State analysis:
classes: VmAnalyzer.java
invoked with 2 view of a VM, a stored on (dbVm) and a running
one(vdsmVm), analyzing what changed and marking with flags
for further actions down the line. currently some actions are
performed in-lined in the class - they should be moved out.
* Actions dispatching:
classes: VmsMonitoring.java
invoke all Vm analyzers in hand and iterate over their report
and take actions - fire VDSM commands (destroy,run/rerun,migrate), report complete actions,
hand-over migration and save-to-db
* New Locking characteristics:
classes: VmManager.java
responsible to lock a Vm entity (relation by Vm Guid) for exclusive
dispatching a VDSM call OR a analysis && dispatching (i.e monitoring
cycle)
i.e. CreateVmVdsCommand will hold the lock, thus preventing only this
single VM from being monitored.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068
Change-Id: I1adf0a95007140e89b080b5160ba93e340ee3ba6
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VdsIdAndVdsVDSCommandParametersBase.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsListFetcher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsStatisticsFetcher.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmTestPairs.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsListFetcherTest.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java
15 files changed, 2,373 insertions(+), 1,480 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28662
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1adf0a95007140e89b080b5160ba93e340ee3ba6
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[master]: core: monitoring - extract saveToDb and afterRefresh of VMs
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: monitoring - extract saveToDb and afterRefresh of VMs
......................................................................
core: monitoring - extract saveToDb and afterRefresh of VMs
Change-Id: I94bb7984b4767c434786320d5d08ae4dedf29e4c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 44 insertions(+), 34 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27918
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94bb7984b4767c434786320d5d08ae4dedf29e4c
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months