December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: uutils: Extract connectionBuilder class
by yzaslavs＠redhat.com 02 Dec '14

02 Dec '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: uutils: Extract connectionBuilder class ...................................................................... uutils: Extract connectionBuilder class Change-Id: I85ea4e7301b3a018b0438fff25cefad80ebd7256 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpURLConnectionBuilder.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/servlet/ProxyServletBase.java 2 files changed, 190 insertions(+), 74 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85ea4e7301b3a018b0438fff25cefad80ebd7256 Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: uutils: introduce CertificateChain
by yzaslavs＠redhat.com 02 Dec '14

02 Dec '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: uutils: introduce CertificateChain ...................................................................... uutils: introduce CertificateChain Chain related utilities. Change-Id: I20fd6ea1436f22eae40c572f8fbed5d13391ffbc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/CertificateChain.java 1 file changed, 226 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20fd6ea1436f22eae40c572f8fbed5d13391ffbc Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Introduce GinUiBinder
by vszocs＠redhat.com 01 Dec '14

01 Dec '14

Vojtech Szocs has submitted this change and it was merged. Change subject: frontend: Introduce GinUiBinder ...................................................................... frontend: Introduce GinUiBinder Added support for the GinUiBinder feature of GWTP 1.3. GinUiBinder replaces the standard GWT UiBinder with GTWP's implementation adding support for injecting GIN dependencies into views created by UiBinder. This can be greately beneficial in many cases where we use @UiField(provided=true) just to pass dependencies to child views. In order to create GIN-enabled view, just use @Inject annotated constructor where you inject required dependencies (you can also inject editor Driver and IdHandler instead of GWT.create-ing them) and add method returning type of your view to the apropriate GinUiBinderWidgets ginjector extension. The ginjector extensions for respective modules are: * gwt-common: CommonGinUiBinderWidgets * webadmin: WebAdminGinUiBinderWidgets * userportal-gwtp: UserPortalGinUiBinderWidgets Change-Id: Ib3ac93ae3c8a80f5b49a0780ed8c9a674a109779 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/CommonGinUiBinderWidgets.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/ClientGinjectorExtension.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UserPortalGinUiBinderWidgets.java M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/WebAdminGinUiBinderWidgets.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 13 files changed, 127 insertions(+), 79 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3ac93ae3c8a80f5b49a0780ed8c9a674a109779 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: don't throw an exception, when moving unresponsive VDS...
by tnisan＠redhat.com 01 Dec '14

01 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: don't throw an exception, when moving unresponsive VDS to maintenance ...................................................................... core: don't throw an exception, when moving unresponsive VDS to maintenance When VDS which is part of hosted engine cluster becoms non-responsive, it throws an exception when running SetHaMaintenance command which results in roll back of the whole maintenance command preventing user from removing the broken VDS Change-Id: Ibf9b489f73793ea1135a72bf1a9184e0822386d8 Bug-Url: https://bugzilla.redhat.com/1162998 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetHaMaintenanceModeVDSCommand.java 2 files changed, 23 insertions(+), 9 deletions(-) Approvals: Jiří Moskovčák: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf9b489f73793ea1135a72bf1a9184e0822386d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: make it more obvious that thread as cores is enabled
by tnisan＠redhat.com 01 Dec '14

01 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: make it more obvious that thread as cores is enabled ...................................................................... webadmin: make it more obvious that thread as cores is enabled Users are confused when the count threads as cores is enabled, but the threads per socket still shows the same value. This patch changes the UI a adds also the threads count to the "Cores per socket" field. Change-Id: I2fb9d28f3b125a9104fec5f3a887efdbf711b037 Bug-Url: https://bugzilla.redhat.com/1082681 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostHardwareView.java 5 files changed, 31 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jiří Moskovčák: Verified Doron Fediuck: Looks good to me, approved Gilad Chaplik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fb9d28f3b125a9104fec5f3a887efdbf711b037 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : [mla] query execution failed due to insufficient pe...
by tnisan＠redhat.com 01 Dec '14

01 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: engine : [mla] query execution failed due to insufficient permissions ...................................................................... engine : [mla] query execution failed due to insufficient permissions GetTasksStatusesByTasksIDsQuery throws insufficient permissions when querying for task ids Change-Id: I2d036f6a03a5f46342945452340133bd8150ce45 Bug-Url: https://bugzilla.redhat.com/1153043 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTasksStatusesByTasksIDsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java 3 files changed, 31 insertions(+), 4 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d036f6a03a5f46342945452340133bd8150ce45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Add a warning when removing a Data Center.
by tnisan＠redhat.com 01 Dec '14

01 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add a warning when removing a Data Center. ...................................................................... webadmin: Add a warning when removing a Data Center. Add a warning indicating that the entities reside on the Storage Domain(s) attached to the removed Data Center, will become unregistered. Bug-Url: https://bugzilla.redhat.com/1138133 Bug-Url: https://bugzilla.redhat.com/1138119 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I41ae4ea39e033696d7e2f37dcea9e7574a7447ab --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41ae4ea39e033696d7e2f37dcea9e7574a7447ab Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Add a warning when detaching a Storage Domain
by tnisan＠redhat.com 01 Dec '14

01 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add a warning when detaching a Storage Domain ...................................................................... webadmin: Add a warning when detaching a Storage Domain Add a warning indicating that the entities reside on the Storage Domain will be removed from the setup. Change-Id: Id18794fe37e9c3717fa37abac5bf69a928c800c9 Bug-Url: https://bugzilla.redhat.com/1138133 Bug-Url: https://bugzilla.redhat.com/1138119 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 22 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id18794fe37e9c3717fa37abac5bf69a928c800c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: NPE when adding detached disk without SD
by tnisan＠redhat.com 01 Dec '14

01 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: NPE when adding detached disk without SD ...................................................................... core: NPE when adding detached disk without SD Disk Profiles should be checked after verifying SD. Change-Id: I81e8a487cae33c772b18addc94926babbfe19073 Bug-Url: https://bugzilla.redhat.com/1168525 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> (cherry picked from commit 314ca8d1569aab865af9f8f236f723fc3744b395) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified Roy Golan: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81e8a487cae33c772b18addc94926babbfe19073 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix disk move and export metadata
by juan.hernandez＠redhat.com 01 Dec '14

01 Dec '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix disk move and export metadata ...................................................................... restapi: Fix disk move and export metadata The description of the operations to move, copy and export disks using the top level disks collection is incorrect. This means that these operations aren't supported in the SDKs and in the CLI. This patch fixes the documentation. Change-Id: I8a5cec5bf3049d3a9325b23a7d54c21565388b51 Bug-Url: https://bugzilla.redhat.com/1169376 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 15 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5cec5bf3049d3a9325b23a7d54c21565388b51 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0