Change in ovirt-engine[ovirt-engine-3.3]: core: Detect host in idle prep for maintenance and re-migrate
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Detect host in idle prep for maintenance and re-migrate
......................................................................
core: Detect host in idle prep for maintenance and re-migrate
Host going to Maintenance can have ongoing incoming migration before it
changes its status to Preparing for maintainance.
This host will migrate all its VMs except those incoming, which are not
he's still. This will result the host staying in PreparingForMaint
till manual intervention.
The solution has 3 parts:
1. cancel all incoming migrations
2. make cancel migration command trigger a rerun of the migration
automatically
3. detect if host is idle long time in PreparingForMaint and migrate VMs
out
Bug-Url: https://bugzilla.redhat.com/1030367
Change-Id: I0e18bcfbc566b6fd92d276c5c739ba607e2a53f0
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CancelMigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CancelMigrateVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CancelMigrationVDSParameters.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/dbscripts/vms_sp.sql
M packaging/etc/engine-config/engine-config.properties
13 files changed, 101 insertions(+), 20 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20899
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e18bcfbc566b6fd92d276c5c739ba607e2a53f0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: engine: Block setting a plugged disk as read only when the v...
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Block setting a plugged disk as read only when the vm is running
......................................................................
engine: Block setting a plugged disk as read only when the vm is running
Change-Id: I0bd16d91e02f26f2d6697b31233669a80a98534c
Bug-Url: https://bugzilla.redhat.com/1050840
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
2 files changed, 29 insertions(+), 6 deletions(-)
Approvals:
Sergey Gotliv: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
Liron Ar: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bd16d91e02f26f2d6697b31233669a80a98534c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: prevent illegal disk on custom preview active snapshot
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: prevent illegal disk on custom preview active snapshot
......................................................................
core: prevent illegal disk on custom preview active snapshot
* SnapshotVmConfigurationHelper:
avoid marking disks as illegal for a 'PREVIEW' snapshot
as it represents previous 'Active VM' state.
* SnapshotsManager -> attempToRestoreVmConfigurationFromSnapshot:
updating images according the specified list when VmConfiguration
is not available - i.e. custom snapshotting to active VM
(prevents a possible scenario of missing disks on active VM).
Change-Id: I1561107e05de155f9483e1f8a00d2dba3a4ab342
Bug-Url: https://bugzilla.redhat.com/1064067
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
2 files changed, 12 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24804
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1561107e05de155f9483e1f8a00d2dba3a4ab342
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: SyncLunsInfo when activating FC storage domain
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: SyncLunsInfo when activating FC storage domain
......................................................................
core: SyncLunsInfo when activating FC storage domain
* Invoke SyncLunsInfoForBlockStorageDomainCommand on
FCPStorageHelper -> connectStorageToDomainByVdsId.
* Renamed SyncLunsInfoForIscsiStorageDomainCommand to
SyncLunsInfoForBlockStorageDomainCommand for defining
its purpose accurately.
Change-Id: I31f3e376120e7b30a74af8d1fc7e3ed5346411f8
Bug-Url: https://bugzilla.redhat.com/1066081
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForBlockStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
5 files changed, 14 insertions(+), 6 deletions(-)
Approvals:
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24714
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31f3e376120e7b30a74af8d1fc7e3ed5346411f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: Reorder network actions when changing host cluster
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Reorder network actions when changing host cluster
......................................................................
engine: Reorder network actions when changing host cluster
When moving host between clusters, there is a need to first
clear all the labeled networks originated in the source
cluster. Second, to add all of the labeled networks according
to the target cluster attachment.
The reason for it is to deallocate assigned interfaces which
were assigned with networks of the source cluster.
Change-Id: I1ea644edbe7e3d314d4d1baf8a45b52d7a5a8f95
Bug-Url: https://bugzilla.redhat.com/1064953
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
1 file changed, 10 insertions(+), 10 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/24571
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ea644edbe7e3d314d4d1baf8a45b52d7a5a8f95
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: Modify EnableMACAntiSpoofing version to general
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Modify EnableMACAntiSpoofing version to general
......................................................................
engine: Modify EnableMACAntiSpoofing version to general
There used to be a mix in the declaration and usage of
MacAntiSpoofingFilterRulesSupported configuration value
which allowed the user to determine in which cluster
level the feature should be used. This should be determined
by the engine itself and not by the user.
Therefore the versioning is removed from this parameter
which will define for the entire system if no-mac-spoofing
filter should be applied to running vms or not.
Change-Id: Ia2c7659844318dd38241a6ae56895ca3c4bf91cf
ug-Url: https://bugzilla.redhat.com/1063711
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
4 files changed, 16 insertions(+), 5 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/24570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2c7659844318dd38241a6ae56895ca3c4bf91cf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: fix flow of FC DirectLUN disk creation
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: fix flow of FC DirectLUN disk creation
......................................................................
core: fix flow of FC DirectLUN disk creation
StorageDomainCommandBase -> proceedLUNInDb:
prevent connections handling for FCP storage
(FCP storage doesn't utilize connections).
Change-Id: Icf0fbd892b4c8549380b4394c8a4545de1da2343
Bug-Url: https://bugzilla.redhat.com/1065014
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, but someone else must approve
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf0fbd892b4c8549380b4394c8a4545de1da2343
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: New Data Center "Guide Me" does not reflect hosts ...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: New Data Center "Guide Me" does not reflect hosts presence
......................................................................
webadmin: New Data Center "Guide Me" does not reflect hosts presence
DataCenter guide me dialog does not reflect the
presence of hosts. "Configure Host" button appears
under "There are still unconfigured entities:"
even when hosts exist in the datacenter.
Change-Id: I6dbbac65e439f0d58b4104da8e1acb2860e7556c
Bug-Url: https://bugzilla.redhat.com/1023330
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 13 insertions(+), 2 deletions(-)
Approvals:
Ravi Nori: Verified
Itamar Heim: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24833
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dbbac65e439f0d58b4104da8e1acb2860e7556c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: restapi: Do not cast memory.used to int
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Do not cast memory.used to int
......................................................................
restapi: Do not cast memory.used to int
Casting the computed value to int caused an overflow
when the value was higher than about 4G. That is not
that unusual nowadays..
Change-Id: I216ac4ef5cf4cfd8cf523a84f75b252e0ce65ad0
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/VmStatisticalQuery.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Sivák: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24859
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I216ac4ef5cf4cfd8cf523a84f75b252e0ce65ad0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: Cloud init wants DNS inside interface
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Cloud init wants DNS inside interface
......................................................................
core: Cloud init wants DNS inside interface
Cloud-init expects the DNS information inside the network interface
definition, like this:
iface eth0 inet static
address 192.168.0.1
netmask 255.255.255.0
gateway 192.168.0.1
dns-nameservers 1.1.1.1 2.2.2.2
dns-search example.com
auto eth0
But we put it outside, like this:
dns-nameservers 1.1.1.1 2.2.2.2
dns-search example.com
iface eth0 inet static
address 192.168.0.1
netmask 255.255.255.0
gateway 192.168.0.1
auto eth0
The way we do it looks more correct, as the list of name servers and
search domains isn't specific to a network interface, but common to all
of them. But cloud-init doesn't like this. This patch changes the engine
so that it generates the format that cloud-init wants.
Change-Id: I79f758544496bedaf4e220639a9768a2518579f6
Bug-Url: https://bugzilla.redhat.com/1067906
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java
1 file changed, 13 insertions(+), 13 deletions(-)
Approvals:
Greg Padgett: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Juan Hernandez: Verified
--
To view, visit http://gerrit.ovirt.org/24850
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79f758544496bedaf4e220639a9768a2518579f6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months