February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: Extending SAN storage caused an NPE for a storage deta...
by iheim＠redhat.com 27 Feb '14

27 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Extending SAN storage caused an NPE for a storage detached from a pool ...................................................................... core: Extending SAN storage caused an NPE for a storage detached from a pool Extending a SAN storage domain that is detached from a storage pool caused an NPE due to a bug in the CDA part which caused the CDA evaluation to continue even though the status validation failed Change-Id: I4f6687bfe8390142519c2d641badc79fe6a1e0db Bug-Url: https://bugzilla.redhat.com/1061121 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java 1 file changed, 27 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f6687bfe8390142519c2d641badc79fe6a1e0db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: setting destination cluster when importing glance ...
by oourfali＠redhat.com 27 Feb '14

27 Feb '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: setting destination cluster when importing glance templates ...................................................................... webadmin: setting destination cluster when importing glance templates When importing glance templates it is useful to allow selecting a cluster for this template. This patch adds this functionality Change-Id: I828590dae0b68b9bb3da9fc136084c9673cd4c8d Bug-Url: https://bugzilla.redhat.com/1070394 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportRepoImageParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ExportRepoImageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportExportRepoImageBaseModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportRepoImageModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.ui.xml 8 files changed, 131 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I828590dae0b68b9bb3da9fc136084c9673cd4c8d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Missing storage options in data center "Guide me"
by tnisan＠redhat.com 27 Feb '14

27 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Missing storage options in data center "Guide me" ...................................................................... webadmin: Missing storage options in data center "Guide me" In data center model, when clicking the "Add More Storage" options lacked some storage types that exists in the new storage dialog under storage tab this patch fixes that Change-Id: I2c2327962efcb26c671f3479fd53a4093efbe3e1 Bug-Url: https://bugzilla.redhat.com/1065970 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 3 files changed, 60 insertions(+), 56 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c2327962efcb26c671f3479fd53a4093efbe3e1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add ISO domain option in data center "Guide me" is...
by tnisan＠redhat.com 27 Feb '14

27 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add ISO domain option in data center "Guide me" is missing ...................................................................... webadmin: Add ISO domain option in data center "Guide me" is missing A bug in the guide me model caused the add ISO domain option in the data center guide me to be only visible in case there is no ISO domain in the whole setup, this is wrong since the user should be able to add a new ISO to a data center regardless to whether another ISO already exists in the system Change-Id: I76c61f65e6cf7dbdaf631e2c9b7663f9dfffd16a Bug-Url: https://bugzilla.redhat.com/1070152 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 23 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76c61f65e6cf7dbdaf631e2c9b7663f9dfffd16a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Extending SAN storage caused an NPE for a storage deta...
by tnisan＠redhat.com 27 Feb '14

27 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Extending SAN storage caused an NPE for a storage detached from a pool ...................................................................... core: Extending SAN storage caused an NPE for a storage detached from a pool Extending a SAN storage domain that is detached from a storage pool caused an NPE due to a bug in the CDA part which caused the CDA evaluation to continue even though the status validation failed Change-Id: I4f6687bfe8390142519c2d641badc79fe6a1e0db Bug-Url: https://bugzilla.redhat.com/1061121 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java 1 file changed, 27 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f6687bfe8390142519c2d641badc79fe6a1e0db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: database: do not enable provisioning unles...
by iheim＠redhat.com 27 Feb '14

27 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: database: do not enable provisioning unless actually requested ...................................................................... packaging: setup: database: do not enable provisioning unless actually requested Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070735 Change-Id: If45bba8bd95b8bf4ab71c5ee1839b20d6becc779 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If45bba8bd95b8bf4ab71c5ee1839b20d6becc779 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: database: support get vdc option's versions
by iheim＠redhat.com 27 Feb '14

27 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: database: support get vdc option's versions ...................................................................... packaging: setup: database: support get vdc option's versions Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1059156 Change-Id: I4c36d59afbc502f0bb28b0bbad1315f4e9c65702 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 39 insertions(+), 24 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c36d59afbc502f0bb28b0bbad1315f4e9c65702 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix findbugs warning
by vszocs＠redhat.com 27 Feb '14

27 Feb '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: fix findbugs warning ...................................................................... webadmin: fix findbugs warning - Fix findbugs warning about using new Integer(String) instead of Integer.valueOf(String). Change-Id: I999e8a85081f2ef9ef975cbff4ce6669dac7f2ec Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridTimerStateChangeEvent.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I999e8a85081f2ef9ef975cbff4ce6669dac7f2ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: database: do not enable provisioning unles...
by sbonazzo＠redhat.com 27 Feb '14

27 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: database: do not enable provisioning unless actually requested ...................................................................... packaging: setup: database: do not enable provisioning unless actually requested Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070735 Change-Id: If45bba8bd95b8bf4ab71c5ee1839b20d6becc779 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If45bba8bd95b8bf4ab71c5ee1839b20d6becc779 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[cli_3.4]: cli: Prepare for next release
by juan.hernandez＠redhat.com 27 Feb '14

27 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Prepare for next release ...................................................................... cli: Prepare for next release In preparation for the next release this patch increases the version number and sets the RPM release number to 0.1. Change-Id: Ic8b06bda6062b7f7d38731a2f5088450af2d1444 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b06bda6062b7f7d38731a2f5088450af2d1444 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0