Change in ovirt-engine[ovirt-engine-3.4]: ui: from new cluster GuideMe form adding host by pk fails
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: ui: from new cluster GuideMe form adding host by pk fails
......................................................................
ui: from new cluster GuideMe form adding host by pk fails
Adding host by public key failed on "cannot add host with empty
password" because the authentication method was not set properly to the
Add host request.
Change-Id: I7001e0766d52ac92fe17d6e84fbc42767007e5eb
Bug-Url: https://bugzilla.…
[View More]redhat.com/show_bug.cgi?id=1057575
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Yaniv Bronhaim: Verified
--
To view, visit http://gerrit.ovirt.org/24226
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7001e0766d52ac92fe17d6e84fbc42767007e5eb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.3]: core: fix vm pools behavior when DC is missing
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: fix vm pools behavior when DC is missing
......................................................................
core: fix vm pools behavior when DC is missing
When DC is missing (for example force-removed)
then if any vm pools still exist, they don't return in queries, because
of bad join in the view.
this was fixed by changing the vm_pools_view to use left-join with
storage-pools
in addition, this should not …
[View More]happen, as empty vm pools are not
supported.
but when using force-remove DC, all vms are deleted, but vm-pools are
left.
this was fixed by changing the stored procedure for remove storage
pool, to remove vm-pools as well, after removing vms.
Change-Id: I47c963b6b66efa05e96cb9b9f80e034d8070a30b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031717
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069219
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/storages_sp.sql
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Looks good to me, approved
Omer Frenkel: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47c963b6b66efa05e96cb9b9f80e034d8070a30b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 10 months
Change in ovirt-engine[master]: engine : creating storage connection with empty port, port i...
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine : creating storage connection with empty port, port is set to 0
......................................................................
engine : creating storage connection with empty port, port is set to 0
When creating a storage connection if an empty
port is passed the value is set to 0.
A new validation has been added to canDoAction
that verifies that the port is greater than zero.
Change-Id: …
[View More]Ief68a9b65946d88e3eace6f21fc887ea373725b1
Bug-Url: https://bugzilla.redhat.com/1006449
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 101 insertions(+), 13 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24402
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief68a9b65946d88e3eace6f21fc887ea373725b1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 10 months
Change in ovirt-engine[master]: engine: Print correct message for network used by templates
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Print correct message for network used by templates
......................................................................
engine: Print correct message for network used by templates
Change-Id: Ic398609b1133665217cb5e59dacbfb30ea78eeb3
Bug-Url: https://bugzilla.redhat.com/1058030
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/…
[View More]network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java
2 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/24997
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic398609b1133665217cb5e59dacbfb30ea78eeb3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 10 months
Change in ovirt-engine[master]: core: Preserve bonding options when updating vlan over bond
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Preserve bonding options when updating vlan over bond
......................................................................
core: Preserve bonding options when updating vlan over bond
The ovirt-engine used to erase any pre-configured
bonding options, if it wasn't provided explicitly
by the api users.
In order to preserve the bonding options properly,
there is a need either to examine it from the supplied
…
[View More]properties or to use the already configured bonding
device from the engine db.
Change-Id: I09b150b11913a9d8cddc5115e28c027e7c944910
Bug-Url: https://bugzilla.redhat.com/1068970
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
2 files changed, 28 insertions(+), 13 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/24912
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09b150b11913a9d8cddc5115e28c027e7c944910
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 10 months
Change in ovirt-engine[master]: core: VdsDynamicDAO.testUpdateIfNeededPerformance
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdsDynamicDAO.testUpdateIfNeededPerformance
......................................................................
core: VdsDynamicDAO.testUpdateIfNeededPerformance
As this test is based on timing, it fails sporadically, thus generating
inappropriate noise during build time. Moreover, this is a performance
test, not a correctness test, and as such should not be part of the
regular test suite.
Change-Id: …
[View More]I4ce745eb4416ffac0ae7162f69e85b55bd003569
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java
1 file changed, 0 insertions(+), 23 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25117
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ce745eb4416ffac0ae7162f69e85b55bd003569
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 10 months
Change in ovirt-engine[master]: core: AuditLogDAOTest date format
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: AuditLogDAOTest date format
......................................................................
core: AuditLogDAOTest date format
Since SimpleDateFormat is inherently not thread-safe and some runners
may run different tests in different thread, it's a potential bug to use
a static instance of it.
Additionally, this issue is picked up by recent version of FindBugs and
Coverity, generating noise.
Change-Id: …
[View More]I41384f1f061bcffbc08c2f0fda8633d2f42bd5a9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25116
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41384f1f061bcffbc08c2f0fda8633d2f42bd5a9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 10 months
Change in ovirt-engine[master]: tools: Allow to configure domains_realm section via external...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: Allow to configure domains_realm section via external file
......................................................................
tools: Allow to configure domains_realm section via external file
This can come handy in case the kerberos realm for the
added domain is not an upper case version of it.
Bare in mind the external file should contain all the domains
in case there is more than one domain in the setup
…
[View More]
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070465
Change-Id: I970b8f4950abb5eeb0a72a46ed00af26028919dd
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsConfiguration.java
3 files changed, 49 insertions(+), 4 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I970b8f4950abb5eeb0a72a46ed00af26028919dd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 10 months
Change in ovirt-reports[master]: packaging: customization: added patch to fix jrs pro start
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: customization: added patch to fix jrs pro start
......................................................................
packaging: customization: added patch to fix jrs pro start
This also required a changed in deployment order, since a bean
we add needed to be removed.
Change-Id: Icccd1e62680e756f8de26c8c8f76dd0947750ccf
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
A packaging/jasper-war-patches/…
[View More]pro/200_006_web-inf_remove_query_manipulator_override.patch
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
2 files changed, 52 insertions(+), 18 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icccd1e62680e756f8de26c8c8f76dd0947750ccf
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
[View Less]
10 years, 10 months
Change in ovirt-reports[master]: packaging: setup: added jrs pro edition deploy steps
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: added jrs pro edition deploy steps
......................................................................
packaging: setup: added jrs pro edition deploy steps
Setup can now install either JRS CE edition or PRO edition.
Change-Id: I3a3f36e11d0450c031de6da6c6470024534c60e1
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/…
[View More]deploy.py
1 file changed, 166 insertions(+), 6 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a3f36e11d0450c031de6da6c6470024534c60e1
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
[View Less]
10 years, 10 months