February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[master]: cli: Add example of search with quotes
by juan.hernandez＠redhat.com 18 Feb '14

18 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Add example of search with quotes ...................................................................... cli: Add example of search with quotes This patch adds to the documentation of the list command an example of how to use quotes when the search text contains spaces. Change-Id: I4ca3f77a33bdec56b4d6630a73e9c3b38a6e7e40 Bug-Url: https://bugzilla.redhat.com/1065945 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/list.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/24622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ca3f77a33bdec56b4d6630a73e9c3b38a6e7e40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ilia Meerovich <imeerovi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Disabling an SD with unplugged disk of a VM
by amureini＠redhat.com 18 Feb '14

18 Feb '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Disabling an SD with unplugged disk of a VM ...................................................................... core: Disabling an SD with unplugged disk of a VM Prior to this patch, when disabling a Storage Domain the canDoAction() would check that it does not contain any disks in that belong to running VM, and if it does, the command is failed. This behavior is overly strict, and we should be able to disable a domain which contains unplugged disks, even if they are attached to a running VM. This patch contains: 1. Changing the GetVmsByStorageDomainId stored procedure to take only plugged disks in to account. 2. In fixtures.xml, plugging disk 1b26a52b-b60f-44cb-9f46-3ef333b04a35 into VM 77296e00-0cad-4e5a-9299-008a7b6f4355, as opposed to just attaching it in order for this fix to be tested. 3. Updating the DAO tests accordingly. Change-Id: I89d119295cf16eb1ea2df365fb22cadde6595e6a Bug-Url: https://bugzilla.redhat.com/969770 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/vms_sp.sql 6 files changed, 30 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89d119295cf16eb1ea2df365fb22cadde6595e6a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: build: ovirt-hosted-engine-ha-1.1.0-0.2.beta2
by dfediuck＠redhat.com 18 Feb '14

18 Feb '14

Doron Fediuck has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-1.1.0-0.2.beta2 ...................................................................... build: ovirt-hosted-engine-ha-1.1.0-0.2.beta2 Change-Id: I67489b82db8e26624e1bc8343adc000b1cc1e41f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67489b82db8e26624e1bc8343adc000b1cc1e41f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: build: post ovirt-hosted-engine-ha-1.1.0-0.2.beta2
by dfediuck＠redhat.com 18 Feb '14

18 Feb '14

Doron Fediuck has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.1.0-0.2.beta2 ...................................................................... build: post ovirt-hosted-engine-ha-1.1.0-0.2.beta2 Change-Id: I4d50c5105b765a9e27649bdb2df235d3a497ad27 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d50c5105b765a9e27649bdb2df235d3a497ad27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.4]: build: post ovirt-engine-3.3.4_beta1
by sbonazzo＠redhat.com 18 Feb '14

18 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-engine-3.3.4_beta1 ...................................................................... build: post ovirt-engine-3.3.4_beta1 Change-Id: I257df006a06c3a8b5f224b630aea628d78e0f8c3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I257df006a06c3a8b5f224b630aea628d78e0f8c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3.4]: packaging: ovirt-engine-3.3.4_beta1
by sbonazzo＠redhat.com 18 Feb '14

18 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.3.4_beta1 ...................................................................... packaging: ovirt-engine-3.3.4_beta1 Updated version to be 3.3.4-0.1.beta1 Change-Id: I668c22b5b78826ed3bd90a1bfb69394467841ecd Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I668c22b5b78826ed3bd90a1bfb69394467841ecd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Change default display type for x86-64 VMs
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Change default display type for x86-64 VMs ...................................................................... engine: Change default display type for x86-64 VMs After the change #20667, it is necessary put the default display protocol in the first position in the 'display.protocols' list. Change-Id: Iaba4996a482a0613282b45b19a658e8694a8d12b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057053 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaba4996a482a0613282b45b19a658e8694a8d12b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Fix vm_pools dynamic query
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Fix vm_pools dynamic query ...................................................................... core: Fix vm_pools dynamic query This fix will improve the dynamic query behavior when querying from vm_pool based on primary key query. Change-Id: I1f91cf3986e6f981e66b5ffd11b478fc1e724a4a Bug-Url: https://bugzilla.redhat.com/1064312 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 2 files changed, 16 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/24615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f91cf3986e6f981e66b5ffd11b478fc1e724a4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Enable AuditLogDAOTest.testLongMessageSave()
by amureini＠redhat.com 18 Feb '14

18 Feb '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Enable AuditLogDAOTest.testLongMessageSave() ...................................................................... core: Enable AuditLogDAOTest.testLongMessageSave() AuditLogDAO.testLongMessageSave() has been @Ignored since it consistently fails. This patch modifies it to stop relying on the new record's generated ID, so it can conceivably pass, in a similar fashion to testSave(). Additionally, the newly inserted AuditLog was made external (since internal messages do not get truncated) and the MaxAuditLogMessageLength config value was introduced to the fixtures database since the underlying InsertExternalAuditLog stored procedure relies on it, and VdcOptionDAOTest was amended accordingly. Change-Id: I30189046c8ad97256717e3c804996a22bf1b5d9b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdcOptionDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 21 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30189046c8ad97256717e3c804996a22bf1b5d9b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Enable AuditLogDAOTest.testSave()
by amureini＠redhat.com 18 Feb '14

18 Feb '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Enable AuditLogDAOTest.testSave() ...................................................................... core: Enable AuditLogDAOTest.testSave() AuditLogDAO.testSave() has been @Ignored since it consistently fails. This patch modifies it to stop relying on the new record's generated ID, and since it now passes - enable it. Change-Id: I205584cc2f43c16c47002e25f03624a8680c146f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I205584cc2f43c16c47002e25f03624a8680c146f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0