Change in ovirt-engine[master]: core: Prevent StopVm to interleave with other VM locked actions
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Prevent StopVm to interleave with other VM locked actions
......................................................................
core: Prevent StopVm to interleave with other VM locked actions
Stop and Shutdown VM commands are calling the DestoryVds command which is contending on
the VdsManager lock. The lock is implemented as synchronized (object) -
this means that order isn't kept and we're subjected to JVM's scheduling
descisions so other commands, like RunVm can take the lock and result the Vm to stop instead of start
Fix: take an exclusive engine lock on Stop and Shutdown commands
This will also prevent a situation where asyncRunningVms has an entry
although the VM is down.
Change-Id: I6109ef0ea4869b59a93be6fef4b0c3cff50da62e
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
3 files changed, 20 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24239
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6109ef0ea4869b59a93be6fef4b0c3cff50da62e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Mark Huth <mhuth(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: fix vm pools behavior when DC is missing
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: fix vm pools behavior when DC is missing
......................................................................
core: fix vm pools behavior when DC is missing
When DC is missing (for example force-removed)
then if any vm pools still exist, they don't return in queries, because
of bad join in the view.
this was fixed by changing the vm_pools_view to use left-join with
storage-pools
in addition, this should not happen, as empty vm pools are not
supported.
but when using force-remove DC, all vms are deleted, but vm-pools are
left.
this was fixed by changing the stored procedure for remove storage
pool, to remove vm-pools as well, after removing vms.
Change-Id: I47c963b6b66efa05e96cb9b9f80e034d8070a30b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031717
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/storages_sp.sql
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Roy Golan: Verified; Looks good to me, approved
Omer Frenkel: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47c963b6b66efa05e96cb9b9f80e034d8070a30b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: Use getFileStats to retrieve iso and floppy files
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Use getFileStats to retrieve iso and floppy files
......................................................................
engine: Use getFileStats to retrieve iso and floppy files
VDSM introduced new API getFileStats in 3.4 which returns statistics
of all files in the domain filtered according to pattern.
Now Engine starts using this new API, because file statistics are
significantly better in comparison with the existing getIsoList and
getFileList and allow Engine to provide additional information in UI,
for example a file size.
Change-Id: I735d2c9343fe791e0890b4a6cc9f12c74462b3f0
Bug-Url: https://bugzilla.redhat.com/1005889
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetFileStatsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetFloppyListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetFileStatsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HsmGetIsoListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
15 files changed, 177 insertions(+), 29 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Sergey Gotliv: Verified
--
To view, visit http://gerrit.ovirt.org/24265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I735d2c9343fe791e0890b4a6cc9f12c74462b3f0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: gluster: fix cleaning up orphan tasks
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: gluster: fix cleaning up orphan tasks
......................................................................
gluster: fix cleaning up orphan tasks
When there is rebalance task in progress and
'task list' is failed in vdsm for some reason,
engine should not cleanup this task and move to UNKNOWN.
Change-Id: I4f9bb53e5c2be194efeba966355d0245bcc18384
Bug-Url: https://bugzilla.redhat.com/1060994
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Kanagaraj M: Verified
Sahina Bose: Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f9bb53e5c2be194efeba966355d0245bcc18384
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Prevent selection of IDE disk as read-only in UI
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Prevent selection of IDE disk as read-only in UI
......................................................................
webadmin: Prevent selection of IDE disk as read-only in UI
Change-Id: I71856b447abc3bc3a48247c6df2d8e6083e8e783
Bug-Url: https://bugzilla.redhat.com/1057546
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
3 files changed, 36 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Sergey Gotliv: Verified
--
To view, visit http://gerrit.ovirt.org/24259
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71856b447abc3bc3a48247c6df2d8e6083e8e783
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: Validate that IDE disk is not read-only
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Validate that IDE disk is not read-only
......................................................................
engine: Validate that IDE disk is not read-only
Real IDE disks can't be read-only therefore Engine has to validate it.
Change-Id: I441362adf2f4833b034ede4093fc8195debd2ed5
Bug-Url: https://bugzilla.redhat.com/1057546
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 103 insertions(+), 15 deletions(-)
Approvals:
Sergey Gotliv: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I441362adf2f4833b034ede4093fc8195debd2ed5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Fix command line args in engine-manage-domains
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Fix command line args in engine-manage-domains
......................................................................
tools: Fix command line args in engine-manage-domains
1) Converts java-type arguments (-configFile) into proper long
arguments (--config-file)
2) Removes --action argument since action has to be always specified
3) Renames argument --force-delete to --force
Change-Id: I1296958a54d8b802e0d6fb59f1f75cc608e75818
Bug-Url: https://bugzilla.redhat.com/904029
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
A backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsResultEnum.java
A backend/manager/tools/src/main/resources/manage-domains-help.properties
M packaging/bin/engine-manage-domains.sh
M packaging/man/man8/engine-manage-domains.8
6 files changed, 656 insertions(+), 331 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23996
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1296958a54d8b802e0d6fb59f1f75cc608e75818
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Adds cli parser supporting short and long args
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Adds cli parser supporting short and long args
......................................................................
core: Adds cli parser supporting short and long args
Adds command line arguments parser that supports parsing short (-h) and
long arguments (--help).
Change-Id: Id7fe3bf761bd26c86d684ad1dc85751d4492239b
Bug-Url: https://bugzilla.redhat.com/904029
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/Argument.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ArgumentBuilder.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ExtendedCliParser.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ArgumentBuilderTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ExtendedCliParserTest.java
5 files changed, 770 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7fe3bf761bd26c86d684ad1dc85751d4492239b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Moves temp file creation from .sh to Java in engine-m...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Moves temp file creation from .sh to Java in engine-manage-domains
......................................................................
tools: Moves temp file creation from .sh to Java in engine-manage-domains
Moves creation of engine-config custom properties temporary file from
engine-manage-domains.sh to Java, so -propertiesFile command line
argument can be removed.
Change-Id: Ia6fd2c5066e0e0cf12d10be32ec6c36a8a91bfaf
Bug-Url: https://bugzilla.redhat.com/904029
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsResultEnum.java
M packaging/bin/engine-manage-domains.sh
3 files changed, 89 insertions(+), 68 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23994
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6fd2c5066e0e0cf12d10be32ec6c36a8a91bfaf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Removes inclusion of config file in engine-manage-dom...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Removes inclusion of config file in engine-manage-domains.sh
......................................................................
tools: Removes inclusion of config file in engine-manage-domains.sh
Removes unneeded inclusion of engine-manage-domains.conf in
engine-manage-domains.sh. The variables contained in this file are
needed later in java code, but not in engine-manage-domains.sh.
Change-Id: Ia26468cbcc64c44adb9805c258f1625c574b4ab5
Bug-Url: https://bugzilla.redhat.com/904029
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M packaging/bin/engine-manage-domains.sh
1 file changed, 0 insertions(+), 16 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23993
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia26468cbcc64c44adb9805c258f1625c574b4ab5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months