February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[master]: cli: Change action help text to match syntax
by juan.hernandez＠redhat.com 10 Feb '14

10 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Change action help text to match syntax ...................................................................... cli: Change action help text to match syntax For auto completion to work the parent identifiers of the resource have to be provided before the action, as the set of possible actions depends on the actual parent. This patch changes the help text so that it explains this. Change-Id: Ib3d82efa4a7fbff4ff04cb9a2c0d7b9fec3670e8 Bug-Url: https://bugzilla.redhat.com/1047543 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/action.py 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/24081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3d82efa4a7fbff4ff04cb9a2c0d7b9fec3670e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: added HelpTagType to HelpTag
by vszocs＠redhat.com 10 Feb '14

10 Feb '14

Vojtech Szocs has submitted this change and it was merged. Change subject: engine: added HelpTagType to HelpTag ...................................................................... engine: added HelpTagType to HelpTag Added a HelpTagType enum, and references to it in HelpTag. It's not used in GWT code, but helptag.py can now use it to filter down its ini/diff files to only those tags required specifically by webadmin or userportal. Updated helptag.py to use the HelpTagType to filter the help tags it scans. Change-Id: I64a3702878b9d341d78119585b51129478bb6d37 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M build/helptag.py M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTagType.java 3 files changed, 264 insertions(+), 230 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64a3702878b9d341d78119585b51129478bb6d37 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Move JAXB global bindings to external file
by juan.hernandez＠redhat.com 10 Feb '14

10 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Move JAXB global bindings to external file ...................................................................... restapi: Move JAXB global bindings to external file These bindings aren't part of the specification of the API, but of the implementation, so there is no reason to show them to the users. In addition they cause issues in the generator of the Java SDK, as it tries to use type converters that aren't available there. Change-Id: I0c79ae190d3c811c7d225ff5a293e14c541e688d Bug-Url: https://bugzilla.redhat.com/1063443 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/resources/api.xjb M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 2 files changed, 32 insertions(+), 30 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c79ae190d3c811c7d225ff5a293e14c541e688d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Remove redundant classes
by tnisan＠redhat.com 10 Feb '14

10 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Remove redundant classes ...................................................................... frontend: Remove redundant classes Those classes are no longer in use and are therefore redundant Change-Id: I486d021418fb076fac2e66c5e868fccc5c7526b7 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/CharEncoding.java D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/DecoderException.java D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/EncoderException.java 3 files changed, 0 insertions(+), 310 deletions(-) Approvals: Tal Nisan: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I486d021418fb076fac2e66c5e868fccc5c7526b7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Remove unused methods in StringUtils
by tnisan＠redhat.com 10 Feb '14

10 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Remove unused methods in StringUtils ...................................................................... frontend: Remove unused methods in StringUtils Change-Id: I1876fb6cfdb6fe8f057da2a45bd3c46cb32bf4ac Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java 1 file changed, 0 insertions(+), 260 deletions(-) Approvals: Tal Nisan: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1876fb6cfdb6fe8f057da2a45bd3c46cb32bf4ac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix NPE in DbUserCacheManager
by yzaslavs＠redhat.com 10 Feb '14

10 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix NPE in DbUserCacheManager ...................................................................... core: Fix NPE in DbUserCacheManager Fix NPE in DbUserCacheManager causing inability to login as admin@internal if LDAP domain has been add prior to first execution of engine. Change-Id: I7703d446841bea47222a066fe0a2b51827f12430 Bug-Url: https://bugzilla.redhat.com/1063276 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7703d446841bea47222a066fe0a2b51827f12430 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: fix motd
by awels＠redhat.com 10 Feb '14

10 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal: fix motd ...................................................................... userportal: fix motd - Fixed MOTD panel being modal and disabling the rest of the dialog. - Fixed flicker of MOTD panel when you have no MOTD. - Fixed MOTD showing during login process if you have a MOTD set. Change-Id: I048cdf6029617dda39357d876abd250bf9ae9a46 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063041 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java 1 file changed, 11 insertions(+), 16 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I048cdf6029617dda39357d876abd250bf9ae9a46 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: added missing edit_pool helpTag
by awels＠redhat.com 10 Feb '14

10 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: engine: added missing edit_pool helpTag ...................................................................... engine: added missing edit_pool helpTag Added back the missing edit_pool hashName and helpTag. Somehow it was removed in http://gerrit.ovirt.org/#/c/15048/ Change-Id: I623136a3630fca1cd7b829972d537d02ff3d1c52 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Alexander Wels: Looks good to me, but someone else must approve Einav Cohen: Looks good to me, but someone else must approve Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/24206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I623136a3630fca1cd7b829972d537d02ff3d1c52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: upgrade only from >= 3.3.2
by sbonazzo＠redhat.com 10 Feb '14

10 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: upgrade only from >= 3.3.2 ...................................................................... packaging: spec: upgrade only from >= 3.3.2 Upgrade to 3.5.0 is allowed only from >= 3.3.2. Avoid to pull in a version of ovirt-engine-setup that will need to be downgraded in order to allow the upgrade from a legacy version. Change-Id: I151c5b1156f4c9a91da0e5bd3e6d52149ae65cd5 Bug-Url: https://bugzilla.redhat.com/1054080 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I151c5b1156f4c9a91da0e5bd3e6d52149ae65cd5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: fix 404 regression for help files
by awels＠redhat.com 10 Feb '14

10 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: fix 404 regression for help files ...................................................................... userportal, webadmin: fix 404 regression for help files Patch http://gerrit.ovirt.org/#/c/21052/ introduced a regression where if no help mapping json files are found, a 404 is served to the UI and logged. This fixes that by sending back an empty JSON string. There was also a path mapping bug in patch http://gerrit.ovirt.org/#/c/21052/ and this fixes that as well. Change-Id: I219e986ac45e7a05801bd9b519a006a429e5f82f Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/HelpTagJsonServlet.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 4 files changed, 18 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Looks good to me, but someone else must approve Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I219e986ac45e7a05801bd9b519a006a429e5f82f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0