February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add confirmation window when deactivating a VM disk
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Add confirmation window when deactivating a VM disk ...................................................................... webadmin: Add confirmation window when deactivating a VM disk Change-Id: I13d9aa5386efd676d7b9d043c72c921ac3f07bf6 Bug-Url: https://bugzilla.redhat.com/1038980 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 71 insertions(+), 20 deletions(-) Approvals: Sergey Gotliv: Verified Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13d9aa5386efd676d7b9d043c72c921ac3f07bf6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: added HelpTagType to HelpTag
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: added HelpTagType to HelpTag ...................................................................... engine: added HelpTagType to HelpTag Added a HelpTagType enum, and references to it in HelpTag. It's not used in GWT code, but helptag.py can now use it to filter down its ini/diff files to only those tags required specifically by webadmin or userportal. Updated helptag.py to use the HelpTagType to filter the help tags it scans. Change-Id: I64a3702878b9d341d78119585b51129478bb6d37 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M build/helptag.py M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTagType.java 3 files changed, 264 insertions(+), 230 deletions(-) Approvals: Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64a3702878b9d341d78119585b51129478bb6d37 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: typo fix in README.manual
by vszocs＠redhat.com 10 Feb '14

10 Feb '14

Vojtech Szocs has submitted this change and it was merged. Change subject: engine: typo fix in README.manual ...................................................................... engine: typo fix in README.manual fixed typo. Change-Id: I1776fa24f28f3ab038fff1b9a6b99e4eeee5e07f Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M README.manual 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Greg Sheremeta: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1776fa24f28f3ab038fff1b9a6b99e4eeee5e07f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: added missing edit_pool helpTag
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: added missing edit_pool helpTag ...................................................................... engine: added missing edit_pool helpTag Added back the missing edit_pool hashName and helpTag. Somehow it was removed in http://gerrit.ovirt.org/#/c/15048/ Change-Id: I623136a3630fca1cd7b829972d537d02ff3d1c52 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I623136a3630fca1cd7b829972d537d02ff3d1c52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Move JAXB global bindings to external file
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Move JAXB global bindings to external file ...................................................................... restapi: Move JAXB global bindings to external file These bindings aren't part of the specification of the API, but of the implementation, so there is no reason to show them to the users. In addition they cause issues in the generator of the Java SDK, as it tries to use type converters that aren't available there. Change-Id: I0c79ae190d3c811c7d225ff5a293e14c541e688d Bug-Url: https://bugzilla.redhat.com/1063443 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/resources/api.xjb M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 2 files changed, 32 insertions(+), 30 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c79ae190d3c811c7d225ff5a293e14c541e688d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: refresh bookmarks
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: refresh bookmarks ...................................................................... webadmin: refresh bookmarks - Fixed issue where the bookmarks where not being refreshed when editting or adding bookmarks. Change-Id: I15ee191fb33c1c5b7132282ebb99a9160017aa53 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1060792 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15ee191fb33c1c5b7132282ebb99a9160017aa53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: use json for documentation mapping files
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: userportal, webadmin: use json for documentation mapping files ...................................................................... userportal, webadmin: use json for documentation mapping files Convert from using csv to json for documentation mapping files. Create new HelpTagJsonServlet to serve the json files to web apps. The servlet is configurable to allow multiple json files (so there can be a common file shared between webadmin and userportal). All configured files are merged into one json String at init time, and cached (to limit server calls). This backport also includes fix found in http://gerrit.ovirt.org/#/c/24212/ and http://gerrit.ovirt.org/#/c/24207/ Change-Id: I4d6e8be143583d253943445842c2851fb52274e6 Bug-Url: https://bugzilla.redhat.com/1014859 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M Makefile A README.manual A backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/HelpTagJsonServlet.java M backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/DocumentationPathTranslator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java M ovirt-engine.spec.in D packaging/manual/DocumentationPath.csv D packaging/manual/UserPortalDocumentationPath.csv 11 files changed, 254 insertions(+), 14 deletions(-) Approvals: Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d6e8be143583d253943445842c2851fb52274e6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: userportal: fix motd
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: userportal: fix motd ...................................................................... userportal: fix motd - Fixed MOTD panel being modal and disabling the rest of the dialog. - Fixed flicker of MOTD panel when you have no MOTD. - Fixed MOTD showing during login process if you have a MOTD set. Change-Id: I048cdf6029617dda39357d876abd250bf9ae9a46 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063041 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java 1 file changed, 11 insertions(+), 16 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I048cdf6029617dda39357d876abd250bf9ae9a46 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: userportal: allow links in MOTD
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: userportal: allow links in MOTD ...................................................................... userportal: allow links in MOTD - Added the ability for admins to add links in the MOTD in the user portal. These links are checked for safety before being added into the MOTD. Change-Id: I6c78c9e6d6dc9417e22c71dab66ae4507ea5c191 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java 4 files changed, 54 insertions(+), 13 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c78c9e6d6dc9417e22c71dab66ae4507ea5c191 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[cli_3.4]: cli: Change action help text to match syntax
by juan.hernandez＠redhat.com 10 Feb '14

10 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Change action help text to match syntax ...................................................................... cli: Change action help text to match syntax For auto completion to work the parent identifiers of the resource have to be provided before the action, as the set of possible actions depends on the actual parent. This patch changes the help text so that it explains this. Change-Id: Ib3d82efa4a7fbff4ff04cb9a2c0d7b9fec3670e8 Bug-Url: https://bugzilla.redhat.com/1047543 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 6528469db2435bb770a0a26edcdf4137a3435a72) --- M src/ovirtcli/command/action.py 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3d82efa4a7fbff4ff04cb9a2c0d7b9fec3670e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0