February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Remove redundant comments in DataCenterStorageList...
by tnisan＠redhat.com 09 Feb '14

09 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove redundant comments in DataCenterStorageListModel ...................................................................... webadmin: Remove redundant comments in DataCenterStorageListModel Change-Id: I88f3fc822790a0c6b552edb0e0c18b32417f4c4c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java 1 file changed, 0 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88f3fc822790a0c6b552edb0e0c18b32417f4c4c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix typo in ActionType
by tnisan＠redhat.com 09 Feb '14

09 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix typo in ActionType ...................................................................... core: Fix typo in ActionType ActionType.MANIPUTLATE_HOST renamed to ActionType.MANIPULATE_HOST Change-Id: Iaa3e7c526fe3b05c1e7dbe9c01377b3218d2d74c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ForceSelectSPMCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M packaging/dbscripts/insert_predefined_roles.sql M packaging/dbscripts/upgrade/03_02_0040_add_permissions_on_networks.sql M packaging/dbscripts/upgrade/03_04_0100_add_cluster_host_permissions_to_gluster_admin_role.sql 11 files changed, 28 insertions(+), 28 deletions(-) Approvals: Tal Nisan: Verified Sergey Gotliv: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved Liron Ar: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa3e7c526fe3b05c1e7dbe9c01377b3218d2d74c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Prevent selection of IDE disk as read-only in UI
by derez＠redhat.com 09 Feb '14

09 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Prevent selection of IDE disk as read-only in UI ...................................................................... webadmin: Prevent selection of IDE disk as read-only in UI Change-Id: I71856b447abc3bc3a48247c6df2d8e6083e8e783 Bug-Url: https://bugzilla.redhat.com/1057546 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 36 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71856b447abc3bc3a48247c6df2d8e6083e8e783 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add confirmation window when deactivating a VM disk
by derez＠redhat.com 09 Feb '14

09 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Add confirmation window when deactivating a VM disk ...................................................................... webadmin: Add confirmation window when deactivating a VM disk Change-Id: I13d9aa5386efd676d7b9d043c72c921ac3f07bf6 Bug-Url: https://bugzilla.redhat.com/1038980 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 71 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13d9aa5386efd676d7b9d043c72c921ac3f07bf6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: from new cluster GuideMe form adding host by pk fails
by derez＠redhat.com 09 Feb '14

09 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: ui: from new cluster GuideMe form adding host by pk fails ...................................................................... ui: from new cluster GuideMe form adding host by pk fails Adding host by public key failed on "cannot add host with empty password" because the authentication method was not set properly to the Add host request. Change-Id: I7001e0766d52ac92fe17d6e84fbc42767007e5eb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057575 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7001e0766d52ac92fe17d6e84fbc42767007e5eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: new vm - fix host selection on cluster change
by derez＠redhat.com 09 Feb '14

09 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: new vm - fix host selection on cluster change ...................................................................... webadmin: new vm - fix host selection on cluster change When changing dc/cluster in VM dialog, the selected host was empty as it dependeds on the ' oldDefaultHost' Fixed by ensuring that an item from the hosts list is selected. Change-Id: Icd80711a9c1557743946445196c3c0015d94fc26 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/24077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd80711a9c1557743946445196c3c0015d94fc26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: confirmation popup - ensure key event bubbling
by derez＠redhat.com 09 Feb '14

09 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: confirmation popup - ensure key event bubbling ...................................................................... webadmin: confirmation popup - ensure key event bubbling Catch ONKEYDOWN event on DialogBoxWithKeyHandlers for invoking relevant command when pressing enter\esc key. The change is needed for confirmation dialogs that don't contain widgets that extend FocusWidget (which adds a DomHandler for KeyPressEvent). Change-Id: I0f31dea9a5ea502879d450c3ed45aa0d53c4adc2 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f31dea9a5ea502879d450c3ed45aa0d53c4adc2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: improve audit log when creating diskless template
by ofrenkel＠redhat.com 09 Feb '14

09 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: improve audit log when creating diskless template ...................................................................... core: improve audit log when creating diskless template Change-Id: I99c88bbc84e19fef06d54bd25567500b056d6e20 Bug-Url: https://bugzilla.redhat.com/1053544 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 17 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/24155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99c88bbc84e19fef06d54bd25567500b056d6e20 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Reduce redundant vm fetch from db
by masayag＠redhat.com 09 Feb '14

09 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Reduce redundant vm fetch from db ...................................................................... engine: Reduce redundant vm fetch from db There is no justification for fetching vm static when the entire VM entity is already retrieved. Change-Id: Ia0da7c8eee009c49c000e47b88d1f08611877e2c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0da7c8eee009c49c000e47b88d1f08611877e2c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix typo
by masayag＠redhat.com 09 Feb '14

09 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix typo ...................................................................... core: Fix typo Change-Id: I8e4ec0c3a0e8cb2e8b18a8b5b34f9c4f91af0e83 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e4ec0c3a0e8cb2e8b18a8b5b34f9c4f91af0e83 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0