Change in ovirt-engine[master]: webadmin, userportal: Small ScrollableTabBar improvements
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Small ScrollableTabBar improvements
......................................................................
webadmin,userportal: Small ScrollableTabBar improvements
1. ScrollableTabBarView:
- removed "implements HasLoadHandlers"
- removed fireEvent + addLoadHandler methods
- the "+1 width adjustment" comment moved to
appropriate location
2. ModelBoundTab:
- added setAccessible override that fires
TabAccessibleChangeEvent whenever tab's
accessibility changes
Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java
2 files changed, 15 insertions(+), 19 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Looks good to me, but someone else must approve
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23104
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: webadmin, userportal: Use X-UA-Compatible with IE=10
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Use X-UA-Compatible with IE=10
......................................................................
webadmin,userportal: Use X-UA-Compatible with IE=10
This patch is meant to address problems when loading
GWT applications in Internet Explorer 11.
IE11 user agent string is missing the "MSIE" part but
instead includes the "like Gecko" part. For example:
Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv:11.0) like Gecko
This causes GWT selector script (*.nocache.js) to pick
and load Firefox (Gecko) permutation of GWT application.
Since IE11 has issues with Gecko permutation [1], the
workaround is to tell IE11 to render page as IE10:
<meta http-equiv="X-UA-Compatible" content="IE=10">
[1] http://code.google.com/p/google-web-toolkit/issues/detail?id=8228
This shouldn't affect behavior of GWT applications
when loaded in earlier Internet Explorer versions:
- IE8: selector script uses 'ie8' permutation
- IE9: selector script uses 'ie9' permutation
- IE10: selector script uses highest available
permutation ('ie9')
Note: there might be issues with IE10 + 'ie9' GWT
permutation combination. These issues should be
addressed as part of GWT upgrade which should add
proper support (permutation) for IE10.
Change-Id: Ifad89cbd057fc63944a09478ed92e29c13a49e04
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifad89cbd057fc63944a09478ed92e29c13a49e04
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: userportal, webadmin: fixed findbugs error in HelpTagJsonSer...
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: fixed findbugs error in HelpTagJsonServlet
......................................................................
userportal, webadmin: fixed findbugs error in HelpTagJsonServlet
Fixed findbugs error in HelpTagJsonServlet by wrapping the FileInputStream
open in the try (new Java 7 syntax)
Change-Id: Iafa02467e3b54af6254481e16fdcd26c7feab89d
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/HelpTagJsonServlet.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit http://gerrit.ovirt.org/24207
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafa02467e3b54af6254481e16fdcd26c7feab89d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: userportal, webadmin: synchronize grid refresh
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal,webadmin: synchronize grid refresh
......................................................................
userportal,webadmin: synchronize grid refresh
- Updated code to have refresh rates across tabs and sub
tabs be identical. So if you switch the refresh rate on
lets say the VM tab, the same refresh rate is used for
all other tabs. As well as affecting the refresh rate of
the events/alerts and tasks list.
- Fixed duplicate timers being created for EventListModels
and its sub classes.
- Fixed each GridTimer having its own EventBus, which then
didn't actually communicate with the rest of the system.
Now all the GridTimers have the correct EventBus.
Change-Id: I8742785cb9b3d890c39859586b03cd53c64b31e5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879662
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridController.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridTimer.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmMonitorModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java
8 files changed, 147 insertions(+), 72 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8742785cb9b3d890c39859586b03cd53c64b31e5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-log-collector[master]: sos: add sos 3.1 support
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: sos: add sos 3.1 support
......................................................................
sos: add sos 3.1 support
- conditional install sos plugins based on sos version
- use sos-3 plugins if available
- requires sos > 3.1 on RHEL >= 7 and Fedora >= 20;
plugins have been moved on sos upstream.
Change-Id: I47fb7817727ed88a1b9c7bb91cb5055a2e8d7565
Bug-Url: https://bugzilla.redhat.com/1037663
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M .gitignore
M configure.ac
M ovirt-log-collector.spec.in
M src/Makefile.am
M src/__main__.py
M src/sos/plugins/Makefile.am
6 files changed, 78 insertions(+), 23 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23793
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47fb7817727ed88a1b9c7bb91cb5055a2e8d7565
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: webadmin: title overlaps header icon
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: title overlaps header icon
......................................................................
webadmin: title overlaps header icon
- For dialogs with header icons the title would overlap
the icon. This patch fixes the overlap.
Change-Id: I398b5daf8c02734a7b0e9e9777494100ee808d12
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057101
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I398b5daf8c02734a7b0e9e9777494100ee808d12
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: userportal, webadmin: label value title
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal,webadmin: label value title
......................................................................
userportal,webadmin: label value title
- Moved the title code from TextBoxLabel to
TextBoxLabelBase so that all subclasses
also set the title properly when setting the
value.
Change-Id: I3cb524ba13ec9a9f37d5ddcb6b4554293d6ec23d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1061379
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabelBase.java
2 files changed, 20 insertions(+), 15 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, but someone else must approve
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cb524ba13ec9a9f37d5ddcb6b4554293d6ec23d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: userportal: allow links in MOTD
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal: allow links in MOTD
......................................................................
userportal: allow links in MOTD
- Added the ability for admins to add links in the
MOTD in the user portal. These links are checked
for safety before being added into the MOTD.
Change-Id: I6c78c9e6d6dc9417e22c71dab66ae4507ea5c191
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginPopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java
4 files changed, 54 insertions(+), 13 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c78c9e6d6dc9417e22c71dab66ae4507ea5c191
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: core: fix useDnsLookup behavior
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: fix useDnsLookup behavior
......................................................................
core: fix useDnsLookup behavior
This patch fixes the usage of "useDnsLookup" flag
at engine-manage-domains configuration.
only When --ldap-servers is used, this flag should be ignored if set to true.
Change-Id: Ic96e2f9fafcac1e6ba952a198bfb9cecc160ba8b
Bug-Url: https://bugzilla.redhat.com/1062172
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic96e2f9fafcac1e6ba952a198bfb9cecc160ba8b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: restapi : add descriptions to import vm/template SD source/d...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi : add descriptions to import vm/template SD source/destination params in RSDL
......................................................................
restapi : add descriptions to import vm/template SD source/destination params in RSDL
In import vm/template action from cli there is no
description indicating which storagedomain is the
source storagedomain and which one is the destination.
Change-Id: Ie1f5e28d5c3d8047e39c8d3f0fbe95a794c2d9dc
Bug-Url: https://bugzilla.redhat.com/960997
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ravi Nori: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1f5e28d5c3d8047e39c8d3f0fbe95a794c2d9dc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months