February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Disable port mirroring for external networks
by masayag＠redhat.com 04 Feb '14

04 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Disable port mirroring for external networks ...................................................................... webadmin: Disable port mirroring for external networks Operation was blocked by backend, but not mirrored (pun intended) in the GUI. Change-Id: Idafb770e2a96ed8a85e6ef797a7e1a03998e46af Bug-Url: https://bugzilla.redhat.com/1058778 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idafb770e2a96ed8a85e6ef797a7e1a03998e46af Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: [Fix] Add sPAPR VSCSI in the Add Virtual Disk dialog
by iheim＠redhat.com 04 Feb '14

04 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: [Fix] Add sPAPR VSCSI in the Add Virtual Disk dialog ...................................................................... webadmin: [Fix] Add sPAPR VSCSI in the Add Virtual Disk dialog The "Add Virtual Disk" dialog was missing one of the supported disk interfaces, the sPAPR VSCSI. This change adds this type to the drop-down box. Change-Id: I9837e0b18eaccbc70fed8fa45b5671c2e61abee2 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Vitor de Lima: Verified Tal Nisan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9837e0b18eaccbc70fed8fa45b5671c2e61abee2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: fixing typo
by iheim＠redhat.com 04 Feb '14

04 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: fixing typo ...................................................................... webadmin: fixing typo "shceduling" -> "scheduling" Change-Id: I616b711893403f733c6fa7ce8e166657841e4612 Bug-Url: https://bugzilla.redhat.com/1056743 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I616b711893403f733c6fa7ce8e166657841e4612 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Change NIC type from sPAPR VLAN to any other
by masayag＠redhat.com 04 Feb '14

04 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: core: Change NIC type from sPAPR VLAN to any other ...................................................................... core: Change NIC type from sPAPR VLAN to any other After created the VM, added a network interface and have changed its type, the VM cannot be started. Change-Id: Ib7b6f182b90197f8552c3ae21bfc0a0e9b25be9f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1060729 Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7b6f182b90197f8552c3ae21bfc0a0e9b25be9f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix issues with splitter tabs
by awels＠redhat.com 04 Feb '14

04 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix issues with splitter tabs ...................................................................... webadmin: Fix issues with splitter tabs - Fixed issue where if the system tree was minimized the tab to expand would cover the 'new' button of the active main tab. - Fixed issue where the tab of the splitter would show on top of a dialog if the dialog was dragged over it. Change-Id: I151fc3a76d9c6f55e265688fbecf965326774497 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabbedSplitLayout.css 3 files changed, 13 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I151fc3a76d9c6f55e265688fbecf965326774497 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix faulty CDA in AddVmAndCloneImageCommand
by amureini＠redhat.com 04 Feb '14

04 Feb '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix faulty CDA in AddVmAndCloneImageCommand ...................................................................... core: Fix faulty CDA in AddVmAndCloneImageCommand In case super returned true, CDA returned true with no regard to what happens in the for loop. This patch aims to implement to author's original intention while using early return. Change-Id: Ib4e63bf719a9bc98145a6401b05ed47005655486 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/24051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4e63bf719a9bc98145a6401b05ed47005655486 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Exclude read-only disks when creating a snapshot
by amureini＠redhat.com 04 Feb '14

04 Feb '14

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Exclude read-only disks when creating a snapshot ...................................................................... engine: Exclude read-only disks when creating a snapshot Change-Id: Ib05f61e5a61616908bd31aa0fc3ee3e477655e67 Bug-Url: https://bugzilla.redhat.com/1056169 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sergey Gotliv: Verified Allon Mureinik: Looks good to me, approved Vered Volansky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib05f61e5a61616908bd31aa0fc3ee3e477655e67 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Enable DocsServletTest
by awels＠redhat.com 04 Feb '14

04 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: core: Enable DocsServletTest ...................................................................... core: Enable DocsServletTest Removed the @Ignore annotation from DocsServletTest. Since DocsServlet has changed quite a bit since this test was introduced, some of the test methods had to be fixed to handle the different behavior. Where this posed too much work, the methods were simply removed. Change-Id: I6e309b7901cada6739ad53efa6d4b1e9c324950d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/DocsServletTest.java 1 file changed, 3 insertions(+), 43 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/23712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e309b7901cada6739ad53efa6d4b1e9c324950d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixing typo
by oourfali＠redhat.com 04 Feb '14

04 Feb '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: fixing typo ...................................................................... webadmin: fixing typo "shceduling" -> "scheduling" Change-Id: I616b711893403f733c6fa7ce8e166657841e4612 Bug-Url: https://bugzilla.redhat.com/1056743 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I616b711893403f733c6fa7ce8e166657841e4612 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-reports[ovirt-3.3]: reports: fixed misbranded login help item
by ydary＠redhat.com 04 Feb '14

04 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed misbranded login help item ...................................................................... reports: fixed misbranded login help item Change-Id: I35e9e4edfce2c7d41e284779213de34556345817 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M server-customizations/WEB-INF/jsp/modules/login/loginHelp.jsp 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35e9e4edfce2c7d41e284779213de34556345817 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0