Change in ovirt-engine[master]: userportal, webadmin: word wrap login error message
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal,webadmin: word wrap login error message
......................................................................
userportal,webadmin: word wrap login error message
- Fixed issue where if the error message would contain
long words it would not word wrap.
Change-Id: I62c9aae3c37771693548e62615880aa818f2d82a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063818
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.ui.xml
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, but someone else must approve
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24466
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62c9aae3c37771693548e62615880aa818f2d82a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: Use correct storage validation for MoveVM
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Use correct storage validation for MoveVM
......................................................................
core: Use correct storage validation for MoveVM
Fix MoveVMCommand to use the new (correct)
StorageDomainValidator.hasSpaceForClonedDisks(Iterable<DiskImage>) to
validate the destination domain has enough space.
Change-Id: I7f455ff16d11622be4e28ea84180551237a80db1
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Tal Nisan: Looks good to me, but someone else must approve
Daniel Erez: Looks good to me, approved
Sergey Gotliv: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/24027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f455ff16d11622be4e28ea84180551237a80db1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.4]: restapi: add use_latest_template_version to vm restapi
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi: add use_latest_template_version to vm restapi
......................................................................
restapi: add use_latest_template_version to vm restapi
Add the new optional parameter that is relevant for stateless vm creation.
It can be also passed when updating a vm.
By using it, users can select to always create stateless vm based on its
latest version of the used template.
Feature page
http://www.ovirt.org/Features/Template_Versions#REST_API
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1037478
Change-Id: I38b569f7ef6df4d485dac15b804427c8248ab540
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
4 files changed, 79 insertions(+), 15 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38b569f7ef6df4d485dac15b804427c8248ab540
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: restapi: Drop ip--mtu from update host's nic api
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: restapi: Drop ip--mtu from update host's nic api
......................................................................
restapi: Drop ip--mtu from update host's nic api
There mtu is not a property of the IP element.
Also, the update nic api doesn't support updating
the nic's mtu directly.
Change-Id: Iaafd159d6b489458ef8366f29838edf94b1afb28
Bug-Url: https://bugzilla.redhat.com/1049611
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/24917
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaafd159d6b489458ef8366f29838edf94b1afb28
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.4]: restapi: Allow both "type" and "data"
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi: Allow both "type" and "data"
......................................................................
restapi: Allow both "type" and "data"
The "type" and "data" elements used when importing a VM from a
configuration are both allowed and needed, but they are specified as a
XML schema "choice" instead of a "sequence". This patch fixes that.
Change-Id: I6d67b5b14b908c503c1e7d7fffb2a303cc026557
Bug-Url: https://bugzilla.redhat.com/1069522
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 87b1d9acc9c5c1f01512b6b6e58aede9ad04b735)
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Juan Hernandez: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25076
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d67b5b14b908c503c1e7d7fffb2a303cc026557
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: webadmin: Bad vertical alignment in add user screen
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: webadmin: Bad vertical alignment in add user screen
......................................................................
webadmin: Bad vertical alignment in add user screen
When adding a new user, the dropdown box for
selecting the domain and the search box are misaligned
Change-Id: I967023959027f2b977592cf8a6b61952960e24c3
Bug-Url: https://bugzilla.redhat.com/1057109
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml
1 file changed, 14 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Ravi Nori: Verified
--
To view, visit http://gerrit.ovirt.org/24854
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I967023959027f2b977592cf8a6b61952960e24c3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.4]: core : VMs do not appear in virtual machine tab if host is s...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core : VMs do not appear in virtual machine tab if host is selected in side pane
......................................................................
core : VMs do not appear in virtual machine tab if host is selected in side pane
Vms do not appear in 'virtual machine' main tab if host
is selected in webadmin side pane. screen shows empty
(0 item) despite there are large number of vms running
on the host.
Change-Id: I8ac91785cdb8982349c1cd0364b5673d2817f9f2
Bug-Url: https://bugzilla.redhat.com/1063782
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmCrossRefAutoCompleter.java
2 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Ravi Nori: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ac91785cdb8982349c1cd0364b5673d2817f9f2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add host/Reinstall radio button text not actionable
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Add host/Reinstall radio button text not actionable
......................................................................
webadmin: Add host/Reinstall radio button text not actionable
The radio buttons in Add/Reinstall host dialogs to select
between password and SSH Key are not actionable. You can
only click the radio button to change selection but not
the text.
Change-Id: I2baad8ec5f50b7022a348d6ef236691b3feaa804
Bug-Url: https://bugzilla.redhat.com/1035844
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Ravi Nori: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2baad8ec5f50b7022a348d6ef236691b3feaa804
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.4]: engine, webadmin: Edit Approve Host popup -> Cluster not upd...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine, webadmin: Edit Approve Host popup -> Cluster not updated
......................................................................
engine, webadmin: Edit Approve Host popup -> Cluster not updated
The host cluster is not updated in the
"Edit Approve Host" dialog.
For oVirt node the cpu flags is null, so
GetHostArchitectureQuery throws a NPE.
When cpu flags is null, ArchitectureType.unknown
is returned and the webadmin displays all clusters
for data center if unknown is returned.
Change-Id: I4b0357f07de5ac27902ceb250b7ef4c2e1642d08
Bug-Url: https://bugzilla.redhat.com/1056998
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostArchitectureQuery.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Ravi Nori: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b0357f07de5ac27902ceb250b7ef4c2e1642d08
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Fix error if LDAP server cannot be resolved
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Fix error if LDAP server cannot be resolved
......................................................................
tools: Fix error if LDAP server cannot be resolved
Fixes error message in engine-manage-domains if LDAP server cannot be
resolved.
Change-Id: I8a234d08979b97d8695bb3b7afb76e6998b38c87
Bug-Url: https://bugzilla.redhat.com/1001976
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25036
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a234d08979b97d8695bb3b7afb76e6998b38c87
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months