February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: gluster: fix cleaning up orphan tasks
by kmayilsa＠redhat.com 04 Feb '14

04 Feb '14

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: fix cleaning up orphan tasks ...................................................................... gluster: fix cleaning up orphan tasks When there is rebalance task in progress and 'task list' is failed in vdsm for some reason, engine should not cleanup this task and move to UNKNOWN. Change-Id: I4f9bb53e5c2be194efeba966355d0245bcc18384 Bug-Url: https://bugzilla.redhat.com/1060138 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified Sahina Bose: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f9bb53e5c2be194efeba966355d0245bcc18384 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: _commands -> _setup
by ydary＠redhat.com 04 Feb '14

04 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: _commands -> _setup ...................................................................... packaging: setup: _commands -> _setup Probably copied from common. Change-Id: I1f456e0924cc5f3f3e85a185690de4fe10cad1ec Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f456e0924cc5f3f3e85a185690de4fe10cad1ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Validate unsigned short integers correctly
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Validate unsigned short integers correctly ...................................................................... restapi: Validate unsigned short integers correctly Recently, in commit 14e9da, we introduced a validation of integer values provided to the RESTAPI in order to avoid overflows of Java integer types. This validation doesn't work correctly for unsigned short integers, as it compares them to the maximum signed short integer. This has the side effect of rejecting requests that include port numbers greater than 32767. A notable example is the VDSM port number 54321. This patch changes the validation so that it will validate unsigned short integers correctly, comparing them to 65535. Change-Id: I49e64d5f55c32463950e648aa1cd8c3084017da6 Bug-Url: https://bugzilla.redhat.com/1000796 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 2 files changed, 54 insertions(+), 18 deletions(-) Approvals: Ravi Nori: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49e64d5f55c32463950e648aa1cd8c3084017da6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi : ints and shorts overflow
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi : ints and shorts overflow ...................................................................... restapi : ints and shorts overflow int and short values are overflown before they even reach the business code, allowing for wrong values to be set. When posting to rest api, if the value of an int is greater than Integer.MAX_VALUE or value of a short is larger than Short.MAX_VALUE. The values are overflown when values are unmarshalled using JAXB. An excpetion should be raised during JAXB unmarshalling to indicate that the value is greater than the MAX_VALUE for the type. Change-Id: I9d0be6f3f220d7a5f58bb47906a8565d80e0ebf0 Bug-Url: https://bugzilla.redhat.com/1000796 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/InvalidValueException.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/InvalidValueExceptionMapper.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/XmlMessageBodyReader.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 8 files changed, 151 insertions(+), 8 deletions(-) Approvals: Ravi Nori: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d0be6f3f220d7a5f58bb47906a8565d80e0ebf0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: align user instruction for database creation
by ydary＠redhat.com 03 Feb '14

03 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: align user instruction for database creation ...................................................................... packaging: setup: align user instruction for database creation 'create user' -> 'create role' Change-Id: I3e66a39ba7a42402a0a25fce573eecf908a5a3dd Related-To: https://bugzilla.redhat.com/1040572 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e66a39ba7a42402a0a25fce573eecf908a5a3dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: Configurating -> Configuring
by ydary＠redhat.com 03 Feb '14

03 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Configurating -> Configuring ...................................................................... packaging: setup: Configurating -> Configuring Change-Id: I69465d0153339a6907433dc67ac21fb567330133 Related-To: https://bugzilla.redhat.com/1031543 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69465d0153339a6907433dc67ac21fb567330133 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3]: packaging: added release notes
by ydary＠redhat.com 03 Feb '14

03 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added release notes ...................................................................... packaging: added release notes Change-Id: I38b3fafb6edf6ca75ae9ecf48e7ba29ff6943b3e Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh.spec.in 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38b3fafb6edf6ca75ae9ecf48e7ba29ff6943b3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: frontend: Console client page url retrieval
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: frontend: Console client page url retrieval ...................................................................... frontend: Console client page url retrieval Retrieving console client resources page should differentiate between absolute and relative links. Change-Id: Ib8da4313e8fa6bf4a3f170750ab6fab0d21869ea Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Frank Kobzik: Verified Objections: oVirt Jenkins CI Server: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/24010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8da4313e8fa6bf4a3f170750ab6fab0d21869ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix action button regression fix
by awels＠redhat.com 03 Feb '14

03 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix action button regression fix ...................................................................... webadmin: Fix action button regression fix - Fixed certain situations where the previous fix failed to fix the visibility. The original fix didn't take into account the event handler that could change the visibility of an action button. So the original button would be visible then an event would make it invisible, but the flag would not get updated. Causing the fix to not work in certain cases. Change-Id: Ib3c5ccb0a8732b206c94591b930fc6a01456a47d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058214 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java 1 file changed, 15 insertions(+), 15 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3c5ccb0a8732b206c94591b930fc6a01456a47d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: Bumping to 3.3.3 repository
by sbonazzo＠redhat.com 03 Feb '14

03 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Bumping to 3.3.3 repository ...................................................................... Bumping to 3.3.3 repository Change-Id: Ib440135ae373bf84c5fe17e7d5bd79e08525f974 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M el6-ovirt.repo M fedora-ovirt.repo M ovirt-release.spec.in 4 files changed, 11 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib440135ae373bf84c5fe17e7d5bd79e08525f974 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0