February 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: Filter storage domains of different type in live s...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Filter storage domains of different type in live storage migration ...................................................................... webadmin: Filter storage domains of different type in live storage migration This change filters the destination domain by the type of the source domain when performing live storage migration, if the source domain is a file domain, the destination domains that will appear will be only file domains and vice versa Change-Id: I94f9feb9eb2b678e76653bed0b022ed05af40fc1 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml 5 files changed, 49 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94f9feb9eb2b678e76653bed0b022ed05af40fc1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Block live storage migration to domain of a different ...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Block live storage migration to domain of a different type ...................................................................... core: Block live storage migration to domain of a different type This change fails live storage migration CDA part in case that the source storage domain and the destination domain are not both either a file type domain or a block domain Change-Id: Iec4c34132a1a619527627cfa47fa99df3a023b62 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 77 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec4c34132a1a619527627cfa47fa99df3a023b62 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Edit data center dialog chooses shared type as def...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Edit data center dialog chooses shared type as default ...................................................................... webadmin: Edit data center dialog chooses shared type as default When editing a data center, the type combo box was always set to shared regardless of the actual data center type Change-Id: Iaaaf55768a72bc6f3f1349077ee9d54f41aa4995 Bug-Url: https://bugzilla.redhat.com/1057155 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaaf55768a72bc6f3f1349077ee9d54f41aa4995 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Add tests to StorageHandlingCommandBaseTest

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Add tests to StorageHandlingCommandBaseTest ...................................................................... core: Add tests to StorageHandlingCommandBaseTest Since the removal of DC type it's important to have test to test the logic of whether attachment of domains to a pool is allowed, this patch adds tests for the StorageHandlingCommandBase which holds most of the logic that determines attachment is allowed Change-Id: I97e45957f7ff0fe4c9e7d88e0d8dbab7e874c79b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Relates-To: https://bugzilla.redhat.com/1038053 --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CanDoActionTestUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 2 files changed, 212 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97e45957f7ff0fe4c9e7d88e0d8dbab7e874c79b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Fix validate() in EditDiskModel

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix validate() in EditDiskModel ...................................................................... webadmin: Fix validate() in EditDiskModel EditDiskModel validate() called parent validate method but ignored its results. Change-Id: I5df677f42b76b07d489a698978f62bd5df02c415 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Daniel Erez: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/23959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5df677f42b76b07d489a698978f62bd5df02c415 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Remove redundant super.validate() from NewDiskModel

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Remove redundant super.validate() from NewDiskModel ...................................................................... webadmin: Remove redundant super.validate() from NewDiskModel NewDiskModel validate() contained 2 calls to the super.validate() when result of the first call is completely ignored. Change-Id: Id744a08dd74d1536218363f3d9f19cd13cc4c97b Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/23958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id744a08dd74d1536218363f3d9f19cd13cc4c97b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: history: Added is_local_storage to dwh_datacenter_configurat...

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: history: Added is_local_storage to dwh_datacenter_configuration_history_view ...................................................................... history: Added is_local_storage to dwh_datacenter_configuration_history_view This patch adds is_local_storage to dwh_datacenter_configuration_history_view A storage pool can be marked as local - contains local on host storage or shared - contains shared storages of various types. Change-Id: I5100ec6dd030b096f8fa1f644f4e2b8be8916817 Related-To: https://bugzilla.redhat.com/1038053 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5100ec6dd030b096f8fa1f644f4e2b8be8916817 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Hide panels related to Host Network QoS

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Hide panels related to Host Network QoS ...................................................................... webadmin: Hide panels related to Host Network QoS Due to missing capabilities on the VDSM side, this patch hides the GUI elements related to the Host Network QoS feature, effectively making this a "dormant" feature. It does this simply by rendering containing panels invisible for the moment, and should be easily-revertible when the functionality is implemented. Change-Id: Ibd7eb87542dc460ad09615fb850cc0354375d3e3 Bug-Url: https://bugzilla.redhat.com/1043230 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd7eb87542dc460ad09615fb850cc0354375d3e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Don't attach external networks to NIC by label

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Don't attach external networks to NIC by label ...................................................................... webadmin: Don't attach external networks to NIC by label External networks shouldn't be statically attached to a host's interface, neither manually nor by label. Change-Id: I202843bce1635facda3228855e8b2569370e4ed6 Bug-Url: https://bugzilla.redhat.com/1059233 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I202843bce1635facda3228855e8b2569370e4ed6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 2 months

1
0
0 / 0

Change in ovirt-reports[master]: packaging: setup: sync proxy settings with engine

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: sync proxy settings with engine ...................................................................... packaging: setup: sync proxy settings with engine Change-Id: I7bb02d94390d1514aa7fafafe328a4444c773d85 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/ovirt-engine-reports-proxy.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bb02d94390d1514aa7fafafe328a4444c773d85 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

10 years, 2 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits February 2014