February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core: managed removal of memory volumes in negative flows
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: managed removal of memory volumes in negative flows ...................................................................... core: managed removal of memory volumes in negative flows On failure while importing VM or creating snapshot with memory, we need to remove the memory volumes that were copied/created. The remove image operation is asynchronous, i.e it is based on tasks. On negative flows such as the ones mentioned above, we need to remove the memory image in the end-action phase. Since our infrastructure for commands doesn't support scenarios where tasks are created in the end-action phase well, we used to create the tasks for the remove operation without polling them. The problem was that without polling the tasks they remained in VDSM forever. The solution is to invoke the command that removes memory volumes as a stand-alone command, and not as a child of the failed command. It means that the tasks will be created as tasks of RemoveMemoryVolumesCommand and thus its end-action methods will be called and not the ones of the failed command. Change-Id: Ib4b270ec0e1ab41cae34459dde9f9cf47b1b5bdf Bug-Url: https://bugzilla.redhat.com/1056598 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveMemoryVolumesParameters.java 7 files changed, 114 insertions(+), 58 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/23831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4b270ec0e1ab41cae34459dde9f9cf47b1b5bdf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix typo in VdsDeploy
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: fix typo in VdsDeploy ...................................................................... core: fix typo in VdsDeploy Change-Id: I6d5b0784be20e37f95348af33a217dead0fd5ffb Bug-Url: https://bugzilla.redhat.com/1056307 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d5b0784be20e37f95348af33a217dead0fd5ffb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: block virtio-scsi for unsupported OSes
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: block virtio-scsi for unsupported OSes ...................................................................... core: block virtio-scsi for unsupported OSes Block VirtIO-SCSI for unsupported operation systems: * Added isOsTypeSupportedForVirtioScsi method to VmHandler. * Added an appropriate VdcBllMessage. * Modified AddVmCommand and UpdateVmCommand accordingly. * Updated tests. Change-Id: Id9907d35b53c0447662bc638146c4c61ac5cce8a Bug-Url: https://bugzilla.redhat.com/1038613 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 131 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9907d35b53c0447662bc638146c4c61ac5cce8a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: validate disks existence on create snapshot
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: validate disks existence on create snapshot ...................................................................... core: validate disks existence on create snapshot CreateAllSnapshotsFromVmCommand: Added validation for specified disks existence. * Included disks IDs in CanDo message. * Updated tests accordingly. Change-Id: I4d75ad139d048f83b08d9289e43d909b29f89695 Bug-Url: https://bugzilla.redhat.com/1057143 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 86 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d75ad139d048f83b08d9289e43d909b29f89695 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Don't attach external networks to NIC by label
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Don't attach external networks to NIC by label ...................................................................... webadmin: Don't attach external networks to NIC by label External networks shouldn't be statically attached to a host's interface, neither manually nor by label. Change-Id: I202843bce1635facda3228855e8b2569370e4ed6 Bug-Url: https://bugzilla.redhat.com/1059233 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I202843bce1635facda3228855e8b2569370e4ed6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Remove redundant else
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Remove redundant else ...................................................................... core: Remove redundant else There is no use for the else phase since when the if condition is true we already throw an exception. Change-Id: Idb49270dc895dd38752b1d49a070c4e11d891242 Related to Bug-Url: https://bugzilla.redhat.com/1037441 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/23914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb49270dc895dd38752b1d49a070c4e11d891242 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Propagate the exception from VDSM to the user
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Propagate the exception from VDSM to the user ...................................................................... core: Propagate the exception from VDSM to the user Propagate the exception got from VDSM instead replacing it every time. Change-Id: Ief319b187950fe188b54aad240e59cda807c0ef9 Related to Bug-Url: https://bugzilla.redhat.com/1037441 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/23913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief319b187950fe188b54aad240e59cda807c0ef9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Use shorter scope for try catch block
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Use shorter scope for try catch block ...................................................................... core: Use shorter scope for try catch block There is no need to put try catch block on createTask since it is already swallows the exception in CommandBase. Change-Id: Icbdfa7acaac633a1e2010db5fd9fc9afe4fab219 Related to Bug-Url: https://bugzilla.redhat.com/1037441 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java 1 file changed, 13 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/23912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbdfa7acaac633a1e2010db5fd9fc9afe4fab219 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Execute clear tasks with new thread.
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Execute clear tasks with new thread. ...................................................................... core: Execute clear tasks with new thread. clearAsyncTasksWithOutVdsmId is executed at the finally step when executing a vdc command. If the execute phase encountered a problem, the engine sets the transaction to rollback only and we can not use it any more. Since the clearAsyncTasksWithOutVdsmId uses calls to the DB, the engine throws an EJBTransactionRolledbackException, and the original exception does not seep to the user. The proposed solution is to clear the async tasks with a new transaction, so it will not be dependent on the related execute phase. Change-Id: I3434c2dbd605e741b2cfbbede8c4a120f21ca9fe Bug-Url: https://bugzilla.redhat.com/1037441 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 14 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/23911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3434c2dbd605e741b2cfbbede8c4a120f21ca9fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: rewrite
by ydary＠redhat.com 02 Feb '14

02 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: rewrite ...................................................................... packaging: setup: rewrite upgrade from legacy is not supported. Change-Id: I7ba43528b49d39019288819b5a54bf5a0514a677 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M build/python-check.sh.in M ovirt-engine-reports.spec.in D packaging/legacy-setup/common_utils.py D packaging/legacy-setup/decorators.py D packaging/legacy-setup/ovirt-engine-reports-setup.py D packaging/legacy-setup/ssl2jkstrust.py A packaging/setup/ovirt_engine_setup/reportsconfig.py.in A packaging/setup/ovirt_engine_setup/reportsconstants.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/core/misc.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/pgpass.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/db/__init__.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/db/clear.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/jasper/__init__.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/jasper/clear.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/apache/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/apache/reports.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/admin.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jasper.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/sso.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/distro-rpm/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/distro-rpm/packages.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/provisioning/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/provisioning/postgres.py 34 files changed, 3,134 insertions(+), 2,610 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ba43528b49d39019288819b5a54bf5a0514a677 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0