February 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Edit data center dialog chooses shared type as def...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Edit data center dialog chooses shared type as default ...................................................................... webadmin: Edit data center dialog chooses shared type as default When editing a data center, the type combo box was always set to shared regardless of the actual data center type Change-Id: Iaaaf55768a72bc6f3f1349077ee9d54f41aa4995 Bug-Url: https://bugzilla.redhat.com/1057155 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaaf55768a72bc6f3f1349077ee9d54f41aa4995 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: ui: VmInit not setting authorized-keys

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: ui: VmInit not setting authorized-keys ...................................................................... ui: VmInit not setting authorized-keys Change-Id: I5afab0ef140361c23d08a0c5c6eb434eb8597c4c Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5afab0ef140361c23d08a0c5c6eb434eb8597c4c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: ui: vminit set correct style for network checkboxes

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: ui: vminit set correct style for network checkboxes ...................................................................... ui: vminit set correct style for network checkboxes Change-Id: I9ca0e63de515827318b3d76c1539b7b2b754939f Bug-Url: https://bugzilla.redhat.com/1051041 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ca0e63de515827318b3d76c1539b7b2b754939f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-3.3]: sos: engine: don't collect db passwords

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: engine: don't collect db passwords ...................................................................... sos: engine: don't collect db passwords obfuscate sensitive keys in collected configs. avoid to collect legacy empty files. Change-Id: I169d47db602584093210bc4795ff64abc22824fc Bug-Url: https://bugzilla.redhat.com/1060670 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 2122d59b43af58bf72f2e7bc2b614735f9362f24) (cherry picked from commit 0a858e64ed2b4145982e257d8c7802048b7fd2af) --- M src/__main__.py M src/config.py.in.in M src/sos/plugins/engine.py 3 files changed, 72 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I169d47db602584093210bc4795ff64abc22824fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Fix NPEx vulnerabities related to osinfo change

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Fix NPEx vulnerabities related to osinfo change ...................................................................... engine: Fix NPEx vulnerabities related to osinfo change This patch fixes couple of NPEx vulnerabities related to ConsolesBase and OS info in AsyncDataProvider. The vulnerabities happened when changes in osinfo caused invalidity of VMs already stored in the database. The problem was fixed by introducing null checks in appropriate places and a map with the possibility of returning default value if requested key is not found. Change-Id: I04713a90374cac30fd358fdd0fcf02d2a020d477 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1046809 --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/MapWithDefaults.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsolesBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 5 files changed, 74 insertions(+), 31 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/23809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04713a90374cac30fd358fdd0fcf02d2a020d477 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: sos: engine: collect full service configuration

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: engine: collect full service configuration ...................................................................... sos: engine: collect full service configuration Collect also /var/tmp/ovirt-engine/config content. Change-Id: Id41c3859731a77cb2c771d327730c277b81a8c54 Bug-Url: https://bugzilla.redhat.com/1035825 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 4f09866ebf9afd3462d02a0e1d349093bae592b9) --- M src/sos/plugins/engine.py 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id41c3859731a77cb2c771d327730c277b81a8c54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

10 years, 10 months

1
0
0 / 0

Change in ovirt-log-collector[master]: sos: engine: collect full service configuration

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: engine: collect full service configuration ...................................................................... sos: engine: collect full service configuration Collect also /var/tmp/ovirt-engine/config content. Change-Id: Id41c3859731a77cb2c771d327730c277b81a8c54 Bug-Url: https://bugzilla.redhat.com/1035825 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/engine.py 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id41c3859731a77cb2c771d327730c277b81a8c54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <simone.tiraboschi(a)gmail.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: sos: engine: don't collect db passwords

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: engine: don't collect db passwords ...................................................................... sos: engine: don't collect db passwords obfuscate sensitive keys in collected configs. avoid to collect legacy empty files. Change-Id: I169d47db602584093210bc4795ff64abc22824fc Bug-Url: https://bugzilla.redhat.com/1035826 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 2122d59b43af58bf72f2e7bc2b614735f9362f24) --- M src/__main__.py M src/config.py.in.in M src/sos/plugins/engine.py 3 files changed, 72 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I169d47db602584093210bc4795ff64abc22824fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: setup: distro-rpm: fix typo in new package detection

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: distro-rpm: fix typo in new package detection ...................................................................... packaging: setup: distro-rpm: fix typo in new package detection Change-Id: Ibb2aa3ce1f1d9f0d4c5b250e0f70cbe22e931b71 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb2aa3ce1f1d9f0d4c5b250e0f70cbe22e931b71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: 'concurrent' Not Displayed For Primary PM Agent

by oliel＠redhat.com

Ori Liel has submitted this change and it was merged. Change subject: restapi: 'concurrent' Not Displayed For Primary PM Agent ...................................................................... restapi: 'concurrent' Not Displayed For Primary PM Agent When there's more than one Power-Management agents, the field 'concurrent' becomes relevant. Prior to this fix, this field would only exist in the secondary agent. After this fix, this field will also exist in the first agent Change-Id: If0882d1db6c13b24c767e0cb40b9b797e8b61860 Bug-Url: http://bugzilla.redhat.com/977674 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0882d1db6c13b24c767e0cb40b9b797e8b61860 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits February 2014