March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: engine: Can't add user without system level admin permission
by oourfali＠redhat.com 23 Mar '14

23 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Can't add user without system level admin permission ...................................................................... engine: Can't add user without system level admin permission This patch fixes a regression introduced at Ib62e1c051bc78b8a9ec0f32e6ba4eb9484242591 1. Introducing a new permission of adding non existing users - this is required, as the other options are: a. Using the existing "manipulate users" permission - this will cause a regression, allowing roles to add users directly without the need to use the add permissions dialogs. b. Removing the permission check for non existing users/groups - this will break https://bugzilla.redhat.com/923100 2. The new permission is added to all the roles that have manipulate permissions manipulation - this is done in order to fix the above regression. Change-Id: I308f9cc5edb53b9633d768fd3d382dc9cf62031c Bug-Url: https://bugzilla.redhat.com/1070651 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties A packaging/dbscripts/upgrade/03_04_0700_add_missing_manipulate_users_permissions.sql 9 files changed, 44 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/25482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I308f9cc5edb53b9633d768fd3d382dc9cf62031c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: Use the new ovirt-hosted-engine-ha Backend API for lockspace...
by sbonazzo＠redhat.com 21 Mar '14

21 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Use the new ovirt-hosted-engine-ha Backend API for lockspace init ...................................................................... Use the new ovirt-hosted-engine-ha Backend API for lockspace init ovirt-hosted-engine-ha unified the API for creating and accessing the metadata and lockspace files. This patch removes the code duplication between setup and ha using the API. Change-Id: I4ca5539aa45742eb99577a5c91200fdadf555a11 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067162 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py 2 files changed, 52 insertions(+), 84 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/25897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ca5539aa45742eb99577a5c91200fdadf555a11 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Add brokerlink tests to Makefile.am
by msivak＠redhat.com 21 Mar '14

21 Mar '14

Martin Sivák has submitted this change and it was merged. Change subject: Add brokerlink tests to Makefile.am ...................................................................... Add brokerlink tests to Makefile.am Change-Id: I891bf475313a42d8a1747b633e09547d726eae0e Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I891bf475313a42d8a1747b633e09547d726eae0e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Update the services to use the new storage backend classes
by msivak＠redhat.com 21 Mar '14

21 Mar '14

Martin Sivák has submitted this change and it was merged. Change subject: Update the services to use the new storage backend classes ...................................................................... Update the services to use the new storage backend classes Agent no longer cares about the exact filesystem path. It only selects the proper metadata backend (fs or block) and passes the necessary arguments for the constructor using the set_storage_domain call. The broker associates the storage domain with the agent's connection and uses it automatically to process all requests by this agent connection. This allows us to have multiple agents with separate storage domains in the future. If the actual path to the device/file is still needed then the broker will return it from a new get_service_path call. The default configuration for now is fs based backend (NFS, iSCSI or Gluster). The api of client.get_*_direct methods changes to use the uuid and storage domain type so the path computation is done only on single place. Change-Id: I0ad1567c53af561e918be69b8f1b33f75b77fc05 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/broker/listener.py M ovirt_hosted_engine_ha/broker/storage_broker.py M ovirt_hosted_engine_ha/client/client.py M ovirt_hosted_engine_ha/lib/brokerlink.py 6 files changed, 174 insertions(+), 63 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ad1567c53af561e918be69b8f1b33f75b77fc05 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Encapsulate the storage metadata and add support for blockSD
by msivak＠redhat.com 21 Mar '14

21 Mar '14

Martin Sivák has submitted this change and it was merged. Change subject: Encapsulate the storage metadata and add support for blockSD ...................................................................... Encapsulate the storage metadata and add support for blockSD This creates an encapsulation class that is responsible for creation and usage of storage metadata directory. It allows to specify arbitrary number of services and then initializes the proper files and mappings for the broker to use them. The example usage is: b = FilesystemBackend("uuid-of-the-storage-domain", "nfs") b.create({ "hosted-engine.lockspace": 1048576, "hosted-engine.metadata": 1048576 }) b.connect() Supported storage types are: nfs, block and glusterfs The type serves only as a hint, the storage domain has to exist and be already connected for the above to work. The class does autodetection of the SD type in all cases except glusterSD. To force a clean metadata files pass force_new=True argument to the create call. Change-Id: Iaced4ac08936fc9314ff821343ce33d29a5897cf Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in M ovirt_hosted_engine_ha/env/constants.py.in M ovirt_hosted_engine_ha/lib/Makefile.am A ovirt_hosted_engine_ha/lib/storage_backends.py A ovirt_hosted_engine_ha/lib/storage_backends_test.py 5 files changed, 351 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaced4ac08936fc9314ff821343ce33d29a5897cf Gerrit-PatchSet: 9 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Add metadata storage support for raw block device
by msivak＠redhat.com 21 Mar '14

21 Mar '14

Martin Sivák has submitted this change and it was merged. Change subject: Add metadata storage support for raw block device ...................................................................... Add metadata storage support for raw block device This adds support for using raw partition or drive as the metadata storage device. It implements partitioning schema to support multiple metadata files and also allows for future extension. Once the backend is connected to, it uses device mapper interface to create the devices for all registered metadata files. The underlying block device uses the following block based structure. The first block on the device is meta block. Each meta block (512B) contains: 4B signature (HEs0) 8B index of next meta block or 0 if this is the last one 64 bytes with service name (first byte equals the used length) 8B + 8B pointers to data section (start block, length) ... more data sections if needed 16B of 0 acting as a sentinel 4B CRC32 checksum If there is need to use lots of data sections for a single service, is is possible tp use the service name multiple times and the data blocks will be concatenated using device mapper. Change-Id: Id6ab21fb2075fc59b444b5754ade8a1569b83b18 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_backends.py M ovirt_hosted_engine_ha/lib/storage_backends_test.py 2 files changed, 511 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6ab21fb2075fc59b444b5754ade8a1569b83b18 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: upgrade-check branding support
by sbonazzo＠redhat.com 21 Mar '14

21 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: upgrade-check branding support ...................................................................... packaging: upgrade-check branding support Added branding support to ovirt-engine-upgrade-check Change-Id: I9e44cad12a27106c94610d9084b89e6bf1b8dae5 Bug-Url: https://bugzilla.redhat.com/1078955 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/bin/ovirt-engine-upgrade-check 1 file changed, 78 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e44cad12a27106c94610d9084b89e6bf1b8dae5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.1]: Providing details about the required free space
by sbonazzo＠redhat.com 21 Mar '14

21 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Providing details about the required free space ...................................................................... Providing details about the required free space Adding a more meaningful text to better explain how much free disk space you need to proceed Change-Id: Iab06eeb467b6003a27bbe3566f0d64336f9d0728 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077150 (cherry picked from commit 103e2c5443722bdfe23a0db6fbc808f38796442d) --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/25972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab06eeb467b6003a27bbe3566f0d64336f9d0728 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: Providing details about the required free space
by sbonazzo＠redhat.com 21 Mar '14

21 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Providing details about the required free space ...................................................................... Providing details about the required free space Adding a more meaningful text to better explain how much free disk space you need to proceed Change-Id: Iab06eeb467b6003a27bbe3566f0d64336f9d0728 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077150 --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab06eeb467b6003a27bbe3566f0d64336f9d0728 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: update otopi, ovirt-host-deploy dependencies
by sbonazzo＠redhat.com 21 Mar '14

21 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: update otopi, ovirt-host-deploy dependencies ...................................................................... packaging: update otopi, ovirt-host-deploy dependencies Change-Id: I178a9874a329165efd958adabd94c3982d18a573 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I178a9874a329165efd958adabd94c3982d18a573 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0