March 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: Fix bug in a add floating disk

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix bug in a add floating disk ...................................................................... webadmin: Fix bug in a add floating disk Change-Id: Ie354b70ca88374cc054f84d7a3488742cb65727d Bug-Url: https://bugzilla.redhat.com/1079741 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie354b70ca88374cc054f84d7a3488742cb65727d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: Collect stats before activating host

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Collect stats before activating host ...................................................................... engine: Collect stats before activating host When the host moves to non operational due to a required interface in down state, the host statistics should be collected and examined before attempting to activate the host. Change-Id: Id3de8a3ccb1084f8be8f9c3213f797146f8f0b36 Bug-Url: https://bugzilla.redhat.com/1070260 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java 3 files changed, 17 insertions(+), 16 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Roy Golan: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3de8a3ccb1084f8be8f9c3213f797146f8f0b36 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: Set SinglePCI to false when importing VNC display

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: engine: Set SinglePCI to false when importing VNC display ...................................................................... engine: Set SinglePCI to false when importing VNC display When importing VM the OVF reader (which read from the export domain) need additional check to remove the default SinglePCI for VNC display. Bug-Url: https://bugzilla.redhat.com/1075294 Change-Id: I39c4d1dd45f3fa91b5fe3f0a7e786a26eb66fb29 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39c4d1dd45f3fa91b5fe3f0a7e786a26eb66fb29 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: unknown host name when listing jobs

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: core: unknown host name when listing jobs ...................................................................... core: unknown host name when listing jobs Change-Id: I3754902fdf9e9bdb5de0f6797901adbae6792ee1 https://bugzilla.redhat.com/1055710 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3754902fdf9e9bdb5de0f6797901adbae6792ee1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: Use List.addAll() instead of iteration

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Use List.addAll() instead of iteration ...................................................................... core: Use List.addAll() instead of iteration Change-Id: I0e1e562734e1ebc341a3ad96cc104aff649087aa Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStatsVDSCommand.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/25793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e1e562734e1ebc341a3ad96cc104aff649087aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: last ovf store update

by laravot＠redhat.com

Liron Ar has submitted this change and it was merged. Change subject: core: last ovf store update ...................................................................... core: last ovf store update In a case in which the last ovf store was previously updated, we should attempt to update it only if update to any of the previous domains was succesfull. Otherwise, we can attempt to update it immediately as it doesn't contain any ovf data so there's no point to consider the other updates results. Change-Id: I21491330681c333faf9e97b3d348d2af8c2b2fb5 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21491330681c333faf9e97b3d348d2af8c2b2fb5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: osinfo - fix 2008 sysprep index type

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: core: osinfo - fix 2008 sysprep index type ...................................................................... core: osinfo - fix 2008 sysprep index type 1.sypsrep index for 2008 an onward is String now 2.dump the osinfo internals to debug log now (enable debug on org.ovirt.engine.core.utils) output example: os.rhel_6.derivedFrom value=rhel_5 os.rhel_6.devices.audio value=ich6 os.rhel_6.devices.diskInterfaces value.3.3=IDE, VirtIO_SCSI, VirtIO value.3.4=IDE, VirtIO_SCSI, VirtIO os.rhel_6.id value=18 os.rhel_6.name value=Red Hat Enterprise Linux 6.x Bug-Url: https://bugzilla.redhat.com/1069096 Change-Id: I28898444de5da404bc8fb20cd2fa134e6ff6d83f Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java M packaging/conf/osinfo-defaults.properties 3 files changed, 51 insertions(+), 3 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28898444de5da404bc8fb20cd2fa134e6ff6d83f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: better message on import template version

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: better message on import template version ...................................................................... core: better message on import template version when trying to add a template version, which its base template is missing, the message you get is not clear. in this patch a better message provided. Change-Id: I9fbf2c45c03fe9838bf25be5529c93c322372b28 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073035 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 8 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fbf2c45c03fe9838bf25be5529c93c322372b28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: fixing taskcleaner.sh utility help

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing taskcleaner.sh utility help ...................................................................... core: fixing taskcleaner.sh utility help This patch fixes the -R option description to note that all tasks will be removed unless also the -z option is given. Change-Id: If139423d1158060b00d0c205bc94608a06e1572c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1079469 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If139423d1158060b00d0c205bc94608a06e1572c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: ux: allow using password authentication on foreman hosts

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: ux: allow using password authentication on foreman hosts ...................................................................... ux: allow using password authentication on foreman hosts Previous patch removed the ability to use password authentication with external hosts provided by Foreman. This patch fixes that issue by hiding this option only when installation relevant properties are to be hidden. Change-Id: I26e351f0560ac4fe8f45ec2314ef4a6aa7ddafb9 Bug-Url: https://bugzilla.redhat.com/1079072 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26e351f0560ac4fe8f45ec2314ef4a6aa7ddafb9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits March 2014