March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine, webadmin: Re-work engine ovirt-node host-deploy sequ...
by yzaslavs＠redhat.com 21 Mar '14

21 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine, webadmin: Re-work engine ovirt-node host-deploy sequence ...................................................................... engine, webadmin: Re-work engine ovirt-node host-deploy sequence The current host deploy sequence does not let the oVirt node to be redeployed, it can only be upgraded. Split the back end InstallVdsCommand into two commands, InstallVds and UpdateVdsCommand. InstallVds is used to redeploy host and UpdateVdsCommand is used to upgrade oVirtNode. Change-Id: I7a897581e2b75f7cdc57db40418504a79b9d2787 Bug-Url: https://bugzilla.redhat.com/989546 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java C backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/InstallVdsInternalCommandTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java A packaging/dbscripts/upgrade/03_05_0140_add_install_vds_upgrade_ovirt_node_action_group.sql 17 files changed, 729 insertions(+), 470 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a897581e2b75f7cdc57db40418504a79b9d2787 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: update the committed memory properly
by oourfali＠redhat.com 20 Mar '14

20 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: update the committed memory properly ...................................................................... core: update the committed memory properly The computation of the committed memory was wrong because it included VMs which are down as well. The problem was that we were iterating the wrong collections of VMs, we should iterate over the VMs which we got back from VDSM and take only them into consideration. Change-Id: I04be4ca80456ffbf47af2f883a33672166c25cb6 Bug-Url: https://bugzilla.redhat.com/1074478 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/25948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04be4ca80456ffbf47af2f883a33672166c25cb6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: allow snapshots for read-only disks
by oourfali＠redhat.com 20 Mar '14

20 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: allow snapshots for read-only disks ...................................................................... core: allow snapshots for read-only disks Allow snapshots for read-only disks (modified 'DiskImageBase -> isAllowSnapshot' accordingly). Change-Id: Ic832544d2d520841abe1f20d0a9a724535481218 Bug-Url: https://bugzilla.redhat.com/1072471 Bug-Url: https://bugzilla.redhat.com/1072529 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic832544d2d520841abe1f20d0a9a724535481218 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add new role permission drop below the end of the ...
by oourfali＠redhat.com 20 Mar '14

20 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Add new role permission drop below the end of the screen ...................................................................... webadmin: Add new role permission drop below the end of the screen When creating a new role, the permission tree ends below the lower border of the screen when the entire tree is expanded Change-Id: I6f785d91c8bc10b0ceb44ed153237e5f62590b76 Bug-Url: https://bugzilla.redhat.com/1057103 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml 1 file changed, 21 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f785d91c8bc10b0ceb44ed153237e5f62590b76 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: update the committed memory properly
by oourfali＠redhat.com 20 Mar '14

20 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: update the committed memory properly ...................................................................... core: update the committed memory properly The computation of the committed memory was wrong because it included VMs which are down as well. The problem was that we were iterating the wrong collections of VMs, we should iterate over the VMs which we got back from VDSM and take only them into consideration. Change-Id: I04be4ca80456ffbf47af2f883a33672166c25cb6 Bug-Url: https://bugzilla.redhat.com/1078553 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/25953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04be4ca80456ffbf47af2f883a33672166c25cb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: NetworkDaoTest - Add @Test annotation on 2 forgotten...
by masayag＠redhat.com 20 Mar '14

20 Mar '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: NetworkDaoTest - Add @Test annotation on 2 forgotten test methods ...................................................................... engine: NetworkDaoTest - Add @Test annotation on 2 forgotten test methods Change-Id: I49e39aeb160a908e5a9d26a1eabbc230b5f747af Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/25954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49e39aeb160a908e5a9d26a1eabbc230b5f747af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: update the committed memory properly
by ahadas＠redhat.com 20 Mar '14

20 Mar '14

Arik Hadas has submitted this change and it was merged. Change subject: core: update the committed memory properly ...................................................................... core: update the committed memory properly The computation of the committed memory was wrong because it included VMs which are down as well. The problem was that we were iterating the wrong collections of VMs, we should iterate over the VMs which we got back from VDSM and take only them into consideration. Change-Id: I04be4ca80456ffbf47af2f883a33672166c25cb6 Bug-Url: https://bugzilla.redhat.com/1078553 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/25943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04be4ca80456ffbf47af2f883a33672166c25cb6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Fix syntax error in ovirt-engine.xml.in
by sbonazzo＠redhat.com 20 Mar '14

20 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Fix syntax error in ovirt-engine.xml.in ...................................................................... packaging: Fix syntax error in ovirt-engine.xml.in Fix misplaced '/' introduced in 48e5a00edb3201f6a2304697fb393031f85e7d91 Change-Id: I6e7edc59bdbe8dcc3c1e1fa533cd29f62d50695e Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/25945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e7edc59bdbe8dcc3c1e1fa533cd29f62d50695e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Generate answer file at cleanup
by oourfali＠redhat.com 20 Mar '14

20 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: Generate answer file at cleanup ...................................................................... packaging: setup: Generate answer file at cleanup Generate answer file at end of stage Cleanup instead of stage Closeup. Stage Cleanup is always executed at the end of the run, so the answer file will always be generated - even if e.g. user chooses 'Cancel' at the end of "CONFIGURATION PREVIEW", or presses ^C at any point. Change-Id: I4b6af75001eb3192e6839e57dbb7446344ff29f4 Bug-Url: https://bugzilla.redhat.com/1077114 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/core/answerfile.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/25785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b6af75001eb3192e6839e57dbb7446344ff29f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Do not show domain name for groups
by oourfali＠redhat.com 20 Mar '14

20 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Do not show domain name for groups ...................................................................... core: Do not show domain name for groups The UI show user name for group, which is just its domain name. This patch solves this issue. Change-Id: Ife3bf9e19862ae0cc4462375032a24c62f44b6dc Bug-Url: https://bugzilla.redhat.com/1072918 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/25766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife3bf9e19862ae0cc4462375032a24c62f44b6dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0