Change in ovirt-reports[master]: reports: edited ic query-all_dcs_with_hosts
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: edited ic query-all_dcs_with_hosts
......................................................................
reports: edited ic query-all_dcs_with_hosts
I edited the, all_dcs_with_hosts, input control query,
so it will be more readable and added comments.
Change-Id: I6706327855fd424bc4fae8f54ed7325ddd0bfacd
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_hosts/P_DataCenter_ID.xml
1 file changed, 227 insertions(+), 88 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25262
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6706327855fd424bc4fae8f54ed7325ddd0bfacd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 9 months
Change in ovirt-reports[master]: reports: edited ic query-only_hosts_host_name
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: edited ic query-only_hosts_host_name
......................................................................
reports: edited ic query-only_hosts_host_name
I edited the, only_hosts_host_name, input control query,
so it will be more readable and added comments.
Change-Id: Ic4728a093e7de4f93911e4bc1e6fe1af4e09282e
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Hosts/P_Host_ID.xml
1 file changed, 94 insertions(+), 33 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25371
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4728a093e7de4f93911e4bc1e6fe1af4e09282e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 9 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Removing the use of getDisks from RestoreCommand
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Removing the use of getDisks from RestoreCommand
......................................................................
core: Removing the use of getDisks from RestoreCommand
There is no place that initializes the disks in the
parameter class when RestoreAllSnapshot is called.
Since there is no use of it whatsoever, this patch removes the use of
it in the command, so we can decouple RestoreAllSnapshotsParameters from
TryBackToAllSnapshotsOfVmParameters
Change-Id: I1d0f5f92288ea92c114526e0d7d567a7ece45fbd
Bug-Url: https://bugzilla.redhat.com/867339
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/25689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d0f5f92288ea92c114526e0d7d567a7ece45fbd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Extract method of snapshot id.
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Extract method of snapshot id.
......................................................................
core: Extract method of snapshot id.
Extracting a new method to get the snapshot id instead of
working directly with the parameters command.
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/867339
Change-Id: I4754e381d70f08a9650596a4eeb3de296b3cb44f
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
1 file changed, 14 insertions(+), 11 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/25688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4754e381d70f08a9650596a4eeb3de296b3cb44f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-engine[master]: core: Fix KeystoneAuthUrl example's description
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Fix KeystoneAuthUrl example's description
......................................................................
core: Fix KeystoneAuthUrl example's description
The example of KeystoneAuthUrl should include the version.
Change-Id: I387a15e66e8a45b52c9189253ac7b5898e9b2a75
Bug-Url: https://bugzilla.redhat.com/1075997
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M packaging/etc/engine-config/engine-config.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25730
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I387a15e66e8a45b52c9189253ac7b5898e9b2a75
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 9 months
Change in ovirt-reports[master]: reports: edited ic query-all_dcs_with_entities
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: edited ic query-all_dcs_with_entities
......................................................................
reports: edited ic query-all_dcs_with_entities
I edited the, all_dcs_with_entities, input control query,
so it will be more readable and added comments.
Change-Id: Ief87a0c632215108649a68f8f410055b4f371384
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_entities/P_DataCenter_ID.xml
1 file changed, 329 insertions(+), 132 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief87a0c632215108649a68f8f410055b4f371384
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 9 months
Change in ovirt-reports[master]: reports: edited ic query-all_dcs_with_storage
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: edited ic query-all_dcs_with_storage
......................................................................
reports: edited ic query-all_dcs_with_storage
I edited the, all_dcs_with_storage, input control query,
so it will be more readable and added comments.
Change-Id: Ib493194b999faf7d8f371a12c06a357ce8ab6b0e
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_storage/P_DataCenter_ID.xml
1 file changed, 222 insertions(+), 84 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25278
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib493194b999faf7d8f371a12c06a357ce8ab6b0e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 9 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Show a warning on import storage dialog when impor...
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Show a warning on import storage dialog when import is not possible
......................................................................
webadmin: Show a warning on import storage dialog when import is not possible
In the import storage dialog when selecting a data center that already has
an ISO and an export domain attach there is nothing to import and the
selectboxes are empty, this patch adds a warning icon with a title that
explains why the boxes are empty and no import can be dome
Change-Id: Icb8c8a786adb0cabc8dd2aa367531c319f712d9f
Bug-Url: https://bugzilla.redhat.com/1063288
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb8c8a786adb0cabc8dd2aa367531c319f712d9f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: disable hot plug for disk with IDE interface
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: disable hot plug for disk with IDE interface
......................................................................
webadmin: disable hot plug for disk with IDE interface
New disk dialog:
when the VM is running and IDE is selected,
'Activate' should be disabled.
Change-Id: Iff166bfdae2e7bcdd56c5e4e5311f878138c260a
Bug-Url: https://bugzilla.redhat.com/1055403
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 20 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/25697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff166bfdae2e7bcdd56c5e4e5311f878138c260a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: custom snapshot preview - default disks selection
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: custom snapshot preview - default disks selection
......................................................................
webadmin: custom snapshot preview - default disks selection
Custom snapshot dialog:
if a partial snapshot has been pre-selected, the missing disks
should be selected on the active snapshot by default.
Change-Id: I78c1c11802c72c8eef91a25905078ce309dd03ea
Bug-Url: https://bugzilla.redhat.com/1071791
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PreviewSnapshotModel.java
1 file changed, 16 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/25696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78c1c11802c72c8eef91a25905078ce309dd03ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months