March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Relaxed slave interface validation
by lvernia＠redhat.com 10 Mar '14

10 Mar '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Relaxed slave interface validation ...................................................................... engine: Relaxed slave interface validation Validation used to demand that no boot protocol, IP address etc. be defined on the slave interfaces, whereas this seems to be quite common when using Fedora 19 hosts. This is erased by VDSM anyway, so there's no real reason to block this on the engine side. Change-Id: I564325fd0ac0cf54d2bff7c155a7a67f32507711 Bug-Url: https://bugzilla.redhat.com/1051297 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I564325fd0ac0cf54d2bff7c155a7a67f32507711 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused member
by amureini＠redhat.com 10 Mar '14

10 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused member ...................................................................... core: Remove unused member Removed RestoreAllSnapshotCommandTest.dstSnaphotId, which is no longer in use. Change-Id: I62cf32636bbb5164272793a85bf6dcb54a62b0fb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/25565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62cf32636bbb5164272793a85bf6dcb54a62b0fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: sos: added ovirt_engine_dwh sos plugin
by sbonazzo＠redhat.com 10 Mar '14

10 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: added ovirt_engine_dwh sos plugin ...................................................................... sos: added ovirt_engine_dwh sos plugin Change-Id: I7bd3d5a949c49b2fe918479547390d2c3a2cb62c Bug-Url: https://bugzilla.redhat.com/1074460 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/config.py.in.in M src/sos/plugins/Makefile.am A src/sos/plugins/ovirt_engine_dwh.py 4 files changed, 111 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bd3d5a949c49b2fe918479547390d2c3a2cb62c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomáš Došek <tdosek(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: engine: Fix script number
by sbonazzo＠redhat.com 10 Mar '14

10 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: engine: Fix script number ...................................................................... engine: Fix script number Change-Id: I43b25ebf805477f0ffb9571f12962f5a98d3234d Bug-Url: https://bugzilla.redhat.com/1072501 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- R packaging/dbscripts/upgrade/03_04_0660_delete_network_labels_action_groups.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43b25ebf805477f0ffb9571f12962f5a98d3234d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: webadmin: [Fix] Template without migration downtime
by sbonazzo＠redhat.com 10 Mar '14

10 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: webadmin: [Fix] Template without migration downtime ...................................................................... webadmin: [Fix] Template without migration downtime Template is created with no default value for migration downtime, the screen does not close, it requires data. Change-Id: I478ad01793a9ff22f18d22eb775527252a2ca4b4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066617 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/25558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I478ad01793a9ff22f18d22eb775527252a2ca4b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>

1 0

Change in ovirt-live[master]: ovirt-live : adapt to new repository layout
by obasan＠redhat.com 10 Mar '14

10 Mar '14

Ohad Basan has submitted this change and it was merged. Change subject: ovirt-live : adapt to new repository layout ...................................................................... ovirt-live : adapt to new repository layout Change-Id: Ida988f988ae6231fc3d77e7bd4c03fcb56928007 --- M centos/kickstart/ovirt-live-base.ks.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Kiril Nesenko: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve Ohad Basan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida988f988ae6231fc3d77e7bd4c03fcb56928007 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Show a warning on import storage dialog when impor...
by tnisan＠redhat.com 10 Mar '14

10 Mar '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Show a warning on import storage dialog when import is not possible ...................................................................... webadmin: Show a warning on import storage dialog when import is not possible In the import storage dialog when selecting a data center that already has an ISO and an export domain attach there is nothing to import and the selectboxes are empty, this patch adds a warning icon with a title that explains why the boxes are empty and no import can be dome Change-Id: Icb8c8a786adb0cabc8dd2aa367531c319f712d9f Bug-Url: https://bugzilla.redhat.com/1063288 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb8c8a786adb0cabc8dd2aa367531c319f712d9f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Use predefined ISO domains list in import storage ...
by tnisan＠redhat.com 10 Mar '14

10 Mar '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Use predefined ISO domains list in import storage domain dialog ...................................................................... webadmin: Use predefined ISO domains list in import storage domain dialog Change-Id: Ibdf777e808a2cfb49c08d9209d27b3b85943581d Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Related-To: https://bugzilla.redhat.com/1063288 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdf777e808a2cfb49c08d9209d27b3b85943581d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: packaging: ovirt-release-11.1.0
by sbonazzo＠redhat.com 10 Mar '14

10 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: ovirt-release-11.1.0 ...................................................................... packaging: ovirt-release-11.1.0 - Splitted nightly builds in separate ovirt-nightly.repo file. - Added ovirt-3.4-stable and ovirt-3.3-stable repositories. - Dropped beta and updates testing in favor of ovirt-3.3-prerelease. Change-Id: I9484b43935730050723b7fde74873edd36847739 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M Makefile.am M configure.ac A ovirt-nightly.repo.in M ovirt-release.spec.in M ovirt.repo.in 5 files changed, 92 insertions(+), 59 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9484b43935730050723b7fde74873edd36847739 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix subnet format error message
by iheim＠redhat.com 10 Mar '14

10 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Fix subnet format error message ...................................................................... webadmin: Fix subnet format error message Previous message talked of "IP address", now of subnet. Change-Id: I105493febb618cbd0e9bb20991e064cb9c81c428 Bug-Url: https://bugzilla.redhat.com/1062603 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IpAddressValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/SubnetMaskValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 11 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/25433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I105493febb618cbd0e9bb20991e064cb9c81c428 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0