Change in ovirt-engine[master]: restapi: add support to regenerate ids when adding vm from c...
by mishka8520@yahoo.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: add support to regenerate ids when adding vm from configuration
......................................................................
restapi: add support to regenerate ids when adding vm from configuration
This patch adds support to regenerate new ids when adding a vm from
the configuration. This is done so that the vm could be still added from
a provided configuration even if the "original" vm still exists.
Change-Id: I9ccf0f61b58ad49aa50d1efe3aa0b9a8bd31da70
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
4 files changed, 103 insertions(+), 40 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22207
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ccf0f61b58ad49aa50d1efe3aa0b9a8bd31da70
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juana Garcia <garciajuana81(a)gmail.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-engine[master]: webadmin: Labeled Networks with vlan shown outside the label...
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Labeled Networks with vlan shown outside the label group
......................................................................
webadmin: Labeled Networks with vlan shown outside the label group
Due to a bug (the claculation of the nic labels was done for all the nics
and not just the physical nic), in setup networks dialog labeled networks
with vlan were attached to the correct nic but were outside the label
group.
Change-Id: Iefbe55854ac5b4cad6c8ab79b93edf5500fb0a81
Bug-Url: https://bugzilla.redhat.com/1067928
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
1 file changed, 33 insertions(+), 34 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25477
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefbe55854ac5b4cad6c8ab79b93edf5500fb0a81
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-engine[master]: engine: Make test connectivity non transactional
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Make test connectivity non transactional
......................................................................
engine: Make test connectivity non transactional
No reason for this command to be transactional as it doesn't alter the
DB.
Change-Id: I7423f4089d937f3094bf6054818390c3f26b1d9a
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/TestProviderConnectivityCommand.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Mike Kolesnik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25479
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7423f4089d937f3094bf6054818390c3f26b1d9a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-dwh[ovirt-3.3]: packaging: setup: check service status by rc
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: check service status by rc
......................................................................
packaging: setup: check service status by rc
Before this change, the status of services was checked by searching for
keywords in the output of 'service $service status'. This didn't work
well on locales where the output did not contain the expected keywords.
With this change we only check the return code of that command.
Bug-Url: https://bugzilla.redhat.com/1067673
Change-Id: I306dfb6cf069c26a59e1d9a0d4678a1888300784
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/common_utils.py
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25455
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I306dfb6cf069c26a59e1d9a0d4678a1888300784
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 9 months
Change in ovirt-engine[master]: history: No history data for unbounded host interfaces
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: history: No history data for unbounded host interfaces
......................................................................
history: No history data for unbounded host interfaces
The dwh_host_interface_configuration_history_view missed to include
host interfaces in vds_interface whose is_bound field is false.
Change-Id: I44fe7c0edbf1429f0bf513459cf9dff10f6f9395
Bug-Url: https://bugzilla.redhat.com/1069605
Signed-off-by: plysan <plysab(a)gmail.com>
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M packaging/dbscripts/create_dwh_views.sql
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
plysan: Looks good to me, but someone else must approve
Yaniv Dary: Verified
--
To view, visit http://gerrit.ovirt.org/25017
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44fe7c0edbf1429f0bf513459cf9dff10f6f9395
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: plysan <plysab(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: LiJiansheng <lijiangsheng1(a)gmail.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: plysan <plysab(a)gmail.com>
10 years, 9 months
Change in ovirt-reports[master]: packaging: setup: database: align manual instructions with d...
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: database: align manual instructions with defaults
......................................................................
packaging: setup: database: align manual instructions with defaults
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067548
Change-Id: I3bc5329aff8898f406eb02f3544e165b115ea9b4
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25513
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bc5329aff8898f406eb02f3544e165b115ea9b4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 9 months
Change in ovirt-engine[master]: engine: SetupNetworks rollback error message
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: SetupNetworks rollback error message
......................................................................
engine: SetupNetworks rollback error message
Adding a message for a failed setup networks command
which was invoked with 'check connectivity'.
Change-Id: I80a0d9ad2be6094dd8c4fa6b0fcbf533865b5082
Bug-Url: https://bugzilla.redhat.com/1072794
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 6 insertions(+), 7 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25532
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80a0d9ad2be6094dd8c4fa6b0fcbf533865b5082
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-dwh[master]: packaging: setup: remove: disable service only if actually e...
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: remove: disable service only if actually exists
......................................................................
packaging: setup: remove: disable service only if actually exists
Change-Id: Ic97daa76dfb365c85d7f69d49b0a034de5c17a41
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/core/service.py
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic97daa76dfb365c85d7f69d49b0a034de5c17a41
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 9 months
Change in ovirt-dwh[master]: packaging: setup: database: align manual instructions with d...
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: database: align manual instructions with defaults
......................................................................
packaging: setup: database: align manual instructions with defaults
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067548
Change-Id: I3bc5329aff8898f406eb02f3544e165b115ea9b4
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25510
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bc5329aff8898f406eb02f3544e165b115ea9b4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 9 months
Change in ovirt-engine[master]: core: fail deletion of template/template disk with derived d...
by laravot@redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: fail deletion of template/template disk with derived disks
......................................................................
core: fail deletion of template/template disk with derived disks
*When a template disk has derived disks on the selected domain for
deletion, the deletion should fail with a proper message.
*When deleting a template with derived disks, the deletion should fail
with proper message.
Change-Id: Ifca48993f40f3c5f7b603f33add7049e78e6c4e9
Bug-Url: https://bugzilla.redhat.com/953492
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 100 insertions(+), 2 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifca48993f40f3c5f7b603f33add7049e78e6c4e9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months