Change in ovirt-engine[master]: core: remove scheduler from ejb jars
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: remove scheduler from ejb jars
......................................................................
core: remove scheduler from ejb jars
Change-Id: I6ddb1fa959c10a228a3567c79533f25385ec29d2
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M ear/pom.xml
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Yair Zaslavsky: Verified
--
To view, visit http://gerrit.ovirt.org/25453
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ddb1fa959c10a228a3567c79533f25385ec29d2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[master]: engine: Remove invalid action groups
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Remove invalid action groups
......................................................................
engine: Remove invalid action groups
Invalid action groups were added to various roles
for network labels actions. Those action groups
aren't being used and have no representation on
the engine, therefore they should be removed.
Change-Id: I892378087fdbad15b4b1606c9e55c8d86d8503d0
Bug-Url: https://bugzilla.redhat.com/1072501
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_05_0090_delete_network_labels_action_groups.sql
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25434
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I892378087fdbad15b4b1606c9e55c8d86d8503d0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[master]: core: Remove dependency on scheduler
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Remove dependency on scheduler
......................................................................
core: Remove dependency on scheduler
This jar does not exist anymore
Change-Id: I1a230a48290374ae2dcb15d6f7cf1d69f3adcf94
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M ear/pom.xml
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Yair Zaslavsky: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a230a48290374ae2dcb15d6f7cf1d69f3adcf94
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[master]: core: Fix group id on updating cache of users
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix group id on updating cache of users
......................................................................
core: Fix group id on updating cache of users
When db users cache is updated in refreshAllUsers, also user groups
membership is updated. If some group is not in local db, by mistake
externald id of group is set to user groups instead of internal one.
This patch sets empty GUID for groups that are not stored in local db.
Change-Id: I84d04420bc508f482c6ed4466e6937d8741bfe62
Bug-Url: https://bugzilla.redhat.com/1073235
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
1 file changed, 12 insertions(+), 6 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84d04420bc508f482c6ed4466e6937d8741bfe62
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix FindBugs issue in EventNotificationMethod
......................................................................
core: Fix FindBugs issue in EventNotificationMethod
Fixes FindBugs issue in EventNotificationMethod introduced in commit
53074bc0614da9d4ef18b83bd8ba12e463c3ec09
Change-Id: I3dafb358db93280d58e40ca1056230ae1dba1767
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationMethod.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25309
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dafb358db93280d58e40ca1056230ae1dba1767
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: changes to scheduler module
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: changes to scheduler module
......................................................................
core: changes to scheduler module
1. Moved all the scheduler code to utils
2. Changed The shceudler to be a non EJB singletone
(in the future this will be CDI bean)
Change-Id: Iaf02ee983d0d27ea580c0d0d3ae05e466d8c7051
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M Makefile
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
M backend/manager/modules/pom.xml
D backend/manager/modules/scheduler/exclude-filters.xml
D backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanType.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EngineEJBUtilsStrategy.java
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/timer/FixedDelayJobListener.java
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/timer/JobWrapper.java
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/timer/OnTimerMethodAnnotation.java
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java
M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java
M backend/manager/modules/vdsbroker/pom.xml
M ovirt-engine.spec.in
19 files changed, 21 insertions(+), 170 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf02ee983d0d27ea580c0d0d3ae05e466d8c7051
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in otopi[master]: core: log: support overlapping filters
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: log: support overlapping filters
......................................................................
core: log: support overlapping filters
currently we filter using simple substitution, this is not good for
overlapping patterns.
filter:
aaabbbccc
when filter is:
bbb
aaabbbccc
or:
bcc
bbb
etc...
Change-Id: I512425cf2d1f56cdaf1c386fa105f7e335ae10c4
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M src/plugins/otopi/core/log.py
2 files changed, 52 insertions(+), 13 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I512425cf2d1f56cdaf1c386fa105f7e335ae10c4
Gerrit-PatchSet: 3
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 3 months
Change in ovirt-engine[master]: engine: Can't add user without system level admin permission
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: Can't add user without system level admin permission
......................................................................
engine: Can't add user without system level admin permission
This patch fixes a regression introduced at Ib62e1c051bc78b8a9ec0f32e6ba4eb9484242591
1. Introducing a new permission of adding non existing users - this is required, as the other options are:
a. Using the existing "manipulate users" permission - this will cause a regression, allowing roles to add users directly without the need to use the add permissions dialogs.
b. Removing the permission check for non existing users/groups - this will break https://bugzilla.redhat.com/923100
2. The new permission is added to all the roles that have manipulate permissions manipulation -
this is done in order to fix the above regression.
Change-Id: I308f9cc5edb53b9633d768fd3d382dc9cf62031c
Bug-Url: https://bugzilla.redhat.com/1070651
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
A packaging/dbscripts/upgrade/03_05_0080_add_missing_manipulate_users_permissions.sql
9 files changed, 44 insertions(+), 4 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25225
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I308f9cc5edb53b9633d768fd3d382dc9cf62031c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Host network interface subtab data
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Host network interface subtab data
......................................................................
webadmin: Host network interface subtab data
- Fixed issue where when pressing refresh on the main tab
grid, and the network interface subtab was open the data
for the subtab would disappear.
Change-Id: Ibb539f95353992f589d251629be76f02a0196d18
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066827
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25363
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb539f95353992f589d251629be76f02a0196d18
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.4]: restapi: adding support for affinity groups
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi: adding support for affinity groups
......................................................................
restapi: adding support for affinity groups
* Adding a new affinity groups sub-collections for clusters:
GET /clusters/{cluster_id}/affinitygroups
* affinity groups action includes, add, update and remove affinity groups:
POST /clusters/{cluster_id}/affinitygroups/
<affinity_group>
<name>
<positive>
<enforcing>
</..>
GET/DELETE/PUT /clusters/{cluster_id}/affinitygroups/{affinity_group_id}
* Adding VMs sub-collection for a single affinity group: allowing to add/remove
VMs from an affinity group using post/delete:
GET /clusters/{cluster_id}/affinitygroups/{affinity_group_id}/vms
POST /clusters/{cluster_id}/affinitygroups/{affinity_group_id}/vms
<vm id='{vm_id}'>
</vm>
DELETE /clusters/{cluster_id}/affinitygroups/{affinity_group_id}/vms/{vm_id}
* include tests for added resources
For more information please refer
to: http://www.ovirt.org/Features/VM-Affinity
Change-Id: Ie2daa18742eca73517ef739e70e972d74aad4244
Bug-Url: https://bugzilla.redhat.com/1036638
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AffinityGroupResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AffinityGroupVmsResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AffinityGroupsResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ClusterResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupVmsResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupVmsResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupsResourceTest.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/AffinityGroupMapper.java
A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/AffinityGroupMapperTest.java
17 files changed, 870 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Juan Hernandez: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/24069
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2daa18742eca73517ef739e70e972d74aad4244
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months