April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core, webadmin: [Fix] Run Once: avoid SPICE in ppc64 VMs
by tjelinek＠redhat.com 14 Apr '14

14 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core, webadmin: [Fix] Run Once: avoid SPICE in ppc64 VMs ...................................................................... core, webadmin: [Fix] Run Once: avoid SPICE in ppc64 VMs The Run Once command and the respective dialog on the frontend allowed the selection of the SPICE display protocol in ppc64 VMs. Since this is not supported, this change blocks this. Change-Id: Ic20fb0174710ae25057ea6a798add648fc868933 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067561 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 2 files changed, 25 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4e0612473c2df0cb13a3e6c0995340ce73532b9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added scripts for 3.4 to latest upgrade job
by dcaroest＠redhat.com 14 Apr '14

14 Apr '14

David Caro has submitted this change and it was merged. Change subject: Added scripts for 3.4 to latest upgrade job ...................................................................... Added scripts for 3.4 to latest upgrade job One script to build the engine rpms, one script to do the upgrade and one script to do the cleanup and log gathering Change-Id: I869ec85c9990677c52ca61549fce4f50f2650f33 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/ovirt-engine_upgrade_stable_to_3.4/build_engine_rpm.sh A jobs/ovirt-engine_upgrade_stable_to_3.4/cleanup.file.otopi A jobs/ovirt-engine_upgrade_stable_to_3.4/cleanup.sh A jobs/ovirt-engine_upgrade_stable_to_3.4/setup.file.otopi A jobs/ovirt-engine_upgrade_stable_to_3.4/upgrade.sh 5 files changed, 743 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I869ec85c9990677c52ca61549fce4f50f2650f33 Gerrit-PatchSet: 22 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.1]: packaging: setup: allow boot from host's cdrom
by sbonazzo＠redhat.com 14 Apr '14

14 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: allow boot from host's cdrom ...................................................................... packaging: setup: allow boot from host's cdrom Allow boot from host's cdrom. Change-Id: I71d3f503ce6b49d11a297cd010b182b5b2804065 Bug-Url: https://bugzilla.redhat.com/1082028 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py 1 file changed, 45 insertions(+), 17 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71d3f503ce6b49d11a297cd010b182b5b2804065 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin,userportal: clone VM
by tjelinek＠redhat.com 14 Apr '14

14 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin,userportal: clone VM ...................................................................... webadmin,userportal: clone VM Implementation of the clone VM feature. - Adds a new button to the UP/WA Vm lists - Adds a new dialog which contains: - clone name - calls the CloneVmCommand Change-Id: I6ae2bca7ce33412da3881ccadc9bb1543e32ace2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058832 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloneVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/CloneVmPopupPresenterWidget.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/CloneVmPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/CloneVmPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/CloneVmPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 18 files changed, 443 insertions(+), 23 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ae2bca7ce33412da3881ccadc9bb1543e32ace2 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: test negative flows for pattern-based name
by iheim＠redhat.com 13 Apr '14

13 Apr '14

Itamar Heim has submitted this change and it was merged. Change subject: core: test negative flows for pattern-based name ...................................................................... core: test negative flows for pattern-based name Validate pattern-based names are not supported for VMs and Templates. In addition, additional test was added to AddVmPoolWithVmsCommandTest to validate that the validations pass when the pool's name is not pattern-based as well. Change-Id: I893a117a8eaa6abcb9d15abf599eb31426baab35 Bug-Url: https://bugzilla.redhat.com/1078875 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 4 files changed, 49 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/26625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I893a117a8eaa6abcb9d15abf599eb31426baab35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: fix support for pattern-based name for pool
by iheim＠redhat.com 13 Apr '14

13 Apr '14

Itamar Heim has submitted this change and it was merged. Change subject: core: fix support for pattern-based name for pool ...................................................................... core: fix support for pattern-based name for pool Adding the validation group 'CreateEntity' to UpdateVmPoolWithVmsCommand caused a regression that prevented to set pattern-based name for pool. The problem was that the validation which is declared on VmStatic#getName was checked also for pools and it doesn't accept name that contains '?'. The solution is to introduce 4 additional validation groups for create & update VMs and for create & update Templates, which extend the 'CreateEntity' and 'CreateUpdate' groups, and to change the groups of the validation on VmStatic#getName to these instead of 'CreateEntity' and 'CreateUpdate'. This change is safe because every validation that was checked before will still be checked since the new groups extend the previous ones, except for the validation on VmStatic#getName which will be checked only for commands that add or update VM or Template. Change-Id: I5bfa9fb37d464dd0e77b0bc206c1804713ed9575 Bug-Url: https://bugzilla.redhat.com/1078875 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/group/CreateVm.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/group/UpdateVm.java 7 files changed, 31 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/26624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bfa9fb37d464dd0e77b0bc206c1804713ed9575 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Allow empty gateway
by iheim＠redhat.com 13 Apr '14

13 Apr '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Allow empty gateway ...................................................................... webadmin: Allow empty gateway I think the previous code was attempting to do the same thing, but did so in an inconsistent manner. Change-Id: I3aa805267e35c7f4f84b6c155db8bb002f5dc62a Bug-Url: https://bugzilla.redhat.com/1075981 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/26297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aa805267e35c7f4f84b6c155db8bb002f5dc62a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Disable iSCSI multipathing for datacenters < 3.4
by iheim＠redhat.com 13 Apr '14

13 Apr '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Disable iSCSI multipathing for datacenters < 3.4 ...................................................................... engine: Disable iSCSI multipathing for datacenters < 3.4 I had to fix a few issues in VDSM 3.4 in order to support configuration of iSCSI multipathing, therefore this feature should be disabled for earlier datacenter versions. Change-Id: I623cd917ca0871a9d3d09c2d30ec2dfc114d383e Bug-Url: https://bugzilla.redhat.com/1078137 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 5 files changed, 43 insertions(+), 14 deletions(-) Approvals: Sergey Gotliv: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I623cd917ca0871a9d3d09c2d30ec2dfc114d383e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Set default tpgt value to 1
by iheim＠redhat.com 13 Apr '14

13 Apr '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Set default tpgt value to 1 ...................................................................... engine: Set default tpgt value to 1 Engine uses wrong iSCSI terminology, portal instead of tpgt (target portal group tag) which only purpose at this stage impose iSCSI layer to create node record in the new format supporting multipathing. Tpgt default value in VDSM is 1 so it should be the same here. Change-Id: I7ebfc1335b051e02f62b9544d2500416818940d0 Bug-Url: https://bugzilla.redhat.com/1078137 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/StorageDomainHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java 5 files changed, 7 insertions(+), 6 deletions(-) Approvals: Sergey Gotliv: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ebfc1335b051e02f62b9544d2500416818940d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Send ifaceName and tpgt in connectStorageServer
by iheim＠redhat.com 13 Apr '14

13 Apr '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Send ifaceName and tpgt in connectStorageServer ...................................................................... engine: Send ifaceName and tpgt in connectStorageServer Engine mistakenly sent initiatorName instead of ifaceName which overwrote existing initiatorName configured in the host. Wrong initiatorName caused host fail to perform iSCSI connection. In case of tpgt the problem is terminology. Engine sent it as a "portal" and its value is integer, but from the iSCSI perspective portal is an access point to one or more targets, while this integer actually represents a tpgt - target portal group tag which is numeric representation of which IP addresses a target is allowed to bind on. Bug-Url: https://bugzilla.redhat.com/1078137 Change-Id: Ife467feb8aad9711da5d6a5df305e50fe6bf51e9 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sergey Gotliv: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife467feb8aad9711da5d6a5df305e50fe6bf51e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0